fix(wallet): send idempotency key for top-ups#155
Merged
Conversation
![propel-code-bot[bot]](https://avatars.githubusercontent.com/in/1179004?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces idempotency keys for wallet top-up operations to prevent duplicate transactions. The changes include updating the paymentsAPI service, the topUpWallet store function, and adding unit tests. A review comment highlights that generating the idempotency key inside the topUpWallet function may lead to double-charging during retries, as a new key would be generated for each attempt; it is recommended to generate the key in the UI layer instead to ensure it remains stable across retries.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idempotency_keywith wallet top-up requests from the web appVerification
pnpm --filter @hena-wadeena/web test -- src/lib/__tests__/wallet-store.spec.tspnpm --filter @hena-wadeena/web typecheckContext
The identity service requires
amountandidempotency_keyfor/api/v1/wallet/topup. The web app was only sendingamount, which caused wallet top-up failures.