|
| 1 | +package walqt |
| 2 | + |
| 3 | +import ( |
| 4 | + "slices" |
| 5 | + "testing" |
| 6 | +) |
| 7 | + |
| 8 | +func TestValidateEnvEntries(t *testing.T) { |
| 9 | + cases := []struct { |
| 10 | + name string |
| 11 | + entries []string |
| 12 | + wantErr bool |
| 13 | + }{ |
| 14 | + {"nil", nil, false}, |
| 15 | + {"valid chromium flags", []string{"QTWEBENGINE_CHROMIUM_FLAGS=--disable-gpu --ignore-gpu-blocklist"}, false}, |
| 16 | + {"valid multiple", []string{"QSG_RHI_BACKEND=software", "LIBGL_ALWAYS_SOFTWARE=1"}, false}, |
| 17 | + {"empty value allowed", []string{"FOO="}, false}, |
| 18 | + {"missing equals", []string{"NOEQUALS"}, true}, |
| 19 | + {"empty key", []string{"=value"}, true}, |
| 20 | + {"whitespace in key", []string{"BAD KEY=v"}, true}, |
| 21 | + {"protected WAYLAND_DISPLAY", []string{"WAYLAND_DISPLAY=wayland-9"}, true}, |
| 22 | + {"protected key case-insensitive", []string{"path=/evil"}, true}, |
| 23 | + {"protected LD_PRELOAD", []string{"LD_PRELOAD=/tmp/x.so"}, true}, |
| 24 | + } |
| 25 | + for _, tc := range cases { |
| 26 | + t.Run(tc.name, func(t *testing.T) { |
| 27 | + err := validateEnvEntries(tc.entries) |
| 28 | + if (err != nil) != tc.wantErr { |
| 29 | + t.Fatalf("validateEnvEntries(%v) err = %v, wantErr %v", tc.entries, err, tc.wantErr) |
| 30 | + } |
| 31 | + }) |
| 32 | + } |
| 33 | +} |
| 34 | + |
| 35 | +func TestMergeProcessEnv(t *testing.T) { |
| 36 | + base := []string{"PATH=/usr/bin", "HOME=/home/u"} |
| 37 | + |
| 38 | + if got := mergeProcessEnv(base, nil); !slices.Equal(got, base) { |
| 39 | + t.Fatalf("empty extra: got %v, want %v", got, base) |
| 40 | + } |
| 41 | + |
| 42 | + got := mergeProcessEnv(base, []string{"FOO=bar", " ", "BAZ=qux"}) |
| 43 | + want := []string{"PATH=/usr/bin", "HOME=/home/u", "FOO=bar", "BAZ=qux"} |
| 44 | + if !slices.Equal(got, want) { |
| 45 | + t.Fatalf("merge: got %v, want %v", got, want) |
| 46 | + } |
| 47 | +} |
| 48 | + |
| 49 | +func TestValidateConfigRejectsProtectedEnv(t *testing.T) { |
| 50 | + b := New() |
| 51 | + if err := b.ValidateConfig([]byte(`{"env":["QT_SCALE_FACTOR=2"]}`)); err != nil { |
| 52 | + t.Fatalf("valid env rejected: %v", err) |
| 53 | + } |
| 54 | + if err := b.ValidateConfig([]byte(`{"env":["PATH=/evil"]}`)); err == nil { |
| 55 | + t.Fatal("protected env key accepted, want rejection") |
| 56 | + } |
| 57 | +} |
0 commit comments