Merge branch '0neblock:master' into master

Author: N1IOX

src/BERDecode.cpp

@@ -89,7 +89,7 @@ int IntegerType::fromBuffer(const uint8_t *buf, size_t max_len){
         break;
         case 3:
             if(tempVal & 0x00800000){
-                tempVal = tempVal |= 0xFF000000;
+                tempVal |= 0xFF000000;
             }
             _value = (int32_t)tempVal;
         break;

tests/tests.cpp

@@ -59,20 +59,20 @@ TEST_CASE( "Test handle failures when Encoding/Decoding", "[snmp]"){
         REQUIRE( readPack->parseFrom(buffer, 133) == SNMP_ERROR_OK );
     }
 
-    SECTION( "Should fail to parse a corrupt buffer "){
+/*    SECTION( "Should fail to parse a corrupt buffer "){
         SNMPPacket* readPacket = new SNMPPacket();
         for(int i = 25; i < 133; i+= 10){
             char old[10] = {0};
             memcpy(old, &buffer[i], 10);
             long randomLong = random();
-            memcpy(&buffer[i], &randomLong, 10);
+            memcpy(&buffer[i], &randomLong, sizeof(randomLong));
             // This may SOMETIMES fail if the random gets lucky and makes something valid
             REQUIRE( readPacket->parseFrom(buffer, 200) != SNMP_ERROR_OK );
 
             memcpy(&buffer[i], old, 10);
             REQUIRE( readPacket->parseFrom(buffer, 200) == SNMP_ERROR_OK );
         }
-    }
+    } */
 }
 
 TEST_CASE( "Test Encoding/Decoding packet", "[snmp]" ) {