Internal pagination when fetching resources for CLI dump (rancher#4588)

Author: p-se

e2e/single-cluster/cli_dump_test.go

@@ -12,6 +12,7 @@ import (
 
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
+
 	"github.com/rancher/fleet/e2e/testenv"
 	"github.com/rancher/fleet/internal/cmd/cli/dump"
 )

integrationtests/cli/dump/suite_test.go

@@ -10,6 +10,7 @@ import (
 
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
+
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset/scheme"
 	"k8s.io/client-go/rest"

internal/cmd/builder.go

@@ -108,6 +108,8 @@ func Command(obj Runnable, cmd cobra.Command) *cobra.Command {
 
 		flags := c.PersistentFlags()
 		switch fieldType.Type.Kind() {
+		case reflect.Int64:
+			flags.Int64VarP((*int64)(unsafe.Pointer(v.Addr().Pointer())), name, alias, int64(defInt), usage)
 		case reflect.Int:
 			flags.IntVarP((*int)(unsafe.Pointer(v.Addr().Pointer())), name, alias, defInt, usage)
 		case reflect.String:
@@ -151,6 +153,11 @@ func Command(obj Runnable, cmd cobra.Command) *cobra.Command {
 					if err == nil && fv == defInt {
 						_ = flags.Set(name, v)
 					}
+				case reflect.Int64:
+					fv, err := flags.GetInt64(name)
+					if err == nil && fv == int64(defInt) {
+						_ = flags.Set(name, v)
+					}
 				default:
 					// unsupported
 				}

internal/cmd/cli/dump.go

@@ -5,6 +5,7 @@ import (
 	"os"
 
 	"github.com/spf13/cobra"
+
 	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/log"
 	"sigs.k8s.io/controller-runtime/pkg/log/zap"
@@ -34,6 +35,7 @@ func NewDump() *cobra.Command {
 type Dump struct {
 	FleetClient
 	DumpPath            string `usage:"Destination path for the dump" short:"p"`
+	FetchLimit          int64  `usage:"Limit number of items per resource that are fetched at once (0 means no limit)" short:"l" default:"500"`
 	WithSecrets         bool   `usage:"Include secrets with full data"`
 	WithSecretsMetadata bool   `usage:"Include secrets with metadata only"`
 	WithContent         bool   `usage:"Include Content resources with full data"`
@@ -68,10 +70,15 @@ func (d *Dump) Run(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
+	if d.FetchLimit < 0 {
+		return fmt.Errorf("fetch limit must be non-negative, got %d", d.FetchLimit)
+	}
+
 	ctrl.SetLogger(zap.New(zap.UseFlagOptions(&zopts)))
 	ctx := log.IntoContext(cmd.Context(), ctrl.Log)
 
 	opts := dump.Options{
+		FetchLimit:          d.FetchLimit,
 		WithSecrets:         d.WithSecrets,
 		WithSecretsMetadata: d.WithSecretsMetadata,
 		WithContent:         d.WithContent,