fix: shouldSkipRedirect incorrectly skips cross-domain redirects (#942)

Co-authored-by: devinle <devin.leggett@get10up.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Nícholas André <nicholas.andre@fueled.com>

Author: 4 people

.changeset/fix-cross-domain-redirect-skip.md

@@ -0,0 +1,5 @@
+---
+"@headstartwp/core": patch
+---
+
+Fix: shouldSkipRedirect incorrectly skipping cross-domain redirects when pathnames match. Fixes #941

packages/core/src/utils/__tests__/fetchRedirect.ts

@@ -51,4 +51,18 @@ describe('fetchRedirect', () => {
 
 		global.fetch = originalFetch;
 	});
+
+	it('handles cross-domain redirect with same pathname', async () => {
+		const result = await fetchRedirect('/recipe/my-recipe/', 'http://example.com/');
+
+		expect(result.location).toBe('https://www.external-domain.com/recipe/my-recipe/');
+		expect(result.status).toBe(302);
+	});
+
+	it('handles cross-domain redirect with different pathname', async () => {
+		const result = await fetchRedirect('/old-recipe/', 'http://example.com/');
+
+		expect(result.location).toBe('https://www.external-domain.com/new-recipe/');
+		expect(result.status).toBe(301);
+	});
 });

packages/core/src/utils/fetchRedirect.ts

@@ -28,6 +28,11 @@ function shouldSkipRedirect(link: string, redirect: string, sourceUrl: string) {
 		return true;
 	}
 
+	// Cross-domain redirects should never be skipped
+	if (linkURL.host !== redirectURL.host) {
+		return false;
+	}
+
 	const linkParams = linkURL.searchParams;
 	const redirectParams = redirectURL.searchParams;
 

packages/core/test/server-handlers.ts

@@ -36,6 +36,16 @@ const handlers = [
 		return res(redirect('http://example.com/redirect-test-missing-slash', 301));
 	}),
 
+	// Cross-domain redirect with same pathname
+	rest.head('http://example.com/recipe/my-recipe/', (req, res) => {
+		return res(redirect('https://www.external-domain.com/recipe/my-recipe/', 302));
+	}),
+
+	// Cross-domain redirect with different pathname
+	rest.head('http://example.com/old-recipe/', (req, res) => {
+		return res(redirect('https://www.external-domain.com/new-recipe/', 301));
+	}),
+
 	rest.get<DefaultRequestBody, TestEndpointResponse>(/\/test-endpoint/, (req, res, ctx) => {
 		return res(ctx.json({ ok: true }));
 	}),