restartDeal is wrong, inverts the order of the pile

[ThoAppelsin]

98/programs/js-solitaire/src/index.js

Line 327 in 5245105

state.deal.pile.cards = state.deal.deal.cards;

As you restart a deal, you flip the bunch of face-up cards altogether, not one by one. So the card that was at the bottom of the face-up pile becomes the top card in the restarted deal.

Right now, the cards are being flipped one by one. Certainly wrong—think how weird it'd be to do this in real life. And it's not how Win98 Solitaire works either.

The fix is easy. Just reverse the deal.deal.cards here before assigning it to deal.pile.cards.

[ThoAppelsin]

Until the PR is merged, run the following in your browser console for a quick patch:

document.getElementById('js-deck-pile').onclick = () => {
    state.deal.pile.cards = state.deal.deal.cards.reverse();
    state.deal.deal.cards = [];

    for (const card of state.deal.pile.cards) {
        const { el } = getCard(card);
        faceDown(card);
        deckPileEl.appendChild(el);
    }
}

Better yet, make it a bookmarklet:

1. Create a new bookmark and change its address to the following (it's the same one as above on a single line):

javascript:(()=>{document.getElementById('js-deck-pile').onclick=()=>{state.deal.pile.cards=state.deal.deal.cards.reverse();state.deal.deal.cards=[];for(const card of state.deal.pile.cards){const{el}=getCard(card);faceDown(card);deckPileEl.appendChild(el);}}})()

2. Clicking this new bookmark while you're on https://98.js.org/programs/js-solitaire/ will apply the patch, even on your phone. (Tested on iPhone/Safari.)