feat: Helm-managed node placeholders#8413
Merged
Merged
Conversation
Contributor
|
Merging this PR will trigger the following deployment actions. Support deploymentsNo support upgrades will be triggered Staging deployments
Production deployments
|
agoose77
added
the
deployer:skip-deploy
Contributor
Author
|
I'm skipping deploy on this, because it's turned off by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
2i2c runs workshops, and we sometimes get requests to pre-warm the infrastructure. It would be nice to make this quicker / easier to manage.
We have an initiative 2i2c-org/initiatives#51 that tracks the need to reserve nodes ahead of time.
That initiative aims to implement cloud-specific backends to solve the problem. The proposal is a robust approach, but in the meantime we still would benefit from some system of scaling up hubs in a way that reduces toil.
Implementation
This PR replaces previous work to use user placeholders (which fails for >1 node) in favour of using node placeholders. These placeholders just ensure that$N$ nodes are available, and do not respond to load i.e. do not scale up as nodes become used. This differs from user placeholders, which attempt to ensure
$N$replicas are always available.This can be combined with the
userSchedulerto ensure that user nodes are densely packed, rather than spread out, making scale-down less disruptive.