Skip to content

Commit 2c89f5f

Browse files
authored
fix(ci): locale path and docs (Stirling-Tools#7525)
# Description of Changes Update the TOML locale check to match the current frontend path and align comments/docs with the relocated editor and proprietary source layout. This keeps CI filtering and internal references accurate after the frontend reorganization. --- ## Checklist ### General - [ ] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [ ] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [ ] I have performed a self-review of my own code - [ ] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### Translations (if applicable) - [ ] I ran [`scripts/counter_translation.py`](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/docs/counter_translation.md) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have run `task check` to verify linters, typechecks, and tests pass - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/DeveloperGuide.md#7-testing) for more details.
1 parent 9a90797 commit 2c89f5f

3 files changed

Lines changed: 20 additions & 20 deletions

File tree

.github/config/.files.yaml

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
# CI routing infra. Editing the top-level router (build.yml) or this filter
2-
# config re-runs every area's jobs, so every job-gating filter below includes
3-
# *ci. That makes a change to how jobs are dispatched actually exercise those
4-
# jobs (self-testing), instead of a router edit only matching the project filter.
1+
# CI routing infrastructure. Changes to the top-level router (build.yml) or
2+
# this filter configuration rerun every area's jobs. Every job-gating filter
3+
# therefore includes *ci, so routing changes exercise the jobs they affect
4+
# instead of matching only the project filter.
55
ci: &ci
66
- .github/workflows/build.yml
77
- .github/config/.files.yaml
@@ -24,9 +24,9 @@ openapi: &openapi
2424
docker-base: &docker-base
2525
- docker/base/Dockerfile
2626

27-
# Dockerfiles only (base + embedded + unoserver). Gates the slow multi-arch
28-
# (arm64) leg of the PR docker test build: arm64 is only rebuilt when a
29-
# Dockerfile itself changes, not on every code PR.
27+
# Dockerfiles only (base, embedded, and unoserver). The slow multi-architecture
28+
# (arm64) leg of the PR Docker test build runs only when a Dockerfile changes,
29+
# rather than for every code PR.
3030
dockerfiles: &dockerfiles
3131
- docker/**/Dockerfile*
3232

@@ -88,8 +88,8 @@ frontend: &frontend
8888
- .github/workflows/e2e-stubbed.yml
8989
- .github/workflows/e2e-live.yml
9090

91-
# Files that affect the Tauri desktop bundle. Gate the multi-OS Tauri build
92-
# job on changes to any of these.
91+
# Files that affect the Tauri desktop bundle. Changes to any of these files
92+
# trigger the multi-OS Tauri build job.
9393
tauri: &tauri
9494
- *ci
9595
- frontend/editor/src-tauri/**
@@ -102,9 +102,9 @@ tauri: &tauri
102102
- Taskfile.yml
103103
- .taskfiles/desktop.yml
104104

105-
# Files that affect the AI engine (Python tool models, fixers, tests). Gate
106-
# the engine validation job on changes to engine sources or to the Java
107-
# tool surfaces it generates models from.
105+
# Files that affect the AI engine, including its Python tool models, fixers,
106+
# and tests. The engine validation job also runs when the Java tool surfaces
107+
# used to generate those models change.
108108
engine: &engine
109109
- *ci
110110
- engine/**
@@ -114,10 +114,10 @@ engine: &engine
114114
- .taskfiles/engine.yml
115115

116116
# Files that can make the committed generated API models (frontend tool API
117-
# types + engine tool models) go stale: the Java tool surfaces they derive from,
118-
# the generators, the generated files themselves (to catch a hand-edit), and the
119-
# tasks that drive generation. Deliberately excludes the broad frontend/docker/
120-
# testing globs, so a CSS-only PR does not boot the backend to rebuild the spec.
117+
# types and engine tool models) stale: their Java sources, generators,
118+
# generated outputs (to catch hand edits), and generation tasks. Broad
119+
# frontend, Docker, and testing globs are intentionally excluded, so a CSS-only
120+
# PR does not start the backend to rebuild the specification.
121121
generated-models: &generated-models
122122
- *ci
123123
- *openapi
@@ -141,8 +141,8 @@ licenses-backend: &licenses-backend
141141
- ".github/workflows/frontend-backend-licenses-update.yml"
142142
- *build
143143

144-
# Files that can affect premium / enterprise behaviour. Gate the enterprise
145-
# Playwright job on changes to any of these on PRs.
144+
# Files that can affect premium or enterprise behaviour. Changes to any of
145+
# these files trigger the enterprise Playwright job for pull requests.
146146
proprietary: &proprietary
147147
- *ci
148148
- app/proprietary/**

.github/workflows/check_toml.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ jobs:
125125
const changedFiles = files
126126
.filter(file =>
127127
file.status !== "removed" &&
128-
/^frontend\/public\/locales\/[a-zA-Z-]+\/translation\.toml$/.test(file.filename)
128+
/^frontend\/editor\/public\/locales\/[a-zA-Z-]+\/translation\.toml$/.test(file.filename)
129129
)
130130
.map(file => file.filename);
131131

frontend/editor/src/core/services/httpErrorHandler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// frontend/src/services/httpErrorHandler.ts
1+
// frontend/editor/src/core/services/httpErrorHandler.ts
22
import { alert } from "@app/components/toast";
33
import {
44
broadcastErroredFiles,

0 commit comments

Comments
 (0)