Fix any type usage in proprietary/ (Stirling-Tools#5949)

# Description of Changes
Follow on from Stirling-Tools#5934, expanding `any` type usage ban to the
`proprietary/` folder

Author: jbrunton96

frontend/eslint.config.mjs

@@ -83,7 +83,10 @@ export default defineConfig(
   },
   // Folders that have been cleaned up and are now conformant - stricter rules enforced here
   {
-    files: ['src/saas/**/*.{js,mjs,jsx,ts,tsx}'],
+    files: [
+      'src/proprietary/**/*.{js,mjs,jsx,ts,tsx}',
+      'src/saas/**/*.{js,mjs,jsx,ts,tsx}',
+    ],
     languageOptions: {
       parserOptions: {
         project: true,

frontend/src/proprietary/auth/springAuthClient.test.ts

@@ -2,7 +2,7 @@ import { describe, it, expect, beforeEach, vi, afterEach } from 'vitest';
 import { springAuth } from '@app/auth/springAuthClient';
 import { startOAuthNavigation } from '@app/extensions/oauthNavigation';
 import apiClient from '@app/services/apiClient';
-import { AxiosError } from 'axios';
+import { AxiosError, type AxiosResponse, type InternalAxiosRequestConfig } from 'axios';
 
 // Mock apiClient
 vi.mock('@app/services/apiClient');
@@ -45,7 +45,7 @@ describe('SpringAuthClient', () => {
       vi.mocked(apiClient.get).mockResolvedValueOnce({
         status: 200,
         data: { user: mockUser },
-      } as any);
+      } as unknown as AxiosResponse);
 
       const result = await springAuth.getSession();
 
@@ -74,7 +74,7 @@ describe('SpringAuthClient', () => {
           statusText: 'Unauthorized',
           data: {},
           headers: {},
-          config: {} as any,
+          config: {} as InternalAxiosRequestConfig,
         }
       );
 
@@ -102,7 +102,7 @@ describe('SpringAuthClient', () => {
           statusText: 'Forbidden',
           data: {},
           headers: {},
-          config: {} as any,
+          config: {} as InternalAxiosRequestConfig,
         }
       );
 
@@ -141,7 +141,7 @@ describe('SpringAuthClient', () => {
             expires_in: 3600,
           },
         },
-      } as any);
+      } as unknown as AxiosResponse);
 
       // Spy on window.dispatchEvent
       const dispatchEventSpy = vi.spyOn(window, 'dispatchEvent');
@@ -208,7 +208,7 @@ describe('SpringAuthClient', () => {
       vi.mocked(apiClient.post).mockResolvedValueOnce({
         status: 200,
         data: { user: mockUser },
-      } as any);
+      } as unknown as AxiosResponse);
 
       const result = await springAuth.signUp(credentials);
 
@@ -259,7 +259,7 @@ describe('SpringAuthClient', () => {
       vi.mocked(apiClient.post).mockResolvedValueOnce({
         status: 200,
         data: {},
-      } as any);
+      } as unknown as AxiosResponse);
 
       const result = await springAuth.signOut();
 
@@ -308,7 +308,7 @@ describe('SpringAuthClient', () => {
             expires_in: 3600,
           },
         },
-      } as any);
+      } as unknown as AxiosResponse);
 
       const result = await springAuth.refreshSession();
 

frontend/src/proprietary/auth/springAuthClient.ts

@@ -85,7 +85,7 @@ export interface User {
   is_anonymous?: boolean;
   isFirstLogin?: boolean;
   authenticationType?: string;
-  app_metadata?: Record<string, any>;
+  app_metadata?: Record<string, unknown>;
 }
 
 export interface Session {
@@ -447,7 +447,7 @@ class SpringAuthClient {
    */
   async signInWithOAuth(params: {
     provider: OAuthProvider;
-    options?: { redirectTo?: string; queryParams?: Record<string, any> };
+    options?: { redirectTo?: string; queryParams?: Record<string, string> };
   }): Promise<{ error: AuthError | null }> {
     try {
       const redirectPath = normalizeRedirectPath(params.options?.redirectTo);

frontend/src/proprietary/components/shared/ChangeUserPasswordModal.tsx

@@ -1,4 +1,5 @@
 import { useEffect, useMemo, useState } from 'react';
+import { isAxiosError } from 'axios';
 import { useTranslation } from 'react-i18next';
 import {
   ActionIcon,
@@ -125,8 +126,10 @@ export default function ChangeUserPasswordModal({ opened, onClose, user, onSucce
       alert({ alertType: 'success', title: t('workspace.people.changePassword.success', 'Password updated successfully') });
       onSuccess();
       handleClose();
-    } catch (error: any) {
-      const errorMessage = error.response?.data?.message || error.response?.data?.error || error.message || t('workspace.people.changePassword.error', 'Failed to update password');
+    } catch (error: unknown) {
+      const errorMessage = isAxiosError(error)
+        ? (error.response?.data?.message || error.response?.data?.error || error.message)
+        : (error instanceof Error ? error.message : undefined) || t('workspace.people.changePassword.error', 'Failed to update password');
       alert({ alertType: 'error', title: errorMessage });
     } finally {
       setProcessing(false);

frontend/src/proprietary/components/shared/DividerWithText.tsx

@@ -12,7 +12,7 @@ interface TextDividerProps {
 export default function DividerWithText({ text, className = '', style, variant = 'default', respondsToDarkMode = true, opacity }: TextDividerProps) {
   const variantClass = variant === 'subcategory' ? 'subcategory' : '';
   const themeClass = respondsToDarkMode ? '' : 'force-light';
-  const styleWithOpacity = opacity !== undefined ? { ...(style || {}), ['--text-divider-opacity' as any]: opacity } : style;
+  const styleWithOpacity = opacity !== undefined ? { ...(style || {}), ['--text-divider-opacity' as string]: opacity } : style;
 
   if (text) {
     return (

frontend/src/proprietary/components/shared/InviteMembersModal.tsx

@@ -1,4 +1,5 @@
 import { useState, useEffect, useRef } from 'react';
+import { isAxiosError } from 'axios';
 import { useTranslation } from 'react-i18next';
 import {
   Modal,
@@ -158,9 +159,11 @@ export default function InviteMembersModal({ opened, onClose, onSuccess }: Invit
         forceChange: false,
         forceMFA: false,
       });
-    } catch (error: any) {
+    } catch (error: unknown) {
       console.error('Failed to invite user:', error);
-      const errorMessage = error.response?.data?.message || error.response?.data?.error || error.message || t('workspace.people.addMember.error');
+      const errorMessage = isAxiosError(error)
+        ? (error.response?.data?.message || error.response?.data?.error || error.message)
+        : (error instanceof Error ? error.message : undefined) || t('workspace.people.addMember.error');
       alert({ alertType: 'error', title: errorMessage });
     } finally {
       setProcessing(false);
@@ -211,12 +214,11 @@ export default function InviteMembersModal({ opened, onClose, onSuccess }: Invit
           body: response.errors || response.error
         });
       }
-    } catch (error: any) {
+    } catch (error: unknown) {
       console.error('Failed to invite users:', error);
-      const errorMessage = error.response?.data?.message ||
-                          error.response?.data?.error ||
-                          error.message ||
-                          t('workspace.people.emailInvite.error', 'Failed to send invites');
+      const errorMessage = isAxiosError(error)
+        ? (error.response?.data?.message || error.response?.data?.error || error.message)
+        : (error instanceof Error ? error.message : undefined) || t('workspace.people.emailInvite.error', 'Failed to send invites');
       alert({ alertType: 'error', title: errorMessage });
     } finally {
       setProcessing(false);
@@ -239,9 +241,11 @@ export default function InviteMembersModal({ opened, onClose, onSuccess }: Invit
       if (inviteLinkForm.sendEmail && inviteLinkForm.email) {
         alert({ alertType: 'success', title: t('workspace.people.inviteLink.emailSent', 'Invite link generated and sent via email') });
       }
-    } catch (error: any) {
+    } catch (error: unknown) {
       console.error('Failed to generate invite link:', error);
-      const errorMessage = error.response?.data?.message || error.response?.data?.error || error.message || t('workspace.people.inviteLink.error', 'Failed to generate invite link');
+      const errorMessage = isAxiosError(error)
+        ? (error.response?.data?.message || error.response?.data?.error || error.message)
+        : (error instanceof Error ? error.message : undefined) || t('workspace.people.inviteLink.error', 'Failed to generate invite link');
       alert({ alertType: 'error', title: errorMessage });
     } finally {
       setProcessing(false);

frontend/src/proprietary/components/shared/ManageBillingButton.tsx

@@ -34,12 +34,12 @@ export const ManageBillingButton: React.FC<ManageBillingButtonProps> = ({
       // Open billing portal in new tab
       window.open(response.url, '_blank');
       setLoading(false);
-    } catch (error: any) {
+    } catch (error: unknown) {
       console.error('Failed to open billing portal:', error);
       alert({
         alertType: 'error',
         title: t('billing.portal.error', 'Failed to open billing portal'),
-        body: error.message || 'Please try again or contact support.',
+        body: (error instanceof Error ? error.message : undefined) || 'Please try again or contact support.',
       });
       setLoading(false);
     }

frontend/src/proprietary/components/shared/UpgradeBanner.tsx

@@ -86,7 +86,7 @@ const UpgradeBanner: React.FC = () => {
   const scenarioProvidesInfo =
     scenarioKey && scenarioKey !== 'unknown' && scenarioKey !== 'licensed';
   const derivedIsAdmin = scenarioProvidesInfo
-    ? scenarioKey!.includes('admin')
+    ? scenarioKey.includes('admin')
     : isAdmin;
   const derivedHasPaidLicense =
     scenarioKey === 'licensed'
@@ -95,10 +95,10 @@ const UpgradeBanner: React.FC = () => {
         ? hasPaidLicense
         : false;
   const derivedIsUnderLimit = scenarioProvidesInfo
-    ? scenarioKey!.includes('under-limit')
+    ? scenarioKey.includes('under-limit')
     : isUnderLimit === true;
   const derivedIsOverLimit = scenarioProvidesInfo
-    ? scenarioKey!.includes('over-limit')
+    ? scenarioKey.includes('over-limit')
     : isOverLimit === true;
 
   const effectiveIsAdmin = scenario

frontend/src/proprietary/components/shared/config/configSections/AdminAdvancedSection.tsx

@@ -1,4 +1,5 @@
 import { useCallback, useEffect, useMemo, useState } from 'react';
+import { isAxiosError } from 'axios';
 import { useTranslation } from 'react-i18next';
 import { NumberInput, Switch, Button, Stack, Paper, Text, Loader, Group, Accordion, TextInput, MultiSelect } from '@mantine/core';
 import { alert } from '@app/components/toast';
@@ -72,7 +73,7 @@ export default function AdminAdvancedSection() {
     isFieldPending,
   } = useAdminSettings<AdvancedSettingsData>({
     sectionName: 'advanced',
-    fetchTransformer: async (): Promise<AdvancedSettingsData & { _pending?: Record<string, any> }> => {
+    fetchTransformer: async (): Promise<AdvancedSettingsData & { _pending?: Record<string, unknown> }> => {
       const [systemResponse, processExecutorResponse] = await Promise.all([
         apiClient.get('/api/v1/admin/settings/section/system'),
         apiClient.get('/api/v1/admin/settings/section/processExecutor')
@@ -81,7 +82,7 @@ export default function AdminAdvancedSection() {
       const systemData = systemResponse.data || {};
       const processExecutorData = processExecutorResponse.data || {};
 
-      const result: AdvancedSettingsData & { _pending?: Record<string, any> } = {
+      const result: AdvancedSettingsData & { _pending?: Record<string, unknown> } = {
         enableAlphaFunctionality: systemData.enableAlphaFunctionality || false,
         maxDPI: systemData.maxDPI || 0,
         enableUrlToPDF: systemData.enableUrlToPDF || false,
@@ -101,7 +102,7 @@ export default function AdminAdvancedSection() {
       };
 
       // Merge pending blocks from both endpoints
-      const pendingBlock: Record<string, any> = {};
+      const pendingBlock: Record<string, unknown> = {};
       if (systemData._pending?.enableAlphaFunctionality !== undefined) {
         pendingBlock.enableAlphaFunctionality = systemData._pending.enableAlphaFunctionality;
       }
@@ -131,7 +132,7 @@ export default function AdminAdvancedSection() {
       return result;
     },
     saveTransformer: (settings) => {
-      const deltaSettings: Record<string, any> = {
+      const deltaSettings: Record<string, unknown> = {
         'system.enableAlphaFunctionality': settings.enableAlphaFunctionality,
         'system.maxDPI': settings.maxDPI,
         'system.enableUrlToPDF': settings.enableUrlToPDF,
@@ -281,9 +282,8 @@ export default function AdminAdvancedSection() {
       setManualDownloadLinks([]);
     } catch (error) {
       console.error('[AdminAdvancedSection] Download tessdata languages failed', error);
-      const response = (error as any)?.response;
-      const status = response?.status;
-      const serverMessage = response?.data?.message;
+      const status = isAxiosError(error) ? error.response?.status : undefined;
+      const serverMessage = isAxiosError(error) ? error.response?.data?.message : undefined;
 
       if (status === 403) {
         console.warn('[AdminAdvancedSection] Tessdata directory not writable, falling back to manual download:', serverMessage);
@@ -309,12 +309,12 @@ export default function AdminAdvancedSection() {
       }
 
       let message: string;
-      if (!response) {
+      if (!isAxiosError(error) || !error.response) {
         message = t(
           'admin.settings.advanced.tessdataDir.downloadErrorNetwork',
           'Download failed due to a network error. Please check your connection and try again.'
         );
-      } else if (status >= 500) {
+      } else if (status !== undefined && status >= 500) {
         message = t(
           'admin.settings.advanced.tessdataDir.downloadErrorServer',
           'The server encountered an error while downloading tessdata languages. Please try again later.'

frontend/src/proprietary/components/shared/config/configSections/AdminAuditSection.tsx

@@ -1,4 +1,5 @@
 import React, { useState, useEffect } from 'react';
+import { isAxiosError } from 'axios';
 import { Tabs, Loader, Alert, Stack, Text, Button, Accordion } from '@mantine/core';
 import { useTranslation } from 'react-i18next';
 import { useNavigate } from 'react-router-dom';
@@ -35,9 +36,9 @@ const AdminAuditSection: React.FC = () => {
         setError(null);
         const status = await auditService.getSystemStatus();
         setSystemStatus(status);
-      } catch (err: any) {
+      } catch (err: unknown) {
         // Check if this is a permission/license error (403/404)
-        const status = err?.response?.status;
+        const status = isAxiosError(err) ? err.response?.status : undefined;
         if (status === 403 || status === 404) {
           setError('enterprise-license-required');
         } else {