Fix any type usage in the saas/ folder (Stirling-Tools#5934)

# Description of Changes
Ages ago I made Stirling-Tools#4835 to try and fix all the `any` type usage in the
system but never got it finished, and there were just too many to review
and ensure it still worked. There's even more now.

My new tactic is to fix folder by folder. This fixes the `any` typing in
the `saas/` folder, and also enables `no-unnecessary-type-assertion`,
which really helps reduce pointless `as` casts that AI generates when
the type is already known. I hope to expand both of these to the rest of
the folders soon, but one folder is better than none.

Author: jbrunton96

frontend/eslint.config.mjs

@@ -59,6 +59,20 @@ export default defineConfig(
       ],
     },
   },
+  // Folders that have been cleaned up and are now conformant - stricter rules enforced here
+  {
+    files: ['src/saas/**/*.{js,mjs,jsx,ts,tsx}'],
+    languageOptions: {
+      parserOptions: {
+        project: true,
+        tsconfigRootDir: import.meta.dirname,
+      },
+    },
+    rules: {
+      '@typescript-eslint/no-explicit-any': 'error',
+      '@typescript-eslint/no-unnecessary-type-assertion': 'error',
+    },
+  },
   // Config for browser scripts
   {
     files: srcGlobs,

frontend/src/global.d.ts

@@ -12,6 +12,12 @@ declare module 'assets/material-symbols-icons.json' {
   export default value;
 }
 
+declare global {
+  interface Window {
+    __STIRLING_PDF_BASE_URL__?: string;
+  }
+}
+
 declare module 'axios' {
   export interface AxiosRequestConfig<_D = unknown> {
     suppressErrorToast?: boolean;

frontend/src/saas/auth/UseSession.tsx

@@ -114,7 +114,7 @@ export function AuthProvider({ children }: { children: ReactNode }) {
       setSubscription(subscriptionInfo)
 
       console.debug('[Auth Debug] Credits fetched successfully:', credits)
-    } catch (error: any) {
+    } catch (error: unknown) {
       console.debug('[Auth Debug] Failed to fetch credits:', error)
       // Don't set error state for credit fetching failures to avoid disrupting auth flow
       // Credits might not be available in all deployments
@@ -149,7 +149,7 @@ export function AuthProvider({ children }: { children: ReactNode }) {
         setIsPro(isProUser)
         console.debug('[Auth Debug] Pro status fetched:', isProUser)
       }
-    } catch (error: any) {
+    } catch (error: unknown) {
       console.debug('[Auth Debug] Failed to fetch pro status:', error)
       setIsPro(false) // Default to false if there's an error
     }
@@ -206,7 +206,7 @@ export function AuthProvider({ children }: { children: ReactNode }) {
       } else {
         setTrialStatus(null)
       }
-    } catch (error: any) {
+    } catch (error: unknown) {
       console.debug('[Auth Debug] Failed to fetch trial status:', error)
       setTrialStatus(null)
     }
@@ -243,7 +243,7 @@ export function AuthProvider({ children }: { children: ReactNode }) {
         setProfilePictureUrl(data.signedUrl)
         console.debug('[Auth Debug] Profile picture URL fetched successfully')
       }
-    } catch (error: any) {
+    } catch (error: unknown) {
       console.debug('[Auth Debug] Failed to fetch profile picture:', error)
       setProfilePictureUrl(null)
     }
@@ -267,7 +267,7 @@ export function AuthProvider({ children }: { children: ReactNode }) {
       const metadata = await getProfilePictureMetadata(currentSession.user.id)
       setProfilePictureMetadata(metadata)
       console.debug('[Auth Debug] Profile picture metadata fetched:', metadata)
-    } catch (error: any) {
+    } catch (error: unknown) {
       console.debug('[Auth Debug] Failed to fetch profile picture metadata:', error)
       setProfilePictureMetadata(null)
     }

frontend/src/saas/auth/supabase.ts

@@ -83,7 +83,7 @@ export const signInAnonymously = async () => {
 // Account linking functions
 export const linkEmailIdentity = async (email: string, password?: string) => {
   try {
-    const updateData: any = { email }
+    const updateData: { email: string; password?: string } = { email }
     if (password) {
       updateData.password = password
     }
@@ -143,7 +143,7 @@ export const linkOAuthIdentity = async (provider: 'google' | 'github' | 'apple'
 }
 
 // Helper function to check if user is anonymous
-export const isUserAnonymous = (user: any) => {
+export const isUserAnonymous = (user: { is_anonymous?: boolean }) => {
   return user?.is_anonymous === true
 }
 

frontend/src/saas/components/shared/ManageBillingButton.tsx

@@ -38,16 +38,16 @@ export function ManageBillingButton({
     setLoading(true);
     setErr(null);
     try {
-      const { data, error } = await supabase.functions.invoke('manage-billing', {
+      const { data, error } = await supabase.functions.invoke<{ url: string; error?: string }>('manage-billing', {
         body: {
         name: 'Functions',
         return_url: returnUrl},
       })
       if (error) throw error;
-      if (!data || 'error' in data) throw new Error((data as any)?.error ?? 'No portal URL');
-      window.location.href = (data as any).url;
-    } catch (e: any) {
-      setErr(e.message ?? 'Could not open billing portal');
+      if (!data || 'error' in data) throw new Error(data?.error ?? 'No portal URL');
+      window.location.href = data.url;
+    } catch (e: unknown) {
+      setErr(e instanceof Error ? e.message : 'Could not open billing portal');
     } finally {
       setLoading(false);
     }

frontend/src/saas/components/shared/StripeCheckoutSaas.tsx

@@ -24,7 +24,7 @@ interface StripeCheckoutProps {
   currency?: string;
   isTrialConversion?: boolean;
   // Proprietary-specific props (for compatibility)
-  planGroup?: any;
+  planGroup?: unknown;
   minimumSeats?: number;
   onLicenseActivated?: (licenseInfo: {licenseType: string; enabled: boolean; maxUsers: number; hasKey: boolean}) => void;
   hostedCheckoutSuccess?: {

frontend/src/saas/components/shared/charts/utils/d3Utils.ts

@@ -162,7 +162,7 @@ export function createScale(domain: [number, number], range: [number, number]) {
  * @param wait The wait time in milliseconds
  * @returns Debounced function
  */
-export function debounce<T extends (...args: any[]) => any>(
+export function debounce<T extends (...args: unknown[]) => unknown>(
   func: T,
   wait: number
 ): (...args: Parameters<T>) => void {

frontend/src/saas/components/shared/config/configSections/Overview.tsx

@@ -149,8 +149,8 @@ const Overview: React.FC<OverviewProps> = ({ onLogoutClick }) => {
 
       // Clear success message after 3 seconds
       setTimeout(() => setSuccess(null), 3000);
-    } catch (error: any) {
-      setProfileError(error.message || 'Failed to switch to custom picture');
+    } catch (error: unknown) {
+      setProfileError(error instanceof Error ? error.message : 'Failed to switch to custom picture');
     } finally {
       setProfileUploading(false);
     }
@@ -181,8 +181,8 @@ const Overview: React.FC<OverviewProps> = ({ onLogoutClick }) => {
       setSuccess('Account upgraded successfully! You can now sign in with your email.');
       setEmail('');
       setPassword('');
-    } catch (err: any) {
-      setUpgradeError(err?.message || 'Failed to upgrade account');
+    } catch (err: unknown) {
+      setUpgradeError(err instanceof Error ? err.message : 'Failed to upgrade account');
     } finally {
       setIsLoading(false);
     }
@@ -404,7 +404,7 @@ const Overview: React.FC<OverviewProps> = ({ onLogoutClick }) => {
                           style={{ width: 16, height: 16 }}
                         />
                       }
-                      onClick={() => handleOAuthUpgrade(provider.id as any)}
+                      onClick={() => handleOAuthUpgrade(provider.id as 'github' | 'google' | 'apple' | 'azure')}
                       disabled={isLoading}
                     >
                       {provider.label}

frontend/src/saas/components/shared/config/configSections/PasswordSecurity.tsx

@@ -55,8 +55,8 @@ const PasswordSecurity: React.FC = () => {
         setOpened(false);
         setDidUpdate(false);
       }, 2000);
-    } catch (e: any) {
-      setError(e?.message || 'Failed to change password');
+    } catch (e: unknown) {
+      setError(e instanceof Error ? e.message : 'Failed to change password');
     } finally {
       setIsLoading(false);
     }

frontend/src/saas/components/shared/config/configSections/apiKeys/hooks/useApiKey.ts

@@ -1,8 +1,11 @@
 import { useCallback, useEffect, useState } from "react";
+import { isAxiosError } from "axios";
 import apiClient from "@app/services/apiClient";
 import { useAuth } from "@app/auth/UseSession";
 import { isUserAnonymous } from "@app/auth/supabase";
 
+type ApiKeyResponse = string | { apiKey?: string };
+
 export function useApiKey() {
   const { session, loading, user } = useAuth();
   const isAnonymous = Boolean(user && isUserAnonymous(user));
@@ -17,24 +20,21 @@ export function useApiKey() {
     setError(null);
     try {
       // Backend is POST for get and update
-      const res = await apiClient.post("/api/v1/user/get-api-key");
-      const value = typeof res.data === "string" ? res.data : res.data?.apiKey;
+      const res = await apiClient.post<ApiKeyResponse>("/api/v1/user/get-api-key");
+      const value = typeof res.data === "string" ? res.data : res.data.apiKey;
       if (typeof value === "string") setApiKey(value);
-    } catch (e: any) {
+    } catch (e: unknown) {
       // If not found, try to create one by calling update endpoint
-      if (e?.response?.status === 404) {
+      if (isAxiosError(e) && e.response?.status === 404) {
         try {
-          const createRes = await apiClient.post("/api/v1/user/update-api-key");
-          const created =
-            typeof createRes.data === "string"
-              ? createRes.data
-              : createRes.data?.apiKey;
+          const createRes = await apiClient.post<ApiKeyResponse>("/api/v1/user/update-api-key");
+          const created = typeof createRes.data === "string" ? createRes.data : createRes.data.apiKey;
           if (typeof created === "string") setApiKey(created);
-        } catch (createErr: any) {
-          setError(createErr);
+        } catch (createErr: unknown) {
+          setError(createErr instanceof Error ? createErr : new Error(String(createErr)));
         }
       } else {
-        setError(e);
+        setError(e instanceof Error ? e : new Error(String(e)));
       }
     } finally {
       setIsLoading(false);
@@ -46,11 +46,11 @@ export function useApiKey() {
     setIsRefreshing(true);
     setError(null);
     try {
-      const res = await apiClient.post("/api/v1/user/update-api-key");
-      const value = typeof res.data === "string" ? res.data : res.data?.apiKey;
+      const res = await apiClient.post<ApiKeyResponse>("/api/v1/user/update-api-key");
+      const value = typeof res.data === "string" ? res.data : res.data.apiKey;
       if (typeof value === "string") setApiKey(value);
-    } catch (e: any) {
-      setError(e);
+    } catch (e: unknown) {
+      setError(e instanceof Error ? e : new Error(String(e)));
     } finally {
       setIsRefreshing(false);
     }