fix: update null handling in results and improve query parameter usage

Author: mm-kgi

source/AAS.TwinEngine.DataEngine/ApplicationLogic/Services/AasRepository/AasRepositoryService.cs

@@ -373,7 +373,7 @@ private async Task<List<IAssetAdministrationShell>> BuildShellsAsync(IEnumerable
 
         var results = await Task.WhenAll(tasks).ConfigureAwait(false);
 
-        return [.. results.Where(s => s is not null).Select(s => s!)];
+        return [.. results.Where(s => s is not null).Select(s => s)];
     }
 
     private static IList<IAssetAdministrationShell> FilterByExternalSubjectId(IList<IAssetAdministrationShell> shells, IList<SpecificAssetId>? filters)

source/AAS.TwinEngine.DataEngine/ApplicationLogic/Services/SubmodelRegistry/SubmodelDescriptorService.cs

@@ -178,7 +178,7 @@ private static bool ProcessShellBatch(List<AasCore.Aas3_1.IAssetAdministrationSh
         {
             var submodelIds = GetSubmodelIdsForShell(shell);
 
-            if (state.CollectSubmodelIds(submodelIds, shell.Id!, pageSize))
+            if (state.CollectSubmodelIds(submodelIds, shell.Id, pageSize))
             {
                 return true;
             }

source/AAS.TwinEngine.DataEngine/ApplicationLogic/Services/SubmodelRepository/SubmodelRepositoryService.cs

@@ -188,7 +188,7 @@ private async Task<List<string>> GetSubmodelIdsForShellAsync(string shellId, Can
         {
             var references = await aasRepositoryTemplateService.GetSubmodelRefByIdAsync(shellId, cancellationToken).ConfigureAwait(false);
 
-            return references.Select(r => r.Keys.FirstOrDefault()?.Value).Where(id => !string.IsNullOrWhiteSpace(id)).ToList()!;
+            return references.Select(r => r.Keys.FirstOrDefault()?.Value).Where(id => !string.IsNullOrWhiteSpace(id)).ToList();
         }
         catch (ResourceNotFoundException ex)
         {
@@ -211,13 +211,7 @@ private async Task<List<ISubmodel>> BuildSubmodelsAsync(List<string> submodelIds
         var results = await Task.WhenAll(tasks).ConfigureAwait(false);
 
         var submodels = new List<ISubmodel>(results.Length);
-        foreach (var result in results)
-        {
-            if (result is not null)
-            {
-                submodels.Add(result);
-            }
-        }
+        submodels.AddRange(results.Where(result => result is not null));
 
         return submodels;
     }

source/AAS.TwinEngine.DataEngine/Infrastructure/Providers/PluginDataProvider/Services/PluginDataProvider.cs

@@ -277,7 +277,7 @@ private static string BuildShellsUrl(int? limit, string? cursor)
                    ? QueryHelpers.AddQueryString(BaseUrl, queryParams!)
                    : BaseUrl;
     }
-    
+
     private static string BuildShellsByAssetIdsUrl(int? limit, string? cursor)
     {
         const string BaseUrl = $"/{ApiPaths.PluginMetadata}/{ShellsEndpoint}";
@@ -294,7 +294,7 @@ private static string BuildShellsByAssetIdsUrl(int? limit, string? cursor)
         }
 
         return queryParams.Count > 0
-                   ? QueryHelpers.AddQueryString(BaseUrl, queryParams!)
+                   ? QueryHelpers.AddQueryString(BaseUrl, queryParams)
                    : BaseUrl;
     }