Skip to content

Commit 171cbee

Browse files
Suite summary should not count waiver test cases as part of test failures
1 parent 04b0e08 commit 171cbee

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

common/log_parser/merge_jsons.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,10 @@ def count_fails_in_json(data):
133133
elif isinstance(res, str):
134134
# e.g. "FAILED (WITH WAIVER)"
135135
if "FAILED" in res.upper() or "FAILURE" in res.upper() or "FAIL" in res.upper():
136-
total_failed += 1
137136
if "(WITH WAIVER)" in res.upper():
138137
total_failed_with_waiver += 1
138+
else
139+
total_failed +=1
139140

140141
# If we found zero subtests across the entire suite => treat that as a fail
141142
if not any_subtests_found:

0 commit comments

Comments
 (0)