Merge branch 'main' into fix/refactor-workflows-deterministic

Author: Abhijeet2409

.github/workflows/approved-issues.yml

@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: Apache-2.0
+
+name: "Approve Issues"
+
+on:
+  issues:
+    types:
+      - labeled
+
+defaults:
+  run:
+    shell: bash
+
+permissions:
+  issues: write
+
+concurrency:
+  group: approve-issues-${{ github.event.issue.number }}
+  cancel-in-progress: false
+
+jobs:
+  approve:
+    if: github.event.label.name == 'approved'
+    name: Approve Issue
+    runs-on: hl-sdk-py-lin-md
+
+    steps:
+      - name: Harden Runner
+        uses: step-security/harden-runner@fe104658747b27e96e4f7e80cd0a94068e53901d # v2.16.1
+        with:
+          egress-policy: audit
+
+      - name: Remove pending-review label
+        uses: actions-ecosystem/action-remove-labels@2ce5d41b4b6aa8503e285553f75ed56e0a40bae0 # v1.3.0
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          labels: pending-review
+
+      - name: Unlock issue
+        run: |
+          gh api \
+            -X DELETE \
+            repos/${{ github.repository }}/issues/${{ github.event.issue.number }}/lock
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Approval comment
+        uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5.0.0
+        with:
+          issue-number: ${{ github.event.issue.number }}
+          body: |
+            Approved by @hiero-ledger/hiero-sdk-python-triage and @hiero-ledger/hiero-sdk-python-committers and @hiero-ledger/hiero-sdk-python-maintainers.

.github/workflows/moderate-new-issues.yml

@@ -0,0 +1,54 @@
+# SPDX-License-Identifier: Apache-2.0
+
+name: "Moderate New Issues"
+
+on:
+  issues:
+    types:
+      - opened
+
+defaults:
+  run:
+    shell: bash
+
+permissions:
+  issues: write
+
+concurrency:
+  group: moderate-issues-${{ github.event.issue.number }}
+  cancel-in-progress: false
+
+jobs:
+  moderate:
+    name: Moderate Issue
+    runs-on: hl-sdk-py-lin-md
+
+    steps:
+      - name: Harden Runner
+        uses: step-security/harden-runner@fe104658747b27e96e4f7e80cd0a94068e53901d # v2.16.1
+        with:
+          egress-policy: audit
+
+      - name: Add pending-review label
+        uses: actions-ecosystem/action-add-labels@bd52874380e3909a1ac983768df6976535ece7f8 # v1.1.0
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          labels: pending-review
+
+      - name: Comment on issue
+        uses: peter-evans/create-or-update-comment@e8674b075228eee787fea43ef493e45ece1004c9 # v5.0.0
+        with:
+          issue-number: ${{ github.event.issue.number }}
+          body: |
+            Thanks for your submission.
+
+            This issue is awaiting approval from @hiero-ledger/hiero-sdk-python-triage and @hiero-ledger/hiero-sdk-python-committers and @hiero-ledger/hiero-sdk-python-maintainers.
+
+      - name: Lock issue (IMPORTANT FIX)
+        run: |
+          gh api \
+            -X PUT \
+            repos/${{ github.repository }}/issues/${{ github.event.issue.number }}/lock \
+            -f lock_reason=off-topic
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

src/hiero_sdk_python/consensus/topic_create_transaction.py

@@ -9,6 +9,8 @@
 
 from __future__ import annotations
 
+from typing import TYPE_CHECKING
+
 from hiero_sdk_python.account.account_id import AccountId
 from hiero_sdk_python.channels import _Channel
 from hiero_sdk_python.crypto.key import Key
@@ -23,6 +25,10 @@
 from hiero_sdk_python.utils.key_utils import key_to_proto
 
 
+if TYPE_CHECKING:
+    from hiero_sdk_python.client.client import Client
+
+
 class TopicCreateTransaction(Transaction):
     """
     Represents a transaction to create a new topic in the Hedera
@@ -187,6 +193,27 @@ def set_fee_exempt_keys(self, keys: list[Key]) -> TopicCreateTransaction:
         self.fee_exempt_keys = keys
         return self
 
+    def freeze_with(self, client: Client) -> TopicCreateTransaction:
+        """
+        Freeze the transaction with the given client.
+
+        If `auto_renew_account` was not explicitly set, automatically assigns it:
+        - If `transaction_id` is already set, use its `account_id`.
+        - Otherwise, fall back to the client's `operator_account_id`.
+
+        Args:
+            client (Client): The client instance to use for setting defaults.
+
+        Returns:
+            TopicCreateTransaction: The current transaction instance for method chaining.
+        """
+        if client is not None and client.operator_account_id is not None and self.auto_renew_account is None:
+            self.auto_renew_account = (
+                self.transaction_id.account_id if self.transaction_id is not None else client.operator_account_id
+            )
+
+        return super().freeze_with(client)
+
     def _to_proto_key(self, key: Key | None):
         """
         Backwards-compatible wrapper around `key_to_proto` for converting SDK keys

tck/handlers/topic.py

@@ -73,9 +73,6 @@ def create_topic(params: CreateTopicParams) -> CreateTopicResponse:
 
     transaction = _build_create_topic_transaction(params)
 
-    if params.autoRenewAccountId is None and client is not None and client.operator_account_id is not None:
-        transaction.set_auto_renew_account(client.operator_account_id)
-
     if params.commonTransactionParams is not None:
         params.commonTransactionParams.apply_common_params(transaction, client)
 

tests/unit/topic_create_transaction_test.py

@@ -23,6 +23,7 @@
 from hiero_sdk_python.response_code import ResponseCode
 from hiero_sdk_python.tokens.custom_fixed_fee import CustomFixedFee
 from hiero_sdk_python.tokens.token_id import TokenId
+from hiero_sdk_python.transaction.transaction_id import TransactionId
 from tests.unit.mock_server import mock_hedera_servers
 
 
@@ -574,3 +575,55 @@ def test_mixed_key_types_in_constructor(mock_account_ids):
     assert transaction_body.consensusCreateTopic.submitKey.ed25519 == ed25519_public.to_bytes_raw()
     assert transaction_body.consensusCreateTopic.fee_schedule_key.HasField("ECDSA_secp256k1")
     assert len(transaction_body.consensusCreateTopic.fee_exempt_key_list) == 2
+
+
+def test_freeze_with_defaults_auto_renew_account_to_operator(mock_client):
+    """Test that freeze_with sets auto_renew_account to operator when not explicitly set."""
+    tx = TopicCreateTransaction(memo="test topic")
+    frozen_tx = tx.freeze_with(mock_client)
+    body = frozen_tx.build_transaction_body()
+
+    assert body.consensusCreateTopic.autoRenewAccount == mock_client.operator_account_id._to_proto()
+
+
+def test_freeze_with_preserves_explicit_auto_renew_account(mock_client):
+    """Test that freeze_with does not override an explicitly set auto_renew_account."""
+    explicit_account = AccountId(0, 0, 9999)
+    tx = TopicCreateTransaction(memo="test topic", auto_renew_account=explicit_account)
+    frozen_tx = tx.freeze_with(mock_client)
+    body = frozen_tx.build_transaction_body()
+
+    assert body.consensusCreateTopic.autoRenewAccount == explicit_account._to_proto()
+
+
+def test_freeze_with_uses_transaction_id_account_when_set(mock_client):
+    """Test that freeze_with uses transaction_id.account_id when transaction_id is set."""
+    tx_account = AccountId(0, 0, 5555)
+    tx = TopicCreateTransaction(memo="test topic")
+    tx.transaction_id = TransactionId.generate(tx_account)
+    frozen_tx = tx.freeze_with(mock_client)
+    body = frozen_tx.build_transaction_body()
+
+    assert body.consensusCreateTopic.autoRenewAccount == tx_account._to_proto()
+
+
+def test_freeze_with_auto_renew_account_set_via_setter(mock_client):
+    """Test that freeze_with preserves auto_renew_account set via set_auto_renew_account."""
+    explicit_account = AccountId(0, 0, 7777)
+    tx = TopicCreateTransaction(memo="test topic")
+    tx.set_auto_renew_account(explicit_account)
+    frozen_tx = tx.freeze_with(mock_client)
+    body = frozen_tx.build_transaction_body()
+
+    assert body.consensusCreateTopic.autoRenewAccount == explicit_account._to_proto()
+
+
+def test_freeze_with_leaves_auto_renew_account_unset_without_operator(mock_client):
+    """Test that freeze_with leaves auto_renew_account unset when operator_account_id is None."""
+    mock_client.operator_account_id = None
+    tx = TopicCreateTransaction(memo="test topic")
+    tx.transaction_id = TransactionId.generate(AccountId(0, 0, 1234))
+    frozen_tx = tx.freeze_with(mock_client)
+    body = frozen_tx.build_transaction_body()
+
+    assert not body.consensusCreateTopic.HasField("autoRenewAccount")