[cueweb] Address review feedback on the Add Show modal

Harden the show proxy routes and remove duplication, matching the patterns used by the rest of CueWeb.

- createshow/route.ts: wrap request.json() in try/catch (400 on malformed JSON instead of an unhandled 500), drop the redundant stringify -> parse round-trip, and pass log=true to handleRoute like the other action routes.
- findshow/route.ts: same JSON hardening, and stop masking failures as "not found" - only a genuine not-found returns { notFound: true }; any other gateway/transport error propagates its real status, so the duplicate-name check can't silently pass during an outage.
- shows/page.tsx: remove the second <ToastContainer/> (and its imports); toasts render through the global <ToastHost/> already mounted in layout.
- create-show-dialog.tsx: use the shared toastSuccess from notify_utils instead of importing react-toastify directly.
- Consolidate the Show type: extend the existing get_utils Show with optional bookingEnabled/dispatchEnabled and have show_utils re-export Show + getShows from get_utils, removing the divergent duplicate definitions. createShow stays a throwing helper so the modal can surface errors inline.
- Add Jest tests for isValidShowName / findShow / createShow / getShows.

Author: ramonfigueiredo

cueweb/app/__tests__/utils/show_utils.test.ts

@@ -0,0 +1,99 @@
+/*
+ * Copyright Contributors to the OpenCue Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import {
+  isValidShowName,
+  findShow,
+  createShow,
+  getShows,
+  type Show,
+} from '@/app/utils/show_utils';
+import { accessGetApi } from '@/app/utils/api_utils';
+
+jest.mock('@/app/utils/api_utils', () => ({
+  accessGetApi: jest.fn(),
+}));
+
+const mockShow: Show = {
+  id: 's1', name: 'myshow', active: true, bookingEnabled: true, dispatchEnabled: true,
+};
+
+describe('show_utils', () => {
+  beforeEach(() => jest.clearAllMocks());
+
+  describe('isValidShowName', () => {
+    it('accepts alphanumeric names', () => {
+      expect(isValidShowName('myShow123')).toBe(true);
+    });
+    it('rejects empty, spaces, and punctuation', () => {
+      expect(isValidShowName('')).toBe(false);
+      expect(isValidShowName('my show')).toBe(false);
+      expect(isValidShowName('my-show')).toBe(false);
+      expect(isValidShowName('show_1')).toBe(false);
+    });
+  });
+
+  describe('findShow', () => {
+    it('posts the name to /api/show/findshow and returns the show', async () => {
+      (accessGetApi as jest.Mock).mockResolvedValue({ show: mockShow });
+
+      await expect(findShow('myshow')).resolves.toEqual(mockShow);
+      expect(accessGetApi).toHaveBeenCalledWith(
+        '/api/show/findshow',
+        JSON.stringify({ name: 'myshow' }),
+      );
+    });
+
+    it('returns null when the gateway reports the show was not found', async () => {
+      (accessGetApi as jest.Mock).mockResolvedValue({ notFound: true });
+      await expect(findShow('nope')).resolves.toBeNull();
+    });
+
+    it('returns null when nothing comes back', async () => {
+      (accessGetApi as jest.Mock).mockResolvedValue(null);
+      await expect(findShow('nope')).resolves.toBeNull();
+    });
+  });
+
+  describe('createShow', () => {
+    it('posts the name to /api/show/createshow and returns the created show', async () => {
+      (accessGetApi as jest.Mock).mockResolvedValue({ show: mockShow });
+
+      await expect(createShow('myshow')).resolves.toEqual(mockShow);
+      expect(accessGetApi).toHaveBeenCalledWith(
+        '/api/show/createshow',
+        JSON.stringify({ name: 'myshow' }),
+      );
+    });
+
+    it('throws when creation fails so the form can surface the error', async () => {
+      (accessGetApi as jest.Mock).mockResolvedValue(null);
+      await expect(createShow('myshow')).rejects.toThrow('Failed to create show');
+    });
+  });
+
+  describe('getShows', () => {
+    it('returns the array of shows', async () => {
+      (accessGetApi as jest.Mock).mockResolvedValue([mockShow]);
+      await expect(getShows()).resolves.toEqual([mockShow]);
+    });
+
+    it('returns [] when the gateway returns a non-array', async () => {
+      (accessGetApi as jest.Mock).mockResolvedValue(null);
+      await expect(getShows()).resolves.toEqual([]);
+    });
+  });
+});

cueweb/app/api/show/createshow/route.ts

@@ -24,13 +24,18 @@ export async function POST(request: NextRequest) {
     return NextResponse.json({ error: 'Invalid method. Only POST is allowed.' }, { status: 405 });
   }
 
-  const body = JSON.stringify(await request.json());
-  const jsonBody = JSON.parse(body);
+  let jsonBody: any;
+  try {
+    jsonBody = await request.json();
+  } catch {
+    return NextResponse.json({ error: 'Invalid JSON in request body' }, { status: 400 });
+  }
   if (!jsonBody || typeof jsonBody !== 'object' || !jsonBody.name) {
     return NextResponse.json({ error: 'Invalid request body: name is required' }, { status: 400 });
   }
 
-  const response = await handleRoute(method, endpoint, body);
+  const body = JSON.stringify(jsonBody);
+  const response = await handleRoute(method, endpoint, body, true);
   const responseData = await response.json();
 
   if (!response.ok) return NextResponse.json({ error: responseData.error }, { status: response.status });

cueweb/app/api/show/findshow/route.ts

@@ -24,18 +24,29 @@ export async function POST(request: NextRequest) {
     return NextResponse.json({ error: 'Invalid method. Only POST is allowed.' }, { status: 405 });
   }
 
-  const body = JSON.stringify(await request.json());
-  const jsonBody = JSON.parse(body);
+  let jsonBody: any;
+  try {
+    jsonBody = await request.json();
+  } catch {
+    return NextResponse.json({ error: 'Invalid JSON in request body' }, { status: 400 });
+  }
   if (!jsonBody || typeof jsonBody !== 'object' || !jsonBody.name) {
     return NextResponse.json({ error: 'Invalid request body: name is required' }, { status: 400 });
   }
 
-  try {
-    const response = await handleRoute(method, endpoint, body);
-    const responseData = await response.json();
-    if (!response.ok) return NextResponse.json({ notFound: true }, { status: 200 });
-    return NextResponse.json({ data: responseData.data }, { status: response.status });
-  } catch {
-    return NextResponse.json({ notFound: true }, { status: 200 });
+  const body = JSON.stringify(jsonBody);
+  const response = await handleRoute(method, endpoint, body);
+  const responseData = await response.json();
+
+  if (!response.ok) {
+    // An unknown show comes back as a not-found error -> report { notFound }.
+    // Any other error is a real failure, so keep its status instead of
+    // reporting the name as available.
+    const message = String(responseData?.error ?? "");
+    if (/not\s*found/i.test(message)) {
+      return NextResponse.json({ notFound: true }, { status: 200 });
+    }
+    return NextResponse.json({ error: responseData.error }, { status: response.status });
   }
+  return NextResponse.json({ data: responseData.data }, { status: response.status });
 }

cueweb/app/shows/page.tsx

@@ -15,16 +15,15 @@
  */
 
 import { getShows } from "@/app/utils/show_utils";
-import { ToastContainer } from "react-toastify";
-import "react-toastify/dist/ReactToastify.css";
 import ShowsClient from "./shows-client";
 
+// Toasts render through the global <ToastHost /> mounted in app/layout.tsx,
+// so this page does not mount its own ToastContainer.
 export default async function ShowsPage() {
   const shows = await getShows();
 
   return (
     <div className="container mx-auto py-10 max-w-[90%]">
-      <ToastContainer />
       <ShowsClient shows={shows} />
     </div>
   );

cueweb/app/utils/get_utils.ts

@@ -96,11 +96,15 @@ export type Proc = {
     unbooked: boolean;
 };
 
-// Minimal Show shape - matches the show.Show proto fields the dashboard cares about.
+// Minimal Show shape - matches the show.Show proto fields the dashboard and
+// the Shows page care about. booking/dispatch are optional so dashboard
+// callers that don't request them still typecheck.
 export type Show = {
     id: string;
     name: string;
     active: boolean;
+    bookingEnabled?: boolean;
+    dispatchEnabled?: boolean;
     showStats?: {
         runningFrames: number;
         pendingFrames: number;

cueweb/app/utils/show_utils.ts

@@ -15,15 +15,12 @@
  */
 
 import { accessGetApi } from "./api_utils";
+import type { Show } from "./get_utils";
 
-// Mirrors the Show proto message at proto/src/show.proto.
-export type Show = {
-  id: string;
-  name: string;
-  active: boolean;
-  bookingEnabled: boolean;
-  dispatchEnabled: boolean;
-};
+// Single source of truth: Show and getShows live in get_utils with the other
+// object getters; re-exported here so the Shows feature imports from one place.
+export type { Show };
+export { getShows } from "./get_utils";
 
 // Show names must be alphanumeric only (no spaces, dashes, or punctuation).
 export function isValidShowName(name: string): boolean {
@@ -38,13 +35,8 @@ export async function findShow(name: string): Promise<Show | null> {
   return response.show ?? null;
 }
 
-// Returns all shows.
-export async function getShows(): Promise<Show[]> {
-  const response = await accessGetApi("/api/show/getshows", JSON.stringify({}));
-  return response ?? [];
-}
-
-// Creates a new show with the given name and returns it.
+// Creates a new show with the given name and returns it. Throws on failure so
+// the modal form can surface the reason inline.
 export async function createShow(name: string): Promise<Show> {
   const body = JSON.stringify({ name });
   const response = await accessGetApi("/api/show/createshow", body);

cueweb/components/ui/create-show-dialog.tsx

@@ -25,8 +25,8 @@ import {
   DialogHeader,
   DialogTitle,
 } from "@/components/ui/dialog";
+import { toastSuccess } from "@/app/utils/notify_utils";
 import * as React from "react";
-import { toast } from "react-toastify";
 
 interface CreateShowDialogProps {
   open: boolean;
@@ -71,7 +71,7 @@ export function CreateShowDialog({ open, onOpenChange, onSuccess }: CreateShowDi
       }
 
       await createShow(trimmed);
-      toast.success(`Show "${trimmed}" created successfully.`);
+      toastSuccess(`Show "${trimmed}" created successfully.`);
       handleOpenChange(false);
       onSuccess?.(trimmed);
     } catch (err) {