Skip to content

Commit e3c692c

Browse files
committed
Don't mix clang/llvm version requirements
PySide only needs llvm as a build_requirements(), don't expose it as a requirements(), otherwise when Conan / openusd tries to mix pyside and osl with conflicting requirements, that won't work. Signed-off-by: Jean-Francois Panisset <panisset@gmail.com>
1 parent 1da2c8d commit e3c692c

2 files changed

Lines changed: 6 additions & 7 deletions

File tree

packages/conan/recipes/openvdb/conanfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ def build_requirements(self):
177177
self.tool_requires("cmake/[>=3.20]")
178178
if self.options.build_ax:
179179
# ASWF: need clang / llvm to build AX, FIXME need better way to determine llvm version
180-
self.tool_requires(f"clang/{os.environ['ASWF_PYSIDE_CLANG_VERSION']}@{self.user}/ci_common{os.environ['CI_COMMON_VERSION']}")
180+
self.tool_requires(f"clang/{os.environ['ASWF_OSL_CLANG_VERSION']}@{self.user}/ci_common{os.environ['CI_COMMON_VERSION']}")
181181
if self._settings_build.os == "Windows":
182182
self.tool_requires("winflexbison/2.5.25")
183183
else:

packages/conan/recipes/pyside/conanfile.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ def requirements(self):
4747
# Conan profile provides real versions
4848
self.requires("cpython/[>=3.0.0]")
4949
self.requires("qt/[>=5.0.0]")
50-
self.requires(f"clang/{os.environ['ASWF_PYSIDE_CLANG_VERSION']}@{self.user}/ci_common{os.environ['CI_COMMON_VERSION']}")
5150
self.requires("md4c/[>=0.0.0]")
5251
self.requires("freetype/[>=2.0.0]")
5352
self.requires("libjpeg-turbo/[>=1.0.0]")
@@ -69,7 +68,7 @@ def build_requirements(self):
6968
if Version(self.version) < "6.0":
7069
self.tool_requires("cpython/[>=3.0.0]")
7170
self.tool_requires("qt/[>=5.0.0]")
72-
self.tool_requires(f"clang/{os.environ['ASWF_PYSIDE_CLANG_VERSION']}@{self.user}/ci_common{os.environ['CI_COMMON_VERSION']}")
71+
self.tool_requires(f"clang/{os.environ['ASWF_PYSIDE_CLANG_VERSION']}@{self.user}/ci_common{os.environ['CI_COMMON_VERSION']}")
7372

7473
def export_sources(self):
7574
export_conandata_patches(self)
@@ -173,7 +172,7 @@ def _buildLinux(self, srcDir):
173172
qtpathName = "qtpaths6" if Version(self.version) >= "6.0" else "qmake"
174173
qmakePath = os.path.join(qtBinPath, qtpathName)
175174

176-
llvmInfo = self.dependencies["clang"]
175+
llvmInfo = self.dependencies.build["clang"]
177176

178177
pythonInfo = self.dependencies["cpython"]
179178
pythonBinPath = os.path.join(
@@ -221,7 +220,7 @@ def _buildMac(self, srcDir):
221220
qtpathName = "qtpaths6" if Version(self.version) >= "6.0" else "qmake"
222221
qmakePath = os.path.join(qtBinPath, qtpatName)
223222

224-
llvmInfo = self.dependencies["clang"]
223+
llvmInfo = self.dependencies.build["clang"]
225224

226225
pythonInfo = self.dependencies["cpython"]
227226
pythonBinPath = os.path.join(
@@ -244,7 +243,7 @@ def _buildWindows(self, srcDir):
244243
qtpathName = "qtpaths6.exe" if Version(self.version) >= "6.0" else "qmake.exe"
245244
qmakePath = os.path.join(qtBinPath, qtpathName)
246245

247-
llvmInfo = self.dependencies["clang"]
246+
llvmInfo = self.dependencies.build["clang"]
248247

249248
pythonBinPath = os.path.join(
250249
self.pythonLocalRoot, "bin", self.dependencies["cpython"].conf_info.python_interp
@@ -338,7 +337,7 @@ def _configure_package_mac(self):
338337
)
339338

340339
self.copy(
341-
src=os.path.join(self.dependencies["clang"].package_folder, "lib"),
340+
src=os.path.join(self.dependencies.build["clang"].package_folder, "lib"),
342341
pattern="libclang.dylib",
343342
dst="bin",
344343
)

0 commit comments

Comments
 (0)