Skip to content

Commit 56ec6c3

Browse files
sudoshiruvnet
andcommitted
chore(test): add bounded 'composer test' alias + drop an unused import (Phase 1 + lint)
- composer test now chains the bounded lanes (unit -> integration -> feature:api -> feature:finngen -> feature:modules); the monolithic php artisan test stays legacy. Closes the Phase 1 test-command decision + acceptance. - Removed an unused useState import in CovariateSelector.tsx (lint 34 -> 33). Co-Authored-By: claude-flow <ruv@ruv.net>
1 parent 8cb4815 commit 56ec6c3

4 files changed

Lines changed: 16 additions & 6 deletions

File tree

backend/composer.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,13 @@
7575
"test:feature:modules": "@php scripts/pest-lane.php tests/Feature/Achilles tests/Feature/Audit tests/Feature/Auth tests/Feature/Broadcasting tests/Feature/Commands tests/Feature/Commons tests/Feature/Crypto tests/Feature/FeatureFlags tests/Feature/Fhir tests/Feature/Gis tests/Feature/Jobs tests/Feature/Migrations tests/Feature/Observability tests/Feature/Omop tests/Feature/Provenance tests/Feature/Security tests/Feature/Services tests/Feature/Shiny tests/Feature/Studies tests/Feature/StudyDesign tests/Feature/Templates tests/Feature/Tenancy tests/Feature/Vocabulary tests/Feature/Wiki --stop-on-failure --exclude-group=environment-bound --do-not-fail-on-warning --do-not-fail-on-risky --do-not-fail-on-deprecation --do-not-fail-on-phpunit-deprecation --do-not-fail-on-phpunit-warning --do-not-fail-on-notice --do-not-fail-on-skipped --do-not-fail-on-incomplete",
7676
"test:integration": "@php scripts/pest-lane.php tests/Integration --stop-on-failure --exclude-group=environment-bound --do-not-fail-on-warning --do-not-fail-on-risky --do-not-fail-on-deprecation --do-not-fail-on-phpunit-deprecation --do-not-fail-on-phpunit-warning --do-not-fail-on-notice --do-not-fail-on-skipped --do-not-fail-on-incomplete",
7777
"test:live-omop": "PARTHENON_LIVE_OMOP_FK_AUDIT=1 php scripts/pest-lane.php tests/Feature/Database --group=live-omop --stop-on-failure --profile --do-not-fail-on-warning --do-not-fail-on-risky --do-not-fail-on-deprecation --do-not-fail-on-phpunit-deprecation --do-not-fail-on-phpunit-warning --do-not-fail-on-notice --do-not-fail-on-skipped --do-not-fail-on-incomplete",
78+
"test": [
79+
"@test:unit",
80+
"@test:integration",
81+
"@test:feature:api",
82+
"@test:feature:finngen",
83+
"@test:feature:modules"
84+
],
7885
"dev": [
7986
"Composer\\Config::disableProcessTimeout",
8087
"npx concurrently -c \"#93c5fd,#c4b5fd,#fb7185,#fdba74\" \"php artisan serve\" \"php artisan queue:listen --tries=1\" \"php artisan pail --timeout=0\" \"npm run dev\" --names=server,queue,logs,vite"

docs/lineage/catalog.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Generated by `python3 scripts/docs/catalog_lineage_docs.py --write-catalog`.
1919
## Summary
2020

2121
- Authored Markdown/MDX files: 934
22-
- Total lines: 419,863
22+
- Total lines: 419,867
2323
- Files missing lineage frontmatter: 0
2424

2525
## Category Counts
@@ -70,7 +70,7 @@ Generated by `python3 scripts/docs/catalog_lineage_docs.py --write-catalog`.
7070
| `docs/lineage/plans/open/2026-05-07-parthenon-ingestion-templates-phase-4-plan-6-fhir-bulk-data-reader.md` | Parthenon Ingestion Templates — Phase 4, Plan 6: HL7 FHIR Bulk Data reader (streaming claims) | 62 | yes | `docs/lineage/plans/open/2026-05-07-parthenon-ingestion-templates-phase-4-plan-6-fhir-bulk-data-reader.md` |
7171
| `docs/lineage/plans/open/2026-05-07-parthenon-ingestion-templates-phase-4-plan-7-federated-mapping-spike.md` | Parthenon Ingestion Templates — Phase 4, Plan 7: Federated mapping review spike | 61 | yes | `docs/lineage/plans/open/2026-05-07-parthenon-ingestion-templates-phase-4-plan-7-federated-mapping-spike.md` |
7272
| `docs/lineage/plans/open/2026-05-07-parthenon-ingestion-templates-phase-4-plan-8-upstream-diff-workflows.md` | Parthenon Ingestion Templates — Phase 4, Plan 8: Quarterly upstream-diff workflows (ARTEMIS + NAACCR) | 53 | yes | `docs/lineage/plans/open/2026-05-07-parthenon-ingestion-templates-phase-4-plan-8-upstream-diff-workflows.md` |
73-
| `docs/lineage/plans/open/2026-06-18-application-completion-plan.md` | Parthenon Application Completion Plan | 496 | yes | `docs/lineage/plans/open/2026-06-18-application-completion-plan.md` |
73+
| `docs/lineage/plans/open/2026-06-18-application-completion-plan.md` | Parthenon Application Completion Plan | 500 | yes | `docs/lineage/plans/open/2026-06-18-application-completion-plan.md` |
7474
| `docs/lineage/plans/open/2026-06-19-production-readiness-roadmap.md` | Parthenon Production-Readiness Roadmap | 351 | yes | `docs/lineage/plans/open/2026-06-19-production-readiness-roadmap.md` |
7575
| `docs/lineage/plans/open/README.md` | Open Plan Backlog | 47 | yes | `docs/lineage/plans/open/README.md` |
7676
| `docs/lineage/plans/open/protocol-to-publication-implementation-plan.md` | Abby — Protocol-to-Publication Pipeline: Implementation Plan | 380 | yes | `docs/lineage/plans/open/protocol-to-publication-implementation-plan.md` |

docs/lineage/plans/open/2026-06-18-application-completion-plan.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ Acceptance evidence:
206206
`SET search_path`.
207207
- [x] Add deterministic SourceContext coverage and live-catalog skip
208208
diagnostics instead of relying on leaked PHPUnit `DB_*` settings.
209-
- [ ] Make backend test output operator-friendly.
209+
- [x] Make backend test output operator-friendly.
210210
- [x] Add documented commands for fast unit, feature, integration, and
211211
environment-bound suites.
212212
- [x] Keep `--stop-on-failure` useful by avoiding silent long-running
@@ -215,8 +215,11 @@ Acceptance evidence:
215215
`environment-bound` grouping with `PARTHENON_LIVE_OMOP_FK_AUDIT=1`.
216216
- [x] Add a JUnit-aware Pest lane runner so known framework deprecation/skips
217217
do not hide the failure/error signal for the bounded Composer lanes.
218-
- [ ] Decide whether `php artisan test --stop-on-failure` should become an
218+
- [x] Decide whether `php artisan test --stop-on-failure` should become an
219219
alias for bounded lanes or remain an unsupported legacy local command.
220+
DECIDED 2026-06-21: added a `composer test` alias that chains the bounded
221+
lanes (unit → integration → feature:api → feature:finngen → feature:modules);
222+
the monolithic `php artisan test` remains an unsupported legacy command.
220223

221224
Acceptance evidence:
222225

@@ -231,8 +234,9 @@ Acceptance evidence:
231234
result.
232235
- [x] `cd backend && composer test:feature:modules` produces a bounded pass/fail
233236
result.
234-
- [ ] `cd backend && php artisan test --stop-on-failure` produces a bounded
237+
- [x] `cd backend && php artisan test --stop-on-failure` produces a bounded
235238
pass/fail result or is deliberately replaced by the Composer lanes.
239+
Deliberately replaced by `composer test` (the bounded Composer-lane alias).
236240
- [x] Achilles routing tests pass in isolation.
237241

238242
## Phase 2 - Repair Lineage And Plan Governance

frontend/src/features/finngen-analyses/components/widgets/CovariateSelector.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// frontend/src/features/finngen-analyses/components/widgets/CovariateSelector.tsx
22
/* eslint-disable @typescript-eslint/ban-ts-comment */
33
// @ts-nocheck — finngen-analyses SP3 in flight; unblock CI build
4-
import { useState } from "react";
54
import type { WidgetProps } from "@rjsf/utils";
65

76
const PRESETS: Record<string, number[]> = {

0 commit comments

Comments
 (0)