fix: request bid modifier fields for readback

Author: Адель

app/yandex_direct.py

@@ -345,7 +345,25 @@ def dictionaries_get(self) -> dict[str, Any]:
     def bidmodifiers_get(self, campaign_id: int | str) -> dict[str, Any]:
         return self._call(
             "bidmodifiers",
-            {"method": "get", "params": {"SelectionCriteria": self._selection_by_campaign(campaign_id)}},
+            {
+                "method": "get",
+                "params": {
+                    "SelectionCriteria": self._selection_by_campaign(campaign_id),
+                    "FieldNames": ["Id", "CampaignId", "AdGroupId", "Level", "Type"],
+                    "MobileAdjustmentFieldNames": ["BidModifier", "OperatingSystemType"],
+                    "TabletAdjustmentFieldNames": ["BidModifier", "OperatingSystemType"],
+                    "DesktopAdjustmentFieldNames": ["BidModifier"],
+                    "DesktopOnlyAdjustmentFieldNames": ["BidModifier"],
+                    "DemographicsAdjustmentFieldNames": ["Gender", "Age", "BidModifier", "Enabled"],
+                    "RetargetingAdjustmentFieldNames": ["RetargetingConditionId", "BidModifier", "Accessible", "Enabled"],
+                    "RegionalAdjustmentFieldNames": ["RegionId", "BidModifier", "Enabled"],
+                    "VideoAdjustmentFieldNames": ["BidModifier"],
+                    "SmartAdAdjustmentFieldNames": ["BidModifier"],
+                    "SerpLayoutAdjustmentFieldNames": ["SerpLayout", "BidModifier", "Enabled"],
+                    "IncomeGradeAdjustmentFieldNames": ["Grade", "BidModifier", "Enabled"],
+                    "AdGroupAdjustmentFieldNames": ["BidModifier"],
+                },
+            },
         )
 
     def bidmodifiers_set(self, payload: dict[str, Any] | list[dict[str, Any]]) -> dict[str, Any]:

tests/test_yandex_extended_methods.py

@@ -52,6 +52,58 @@ def handler(request: httpx.Request) -> httpx.Response:
 
         assert captured["url"] == f"https://api.direct.yandex.com/json/v5/{service}"
         assert captured["body"]["method"] == direct_method
+        if method_name == "bidmodifiers_get":
+            params = captured["body"]["params"]
+            assert params["FieldNames"] == ["Id", "CampaignId", "AdGroupId", "Level", "Type"]
+            assert params["SelectionCriteria"]["CampaignIds"] == [710]
+            assert set(params.keys()) == {
+                "SelectionCriteria",
+                "FieldNames",
+                "MobileAdjustmentFieldNames",
+                "TabletAdjustmentFieldNames",
+                "DesktopAdjustmentFieldNames",
+                "DesktopOnlyAdjustmentFieldNames",
+                "DemographicsAdjustmentFieldNames",
+                "RetargetingAdjustmentFieldNames",
+                "RegionalAdjustmentFieldNames",
+                "VideoAdjustmentFieldNames",
+                "SmartAdAdjustmentFieldNames",
+                "SerpLayoutAdjustmentFieldNames",
+                "IncomeGradeAdjustmentFieldNames",
+                "AdGroupAdjustmentFieldNames",
+            }
+            assert params["MobileAdjustmentFieldNames"] == [
+                "BidModifier",
+                "OperatingSystemType",
+            ]
+            assert params["TabletAdjustmentFieldNames"] == [
+                "BidModifier",
+                "OperatingSystemType",
+            ]
+            assert params["DesktopAdjustmentFieldNames"] == ["BidModifier"]
+            assert params["DesktopOnlyAdjustmentFieldNames"] == ["BidModifier"]
+            assert params["DemographicsAdjustmentFieldNames"] == [
+                "Gender",
+                "Age",
+                "BidModifier",
+                "Enabled",
+            ]
+            assert params["RetargetingAdjustmentFieldNames"] == [
+                "RetargetingConditionId",
+                "BidModifier",
+                "Accessible",
+                "Enabled",
+            ]
+            assert params["RegionalAdjustmentFieldNames"] == ["RegionId", "BidModifier", "Enabled"]
+            assert params["VideoAdjustmentFieldNames"] == ["BidModifier"]
+            assert params["SmartAdAdjustmentFieldNames"] == ["BidModifier"]
+            assert params["SerpLayoutAdjustmentFieldNames"] == [
+                "SerpLayout",
+                "BidModifier",
+                "Enabled",
+            ]
+            assert params["IncomeGradeAdjustmentFieldNames"] == ["Grade", "BidModifier", "Enabled"]
+            assert params["AdGroupAdjustmentFieldNames"] == ["BidModifier"]
         if method_name == "bidmodifiers_set":
             assert captured["body"]["params"]["BidModifiers"] == [
                 {"CampaignId": 710, "Type": "MOBILE"}