ossvc: add openbsd tests

Author: Mizzick

internal/ossvc/service_openbsd.go

@@ -66,18 +66,20 @@ func (sys *openbsdSystem) Interactive() (ok bool) {
 // New implements service.System interface for openbsdSystem.
 func (sys *openbsdSystem) New(i service.Interface, c *service.Config) (s service.Service, err error) {
 	return &openbsdRunComService{
-		cmdCons: sys.cmdCons,
-		i:       i,
-		cfg:     c,
+		cmdCons:     sys.cmdCons,
+		i:           i,
+		cfg:         c,
+		scriptsPath: "/etc/rc.d",
 	}, nil
 }
 
 // openbsdRunComService is the RunCom-based service.Service to be used on the
 // OpenBSD.
 type openbsdRunComService struct {
-	cmdCons executil.CommandConstructor
-	i       service.Interface
-	cfg     *service.Config
+	cmdCons     executil.CommandConstructor
+	i           service.Interface
+	cfg         *service.Config
+	scriptsPath string
 }
 
 // Platform implements service.Service interface for *openbsdRunComService.
@@ -145,9 +147,7 @@ func (s *openbsdRunComService) scriptPath() (cp string, err error) {
 		return "", errNoUserServiceRunCom
 	}
 
-	const scriptPathPref = "/etc/rc.d"
-
-	return filepath.Join(scriptPathPref, s.cfg.Name), nil
+	return filepath.Join(s.scriptsPath, s.cfg.Name), nil
 }
 
 const (
@@ -249,6 +249,7 @@ func (s *openbsdRunComService) writeScript() (err error) {
 	}
 
 	t := s.template()
+	// #nosec CWE-22 -- The path is constructed from constants.
 	f, err := os.Create(scriptPath)
 	if err != nil {
 		return fmt.Errorf("creating rc.d script file: %w", err)
@@ -269,6 +270,7 @@ func (s *openbsdRunComService) writeScript() (err error) {
 	}
 
 	return errors.Annotate(
+		// #nosec CWE-276 -- The permissions are required.
 		os.Chmod(scriptPath, 0o755),
 		"changing rc.d script file permissions: %w",
 	)

internal/ossvc/service_openbsd_internal_test.go

@@ -0,0 +1,139 @@
+//go:build openbsd
+
+package ossvc
+
+import (
+	"fmt"
+	"os"
+	"path/filepath"
+	"testing"
+
+	"github.com/AdguardTeam/golibs/osutil/executil"
+	"github.com/AdguardTeam/golibs/testutil"
+	"github.com/kardianos/service"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestOpenbsdSystem(t *testing.T) {
+	t.Parallel()
+
+	sys := &openbsdSystem{
+		cmdCons: newTestCmdConstructor(t, "", nil),
+	}
+
+	assert.Equal(t, sysVersion, sys.String())
+	assert.True(t, sys.Detect())
+	assert.Equal(t, os.Getppid() != 1, sys.Interactive())
+
+	svc, err := sys.New(emptyInterface{}, &service.Config{
+		Name: testServiceName,
+	})
+	require.NoError(t, err)
+
+	assert.NotNil(t, svc)
+	assert.Equal(t, "openbsd", svc.Platform())
+	assert.Equal(t, testServiceName, svc.String())
+
+	l, err := svc.Logger(nil)
+	require.NoError(t, err)
+
+	assert.NotNil(t, l)
+
+	l, err = svc.SystemLogger(nil)
+	require.NoError(t, err)
+
+	assert.NotNil(t, l)
+}
+
+func TestOpenbsdRunComService(t *testing.T) {
+	t.Parallel()
+
+	scriptsDir := t.TempDir()
+
+	conf := &service.Config{
+		Name: testServiceName,
+	}
+	svc := &openbsdRunComService{
+		cmdCons:     executil.EmptyCommandConstructor{},
+		i:           emptyInterface{},
+		cfg:         conf,
+		scriptsPath: scriptsDir,
+	}
+
+	err := svc.Install()
+	assert.NoError(t, err)
+	assert.FileExists(t, filepath.Join(scriptsDir, testServiceName))
+
+	err = svc.Start()
+	assert.NoError(t, err)
+
+	err = svc.Stop()
+	assert.NoError(t, err)
+
+	err = svc.Restart()
+	assert.NoError(t, err)
+
+	err = svc.Uninstall()
+	assert.NoError(t, err)
+	assert.NoFileExists(t, filepath.Join(scriptsDir, testServiceName))
+}
+
+func TestOpenbsdRunComService_Status(t *testing.T) {
+	t.Parallel()
+
+	scriptsDir := t.TempDir()
+
+	conf := &service.Config{
+		Name: testServiceName,
+	}
+
+	testCases := []struct {
+		cmdErr     error
+		name       string
+		body       string
+		wantErrMsg string
+		wantStatus service.Status
+	}{{
+		name:       "running",
+		body:       fmt.Sprintf("%s(ok)\n", testServiceName),
+		cmdErr:     nil,
+		wantErrMsg: "",
+		wantStatus: service.StatusRunning,
+	}, {
+		name:       "stopped",
+		body:       fmt.Sprintf("%s(failed)\n", testServiceName),
+		cmdErr:     nil,
+		wantErrMsg: "",
+		wantStatus: service.StatusStopped,
+	}, {
+		name:   "unknown_cmd_error",
+		body:   "",
+		cmdErr: assert.AnError,
+		wantErrMsg: "getting status of openbsd-runcom AdGuardHome service: starting: " +
+			assert.AnError.Error(),
+		wantStatus: service.StatusUnknown,
+	}, {
+		name:   "unknown",
+		body:   "",
+		cmdErr: nil,
+		wantErrMsg: "getting status of openbsd-runcom AdGuardHome service: " +
+			service.ErrNotInstalled.Error(),
+		wantStatus: service.StatusUnknown,
+	}}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			svc := &openbsdRunComService{
+				cmdCons:     newTestCmdConstructor(t, tc.body, tc.cmdErr),
+				i:           emptyInterface{},
+				cfg:         conf,
+				scriptsPath: scriptsDir,
+			}
+
+			status, err := svc.Status()
+			assert.Equal(t, tc.wantStatus, status)
+			testutil.AssertErrorMsg(t, tc.wantErrMsg, err)
+		})
+	}
+}