fix: use Symfony Response base class in exception handler and update tests

The respond() callback must accept Symfony's base Response (not just
Illuminate\Http\Response) since redirect responses also pass through it.
Return \$response unchanged for non-Inertia requests instead of null to
avoid a null propagating through the cookie middleware. Update impersonation
tests to expect /control-plane instead of /admin after the redirect fix.

Author: AdilAzhari

bootstrap/app.php

@@ -10,9 +10,9 @@
 use Illuminate\Foundation\Configuration\Exceptions;
 use Illuminate\Foundation\Configuration\Middleware;
 use Illuminate\Http\Request;
-use Illuminate\Http\Response;
 use Inertia\Inertia;
 use Laravel\Sanctum\Http\Middleware\EnsureFrontendRequestsAreStateful;
+use Symfony\Component\HttpFoundation\Response;
 
 return Application::configure(basePath: dirname(__DIR__))
     ->withRouting(
@@ -59,13 +59,17 @@
         __DIR__.'/../app/Domain/*/Listeners',
     ])
     ->withExceptions(function (Exceptions $exceptions): void {
-        $exceptions->respond(function (Response $response, Throwable $e, Request $request): ?Response {
+        $exceptions->respond(function (Response $response, Throwable $e, Request $request): Response {
+            if (! $request->inertia()) {
+                return $response;
+            }
+
             $status = $response->getStatusCode();
 
             $handled = [400, 401, 403, 404, 405, 419, 429, 500, 503];
 
-            if (! in_array($status, $handled, true) || ! $request->inertia()) {
-                return null;
+            if (! in_array($status, $handled, true)) {
+                return $response;
             }
 
             return Inertia::render('Error', [

tests/Feature/AdminImpersonationTest.php

@@ -61,7 +61,7 @@
 
         // Now stop it
         $this->post('/impersonation/stop')
-            ->assertRedirect('/admin');
+            ->assertRedirect('/control-plane');
 
         expect(session('impersonating_as'))->toBeNull()
             ->and(session('original_admin_id'))->toBeNull()
@@ -71,7 +71,7 @@
     it('stop works even with no active impersonation session', function (): void {
         $this->actingAs($this->superAdmin)
             ->post('/impersonation/stop')
-            ->assertRedirect('/admin');
+            ->assertRedirect('/control-plane');
     });
 });