Skip to content

Commit eeefaf3

Browse files
authored
Fix placeholder URL, broken anchor, and typo in docs (#4)
## Summary - Replace `(do we have github enterprise?)` placeholder in README with the real [Discussions URL](https://github.com/Agent-Control-Standard/ACS/discussions) - Remove stale `<!-- TODO: add diagram -->` comment in `docs/acs.md` (the page already carries a "Work in progress" admonition) - Point empty `[MachineIdentity]()` link in `specification.md` at section 3.17.1, and fix `striung` → `string` typo on the same object's `id` field ## Test plan - [x] `git diff` reviewed — three files, four targeted changes, no collateral edits - [ ] MkDocs renders the spec page without broken anchor warnings (will verify post-merge on the deployed docs)
1 parent 3ab238d commit eeefaf3

3 files changed

Lines changed: 3 additions & 5 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ The standard covers the following aspects
3333

3434
We welcome community contributions to enhance and evolve ACS!
3535

36-
- **Questions & Discussions:** Join our [GitHub Discussions](do we have github enterprise?).
36+
- **Questions & Discussions:** Join our [GitHub Discussions](https://github.com/Agent-Control-Standard/ACS/discussions).
3737
- **Issues & Feedback:** Report issues or suggest improvements via [GitHub Issues](https://github.com/Agent-Control-Standard/ACS/issues).
3838
- **Contribution Guide:** See our [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute.
3939

docs/acs.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ They are an open book
77

88
They have a dynamic bill-of-material, a clear audit trail and hard inline-controls.
99

10-
<!-- TODO: add diagram -->
11-
1210
Trustworthiness of agents builds upon the foundation of existing standards (MCP and A2A), but provides value regardless.
1311
It build upon cybersecurity and observability standards including OpenTelemetry, OCSF, CycloneDX, SPDX and SWID.
1412

docs/spec/instrument/specification.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ Object representing the receiver agent in the A2A protocol communication
455455
### 3.17. `Identity` Object
456456
Object representing identity in the context. This is a union object that can be one of the following:
457457
- [`User`](#310-user-object)
458-
- [`MachineIdentity`]()
458+
- [`MachineIdentity`](#3171-machineidentity-object)
459459
- [`AgentIdentity`](#318-agentidentity-object)
460460

461461

@@ -464,7 +464,7 @@ Object representing a machine identity
464464

465465
| Field Name | Type | Required | Description |
466466
| :--------- | :-------- | :------- | :----------------------------------------------------------------------------------------------------------- |
467-
| `id` | `striung` | Yes | The unique identifier of the application or service. |
467+
| `id` | `string` | Yes | The unique identifier of the application or service. |
468468
| `name` | `string`| Yes | The name of the application or service. |
469469
| `organization` | [`Organization`](#311-organization-object)[] | Yes | The owning organization of the application or service. |
470470
| `metadata` | `Record<string, any>` | No | Arbitrary key-value metadata associated with the identity. |

0 commit comments

Comments
 (0)