chore: apply pr-reviewer fixes for #227

Author: agent-relay-code[bot]

packages/cli/src/local-personas.test.ts

@@ -828,6 +828,20 @@ test('missing local skill file produces a warning and drops the skill, not a thr
   });
 });
 
+test('malformed local skill entries do not crash local path resolution', () => {
+  withLayers(({ cwd, homeDir }) => {
+    writeJson(join(homeDir, 'p.json'), {
+      id: 'p',
+      extends: 'persona-maker',
+      skills: [null]
+    });
+    const loaded = loadLocalPersonas({ cwd, homeDir });
+    const spec = loaded.byId.get('p');
+    assert.ok(spec, 'persona still loads');
+    assert.deepEqual(spec.skills as unknown[], [null]);
+  });
+});
+
 test('missing sidecar file produces a warning, not a throw', () => {
   withLayers(({ cwd, homeDir }) => {
     writeJson(join(homeDir, 'p.json'), {

packages/cli/src/local-personas.ts

@@ -948,6 +948,9 @@ function resolveLocalSkillSources(
   cwd: string
 ): PersonaSkill[] {
   return skills.flatMap((skill) => {
+    if (!skill || typeof skill !== 'object') {
+      return [skill];
+    }
     const source = skill.source;
     if (
       typeof source !== 'string' ||

packages/deploy/src/deploy.test.ts

@@ -357,6 +357,23 @@ test('preflightPersona warns on unknown triggers but does not fail', async () =>
   }
 });
 
+test('preflightPersona reports aliased trigger warnings using authored provider paths', async () => {
+  const { personaPath, cleanup } = await withTempPersona(
+    basePersonaJson({ integrations: { 'google-mail': {} } }),
+    gmailAgentSrc(`'google-mail': [{ on: 'made.up' }]`)
+  );
+  try {
+    const pre = await preflightPersona(personaPath);
+    assert.deepEqual(pre.agent.triggers, {
+      gmail: [{ on: 'made.up' }]
+    });
+    assert.equal(pre.warnings.length, 1);
+    assert.match(pre.warnings[0], /^triggers\.google-mail\[0\]\.on:/);
+  } finally {
+    await cleanup();
+  }
+});
+
 test('preflightPersona accepts canonical gmail triggers for google-mail integrations', async () => {
   const { personaPath, cleanup } = await withTempPersona(
     basePersonaJson({ integrations: { 'google-mail': {} } }),

packages/deploy/src/preflight.ts

@@ -110,14 +110,15 @@ export async function preflightPersona(personaPath: string): Promise<DeployPrefl
     }
   }
 
+  const triggerLint = lintTriggers(agent);
+
   // Normalize trigger provider aliases to canonical names so the cloud API
   // receives e.g. 'gmail' instead of 'google-mail'. The integration-provider
   // check above accepts either the raw alias or the canonical trigger provider
   // when matching persona integrations. Only the outbound agent spec sent to
   // the cloud needs canonical names.
   const normalizedAgent = normalizeTriggerProviderAliases(agent);
 
-  const triggerLint = lintTriggers(normalizedAgent);
   const warnings = triggerLint.map(
     (issue) => `${issue.path}: ${issue.message}`
   );