chore: move IBC utils and types to network package (#12629)

refs: [AGO-349: Update UI to use accountState for target contract](https://linear.app/agoric/issue/AGO-349/update-ui-to-use-accountstate-for-target-contract)

## Description
I need to update the ymax ui to the latest orchestration package to get the latest type and utils, however doing so introduces a runtime dependency on the `@agoric/vats` package in `utils/address.js` (which is needed for the `sameEvmAddress` tool). Because of build complication ymax ui excludes `@agoric/vats` by manually resolving it to an empty package.

The only runtime dependency of orchestration onto the vats package is actually for some IBC utils, which were in its `tools` folder. This change moves those to the `network` package in its `src`, along with some related types and cleaning up the legacy allowance of src -> tools import it was enjoying, ultimately moving the vats package to a dev and optional peer dependency of orchestration (for types/test usage, and tools usage respectively).

### Security Considerations
None

### Scaling Considerations
None

### Documentation Considerations
Some moved types kept re-export from their original path.

### Testing Considerations
Existing linting and tests should keep passing.

### Upgrade Considerations
This shouldn't break anything but NPM consumers may no longer get some types automatically resolving now that `vats` is only a dev dependency of `orchestration`.

Author: mhofman

multichain-testing/tools/address.ts

@@ -1,10 +1,12 @@
-import type { IBCChannelID, IBCConnectionID, IBCPortID } from '@agoric/vats';
 import {
+  type IBCChannelID,
+  type IBCConnectionID,
+  type IBCPortID,
   type LocalIbcAddress,
   type RemoteIbcAddress,
-} from '@agoric/vats/tools/ibc-utils.js';
+} from '@agoric/network/ibc';
 
-// XXX consider moving to vats/tools/ibc-utils by updating current values or renaming as `NEGOTIATED_...`
+// XXX consider moving into network/src/ibc/utils by updating current values or renaming as `NEGOTIATED_...`
 // These take those values and build off of them
 const REMOTE_ADDR_RE =
   /^(?<hops>(?:\/ibc-hop\/[^/]+)*)\/ibc-port\/(?<portID>[^/]+)\/(?<order>ordered|unordered)\/(?<version>{[^}]+})\/ibc-channel\/(?<channelID>[^/]+)$/;

multichain-testing/yarn.lock

@@ -406,7 +406,6 @@ __metadata:
     "@agoric/store": "workspace:*"
     "@agoric/time": "workspace:*"
     "@agoric/vat-data": "workspace:*"
-    "@agoric/vats": "workspace:*"
     "@agoric/vow": "workspace:*"
     "@agoric/zoe": "workspace:*"
     "@agoric/zone": "workspace:*"
@@ -421,6 +420,11 @@ __metadata:
     "@noble/hashes": "npm:~1.5.0"
     bech32: "npm:^2.0.0"
     bs58: "npm:^6.0.0"
+  peerDependencies:
+    "@agoric/vats": "workspace:*"
+  peerDependenciesMeta:
+    "@agoric/vats":
+      optional: true
   languageName: node
   linkType: soft
 

packages/boot/tools/ibc/mocks.ts

@@ -1,8 +1,7 @@
 // @ts-check
 import { createMockAckMap } from '@agoric/orchestration/tools/ibc-mocks.js';
-import type { IBCChannelID, IBCEvent, IBCMethod } from '@agoric/vats';
-
-/** @import { IBCChannelID, IBCMethod, IBCEvent } from '@agoric/vats'; */
+import type { IBCChannelID } from '@agoric/network/ibc';
+import type { IBCEvent, IBCMethod } from '@agoric/vats';
 
 const responses = {
   // {"result":"+/cosmos.staking.v1beta1.MsgDelegateResponse"}

packages/builders/scripts/orchestration/get-chain-config.js

@@ -6,8 +6,8 @@ import fetchedChainInfo from '@agoric/orchestration/src/fetched-chain-info.js';
 import { fetchNetworkConfig } from '@agoric/client-utils';
 
 /**
- * @import {IBCChannelID, IBCConnectionID} from '@agoric/vats';
- * @import {CosmosChainInfo, IBCConnectionInfo} from '@agoric/orchestration'
+ * @import {IBCChannelID, IBCConnectionID, IBCConnectionInfo} from '@agoric/network/ibc';
+ * @import {CosmosChainInfo} from '@agoric/orchestration'
  */
 
 /** @param {string[]} strs */

packages/fast-usdc-contract/src/exos/settler.ts

@@ -49,7 +49,8 @@ import type {
 import { coerceAccountId } from '@agoric/orchestration/src/utils/address.js';
 import type { WithdrawToSeat } from '@agoric/orchestration/src/utils/zoe-tools.js';
 import { mustMatch, type MapStore } from '@agoric/store';
-import type { IBCChannelID, IBCPacket, VTransferIBCEvent } from '@agoric/vats';
+import type { IBCChannelID } from '@agoric/network/ibc';
+import type { IBCPacket, VTransferIBCEvent } from '@agoric/vats';
 import type { TargetRegistration } from '@agoric/vats/src/bridge-target.js';
 import type { Vow, VowTools } from '@agoric/vow';
 import type { ZCF } from '@agoric/zoe/src/zoeService/zoe.js';

packages/fast-usdc-contract/src/fast-usdc.contract.ts

@@ -19,11 +19,11 @@ import {
   type Denom,
   type DenomAmount,
   type DenomDetail,
-  type IBCConnectionInfo,
   type OrchestrationAccount,
   type OrchestrationPowers,
   type OrchestrationTools,
 } from '@agoric/orchestration';
+import type { IBCConnectionInfo } from '@agoric/network/ibc';
 import type { HostForGuest } from '@agoric/orchestration/src/facade.js';
 import { makeZoeTools } from '@agoric/orchestration/src/utils/zoe-tools.js';
 import { provideSingleton } from '@agoric/zoe/src/contractSupport/durability.js';

packages/fast-usdc-deploy/src/fast-usdc-reconfigure.build.js

@@ -12,7 +12,7 @@ import { getManifestForUpdateNobleICA } from './update-noble-ica.core.js';
 
 /**
  * @import {CoreEvalBuilder, DeployScriptFunction} from '@agoric/deploy-script-support/src/externalTypes.js'
- * @import {IBCConnectionInfo} from '@agoric/orchestration'
+ * @import {IBCConnectionInfo} from '@agoric/network/ibc'
  * @import {Passable} from '@endo/marshal'
  */
 

packages/fast-usdc-deploy/src/update-noble-ica.core.js

@@ -21,7 +21,8 @@ const makeRatio = (numerator, numeratorBrand, denominator = 100n) =>
 /**
  * @import {CopyRecord} from '@endo/pass-style';
  * @import {Brand, Ratio} from '@agoric/ertp';
- * @import {CosmosChainInfo, IBCConnectionInfo} from '@agoric/orchestration';
+ * @import {IBCConnectionInfo} from '@agoric/network/ibc';
+ * @import {CosmosChainInfo} from '@agoric/orchestration';
  * @import {ManifestBundleRef} from '@agoric/deploy-script-support/src/externalTypes.js';
  * @import {BundleID} from '@agoric/swingset-vat';
  * @import {BootstrapManifest} from '@agoric/vats/src/core/lib-boot.js';

packages/fast-usdc-deploy/src/upgrade-evm-dests.core.js

@@ -16,7 +16,8 @@ const { make } = AmountMath;
 /**
  * @import {CopyRecord} from '@endo/pass-style';
  * @import {ManifestBundleRef} from '@agoric/deploy-script-support/src/externalTypes.js';
- * @import {CosmosChainInfo, IBCConnectionInfo} from '@agoric/orchestration';
+ * @import {IBCConnectionInfo} from '@agoric/network/ibc';
+ * @import {CosmosChainInfo} from '@agoric/orchestration';
  * @import {BundleID} from '@agoric/swingset-vat';
  * @import {BootstrapManifest} from '@agoric/vats/src/core/lib-boot.js';
  * @import {FastUSDCCorePowers} from './start-fast-usdc.core.js';

packages/fast-usdc-deploy/test/fu-sim-iter.ts

@@ -20,7 +20,7 @@ import { eventLoopIteration } from '@agoric/internal/src/testing-utils.js';
 import type { CosmosChainAddress } from '@agoric/orchestration';
 import { buildVTransferEvent } from '@agoric/orchestration/tools/ibc-mocks.js';
 import type { OfferSpec } from '@agoric/smart-wallet/src/offers.js';
-import type { IBCChannelID } from '@agoric/vats';
+import type { IBCChannelID } from '@agoric/network/ibc';
 import { makePromiseKit } from '@endo/promise-kit';
 import { configurations } from '../src/utils/deploy-config.js';
 import { type WalletFactoryTestContext } from './walletFactory.js';