feat(model): replace generateDrawCommands with direct submesh handling in ForwardRenderer

Author: AhmedAmrNabil

src/common/model/model.cpp

@@ -11,22 +11,6 @@
 #include "texture/texture-utils.hpp"
 
 namespace our {
-    void Model::generateDrawCommands(std::vector<RenderCommand>& modelCommands,
-                                     std::vector<RenderCommand>& transparentCommands,
-                                     const glm::mat4& modelMatrix) const {
-        for (const auto& submesh : submeshes) {
-            RenderCommand cmd;
-            cmd.localToWorld = modelMatrix * submesh->transform;
-            cmd.center = glm::vec3(cmd.localToWorld * glm::vec4(0, 0, 0, 1));
-            cmd.mesh = submesh->mesh;
-            cmd.material = submesh->material;
-            if (submesh->material->transparent) {
-                transparentCommands.push_back(cmd);
-            } else {
-                modelCommands.push_back(cmd);
-            }
-        }
-    }
 
     void Model::loadFromFile(const std::string& path) {
         std::cout << "Loading model from file: " << path << std::endl;

src/common/model/model.hpp

@@ -34,8 +34,9 @@ namespace our {
         Model(const std::string& name) {
             this->name = name;
         };
-        void generateDrawCommands(std::vector<RenderCommand>& modelCommands,
-                                  std::vector<RenderCommand>& transparentCommands, const glm::mat4& modelMatrix) const;
+        std::vector<MeshRendererComponent*>& getSubmeshes() {
+            return submeshes;
+        }
         Mesh* getCombinedMesh() const {
             return combinedMesh;
         }

src/common/systems/forward-renderer.cpp

@@ -169,8 +169,19 @@ namespace our {
             }
 
             if (auto modelRenderer = entity->getComponent<ModelRendererComponent>(); modelRenderer) {
-                glm::mat4 localToWorld = modelRenderer->getOwner()->getLocalToWorldMatrix();
-                modelRenderer->model->generateDrawCommands(opaqueCommands, transparentCommands, localToWorld);
+                glm::mat4 modelMatrix = modelRenderer->getOwner()->getLocalToWorldMatrix();
+                for (MeshRendererComponent* submesh : modelRenderer->model->getSubmeshes()) {
+                    RenderCommand command;
+                    command.localToWorld = modelMatrix * submesh->transform;
+                    command.center = glm::vec3(command.localToWorld * glm::vec4(0, 0, 0, 1));
+                    command.mesh = submesh->mesh;
+                    command.material = submesh->material;
+                    if (command.material->transparent) {
+                        transparentCommands.push_back(command);
+                    } else {
+                        opaqueCommands.push_back(command);
+                    }
+                }
             }
         }