Skip to content

Commit b7cf5b8

Browse files
committed
chore: apply review suggestions
1 parent 35c908a commit b7cf5b8

5 files changed

Lines changed: 7 additions & 12 deletions

File tree

src/common/audio/audio-buffer.hpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
#pragma once
22

33
#include <AL/al.h>
4-
#include <dr_wav/dr_wav.h>
5-
6-
#include <stdexcept>
7-
#include <string>
84

95
namespace our {
106
class AudioBuffer {

src/common/audio/audio-utils.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
#include <iostream>
99
#include <stdexcept>
10-
#include <string>
1110

1211
our::AudioBuffer* our::audio_utils::loadWAV(const std::string& filename) {
1312
unsigned int channels = 0;

src/common/audio/audio-utils.hpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
#pragma once
22

3-
#include "audio-buffer.hpp"
3+
#include <string>
44

5+
#include "audio-buffer.hpp"
56
namespace our::audio_utils {
67
AudioBuffer* loadWAV(const std::string& filename);
78

src/common/components/audio-source.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ namespace our {
1414
float gain = 1.0f; // Volume multiplier
1515
float pitch = 1.0f; // Speed multiplier
1616
bool loop = false; // Whether to keep looping
17-
bool spatial = false; // 3D sptatialization
17+
bool spatial = false; // 3D spatialization
1818
bool playOnStart = false; // whether the sound should start playing as soon as the component is created
1919
float refDistance = 5.0f; // full volume within this distance
20-
float maxDistance = 100.0f; // Attentuation limit
20+
float maxDistance = 100.0f; // Attenuation limit
2121

2222
// Runtime data
2323
ALuint alSource = 0; // The AL source assigned to this component (0 = unassigned)

src/states/menu-state.hpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,16 @@
22

33
#include <application.hpp>
44
#include <array>
5+
#include <asset-loader.hpp>
6+
#include <audio/audio-buffer.hpp>
7+
#include <audio/audio-utils.hpp>
58
#include <functional>
69
#include <material/material.hpp>
710
#include <mesh/mesh.hpp>
811
#include <shader/shader.hpp>
912
#include <texture/texture-utils.hpp>
1013
#include <texture/texture2d.hpp>
1114

12-
#include "../common/asset-loader.hpp"
13-
#include "../common/audio/audio-buffer.hpp"
14-
#include "../common/audio/audio-utils.hpp"
15-
1615
// This struct is used to store the location and size of a button and the code it should execute when clicked
1716
struct Button {
1817
// The position (of the top-left corner) of the button and its size in pixels

0 commit comments

Comments
 (0)