chore: Pass locals instead of ivars

This fixes a Herb linter issue.

Signed-off-by: Thomas von Deyen <thomas@vondeyen.com>

Author: tvdeyen

app/views/alchemy/admin/users/_fields.html.erb

@@ -1,7 +1,7 @@
 <%= f.input :firstname, input_html: {autocomplete: "given-name"} %>
 <%= f.input :lastname, input_html: {autocomplete: "family-name"} %>
-<%= f.input :login, autofocus: true, required: @user.login_required?, input_html: {autocomplete: "username"} %>
-<%= f.input :email, required: @user.email_required?, input_html: {autocomplete: "email"} %>
+<%= f.input :login, autofocus: true, required: f.object.login_required?, input_html: {autocomplete: "username"} %>
+<%= f.input :email, required: f.object.email_required?, input_html: {autocomplete: "email"} %>
 <% if Alchemy::I18n.available_locales.many? %>
   <div class="input select">
     <%= f.label(:language) %>
@@ -16,9 +16,9 @@
     is: "alchemy-select",
     data: {allow_clear: true}
   } %>
-<% if can_update_role? %>
+<% if local_assigns[:user_roles] && can_update_role? %>
   <%= f.input :alchemy_roles,
-    collection: @user_roles,
+    collection: user_roles,
     input_html: {
       multiple: true,
       is: 'alchemy-select',
@@ -32,7 +32,7 @@
     <%= f.label :tag_list %>
     <%= render 'alchemy/admin/partials/autocomplete_tag_list',
       f: f,
-      object: @user %>
+      object: f.object %>
   </div>
 <% end %>
 <%= f.input :send_credentials, as: 'boolean' %>

app/views/alchemy/admin/users/edit.html.erb

@@ -1,6 +1,6 @@
 <% if request.xhr? || turbo_frame_request? %>
   <%= alchemy_form_for [:admin, @user] do |f| %>
-    <%= render 'fields', f: f %>
+    <%= render "fields", f: f, user_roles: @user_roles %>
   <% end %>
 <% else %>
   <%= content_for :toolbar do %>
@@ -16,7 +16,7 @@
       <%= Alchemy.t(:edit_user) %>
     </alchemy-message>
     <%= alchemy_form_for [:admin, @user] do |f| %>
-      <%= render 'fields', f: f %>
+      <%= render "fields", f: f, user_roles: @user_roles %>
     <% end %>
   </div>
 <% end %>

app/views/alchemy/admin/users/new.html.erb

@@ -1,3 +1,3 @@
 <%= alchemy_form_for [:admin, @user] do |f| %>
-  <%= render 'fields', f: f %>
+  <%= render 'fields', f: f, user_roles: @user_roles %>
 <% end %>