Skip to content

Commit 72ce814

Browse files
authored
fix: Use Alchemy's page etag generator (#161)
The `Alchemy::Page:EtagGenerator` takes time based element publishing into account.
2 parents e075896 + a2e6585 commit 72ce814

5 files changed

Lines changed: 6 additions & 7 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
fail-fast: false
1414
matrix:
1515
alchemy_branch:
16-
- 8.1-stable
16+
- main
1717
ruby:
1818
- "3.2"
1919
- "3.3"

Gemfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ gemspec
1717
# gem 'byebug', group: [:development, :test]
1818
gem "sqlite3", "~> 2.2"
1919

20-
alchemy_branch = ENV.fetch("ALCHEMY_BRANCH", "8.1-stable")
20+
alchemy_branch = ENV.fetch("ALCHEMY_BRANCH", "main")
2121
gem "alchemy_cms", github: "AlchemyCMS/alchemy_cms", branch: alchemy_branch
22-
gem "alchemy-devise", github: "AlchemyCMS/alchemy-devise", branch: "main"
22+
gem "alchemy-devise", github: "AlchemyCMS/alchemy-devise", branch: alchemy_branch
2323

2424
gem "rubocop", require: false
2525
gem "standard", "~> 1.25", require: false

alchemy-json_api.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
1818

1919
spec.files = Dir["{app,config,db,lib}/**/*", "LICENSE", "Rakefile", "README.md"]
2020

21-
spec.add_dependency "alchemy_cms", [">= 8.1.0.a", "< 9"]
21+
spec.add_dependency "alchemy_cms", [">= 8.2.0.a", "< 9"]
2222
spec.add_dependency "jsonapi.rb", [">= 1.6.0", "< 2.2"]
2323

2424
spec.add_development_dependency "factory_bot"

app/controllers/alchemy/json_api/pages_controller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ def etag(pages)
125125
end
126126

127127
def page_cache_key(page)
128-
page.cache_key_with_version
128+
Alchemy::Page::EtagGenerator.new(page).call
129129
end
130130

131131
def base_page_scope

spec/serializers/alchemy/json_api/element_serializer_spec.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,10 @@
88
:alchemy_element,
99
autogenerate_ingredients: true,
1010
tag_list: "Tag1,Tag2",
11-
nested_elements: [nested_element],
1211
parent_element: parent_element
1312
)
1413
end
15-
let(:nested_element) { FactoryBot.create(:alchemy_element) }
14+
let!(:nested_element) { FactoryBot.create(:alchemy_element, parent_element: element) }
1615
let(:parent_element) { FactoryBot.create(:alchemy_element) }
1716
let(:options) { {} }
1817

0 commit comments

Comments
 (0)