Skip to content

Commit 8f9817f

Browse files
authored
Feat 347 required email (#408)
* feat: makes user_email required in SubmitUploadJobsV2 model * updates test_server tests * linters * docs: updates examples and user guide * use user@example for all examples
1 parent d09d46d commit 8f9817f

13 files changed

Lines changed: 85 additions & 21 deletions

docs/examples/aind_data_schema_v2.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,11 @@
140140
},
141141
)
142142

143+
# Please provide your email to receive notifications about the job status.
144+
user_email = "user@example.com"
145+
143146
submit_request_v2 = SubmitJobRequestV2(
147+
user_email=user_email,
144148
upload_jobs=[upload_job_configs_v2],
145149
)
146150

docs/examples/basic_upload.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
# Please provide your email to receive notifications about the job status.
6060
# Notification types include: ["begin", "end", "fail", "retry", "all"]
6161
# or provide an empty list to opt out.
62-
user_email = "your_email_here"
62+
user_email = "user@example.com"
6363
email_notification_types = ["fail"]
6464

6565
submit_request_v2 = SubmitJobRequestV2(

docs/examples/behavior_videos_compression.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,11 @@
103103
},
104104
)
105105

106+
# Please provide your email to receive notifications about the job status.
107+
user_email = "user@example.com"
108+
106109
submit_request_v2 = SubmitJobRequestV2(
110+
user_email=user_email,
107111
upload_jobs=[upload_job_configs_v2],
108112
)
109113

docs/examples/custom_codeocean_pipeline_settings.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,11 @@
9292
},
9393
)
9494

95+
# Please provide your email to receive notifications about the job status.
96+
user_email = "user@example.com"
97+
9598
submit_request_v2 = SubmitJobRequestV2(
99+
user_email=user_email,
96100
upload_jobs=[upload_job_configs_v2],
97101
)
98102

docs/examples/custom_metadata_mapper_settings.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,11 @@
9595
},
9696
)
9797

98+
# Please provide your email to receive notifications about the job status.
99+
user_email = "user@example.com"
100+
98101
submit_request_v2 = SubmitJobRequestV2(
102+
user_email=user_email,
99103
upload_jobs=[upload_job_configs_v2],
100104
)
101105

docs/examples/hcr_example.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,11 @@
6161

6262
upload_jobs = [upload_job_configs_v2]
6363

64+
# Please provide your email to receive notifications about the job status.
65+
user_email = "user@example.com"
66+
6467
submit_request = SubmitJobRequestV2(
68+
user_email=user_email,
6569
upload_jobs=upload_jobs,
6670
)
6771

docs/examples/remove_source_folders.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,11 @@
6060
},
6161
)
6262

63+
# Please provide your email to receive notifications about the job status.
64+
user_email = "user@example.com"
65+
6366
submit_request_v2 = SubmitJobRequestV2(
67+
user_email=user_email,
6468
upload_jobs=[upload_job_configs_v2],
6569
)
6670

docs/examples/skip_s3_check.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,11 @@
5757
},
5858
)
5959

60+
# Please provide your email to receive notifications about the job status.
61+
user_email = "user@example.com"
62+
6063
submit_request_v2 = SubmitJobRequestV2(
64+
user_email=user_email,
6165
upload_jobs=[upload_job_configs_v2],
6266
)
6367

docs/examples/upload_with_custom_slurm_settings.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,11 @@
6666
},
6767
)
6868

69+
# Please provide your email to receive notifications about the job status.
70+
user_email = "user@example.com"
71+
6972
submit_request_v2 = SubmitJobRequestV2(
73+
user_email=user_email,
7074
upload_jobs=[upload_job_configs_v2],
7175
)
7276

docs/source/UserGuide.rst

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,8 @@ portal can be accessed at
114114

115115
- Required fields
116116

117+
- user_email: Your email address to receive notifications about the job
118+
status (e.g., start, completion, failure)
117119
- job_type: We store pre-compiled default configurations in AWS Parameter
118120
Store (e.g. modality transformation settings, Code Ocean pipeline
119121
settings). This field determines which preset to use when
@@ -172,7 +174,12 @@ endpoint:
172174

173175
You may pip install aind-data-transfer-service for access to the Task model;
174176
however, this isn't strictly necessary. You can form the post request as a
175-
dictionary. The service will perform validation. We strongly recommend using
177+
dictionary. The service will perform validation.
178+
179+
**Note:** The ``user_email`` field is required in the SubmitJobRequestV2 model
180+
to receive notifications about job status.
181+
182+
We strongly recommend using
176183
customized job_types to simplify the requests. For more detailed examples please
177184
check the scripts in `examples <https://github.com/AllenNeuralDynamics/aind-data-transfer-service/tree/main/docs/examples>`__.
178185

0 commit comments

Comments
 (0)