Skip to content

Job Params page is broken due to breaking change in aind-data-schema-models #356

Description

@helen-m-lin

Describe the bug
The job params page is broken due to an unhandled validator for modality in job parameter names.

There was a breaking change in aind-data-schema-models which renamed slap to slap2: AllenNeuralDynamics/aind-data-schema-models#260. Because of this, the existing /aind/dev/airflow/variables/job_types/v2/default/tasks/modality_transformation_settings/slap parameter is failing validation.

To Reproduce
Steps to reproduce the behavior:

  1. Go to http://aind-data-transfer-service-dev/job_params
  2. Observe that the page cannot load.
  3. Go to the data transfer grafana dashboard (dev): https://grafana-sipe.corp.alleninstitute.org/d/d8816444-071e-4caf-bb68-76e7ca34f19e/aind-data-transfer-service-logs?orgId=1&from=now-5m&to=now&timezone=browser&var-environment=aind-dev
  4. See error: Value error, Invalid modality: modality must be one of ['BARseq', 'behavior', 'behavior-videos', 'brightfield', 'confocal', 'EMG', 'EM', 'ecephys', 'fib', 'fMOST', 'icephys', 'ISI', 'MRI', 'MAPseq', 'merfish', 'pophys', 'slap2', 'SPIM', 'STPT', 'scRNAseq'] [type=value_error, input_value='slap', input_type=str]

Expected behavior
The job params page should not crash due to invalid modalities. Instead, either remove the validator when reading existing parameters, or log a warning and continue.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions