fix: preloaded anlyzer

Author: alejoe91

src/aind_ephys_portal/panel/ephys_gui.py

@@ -206,16 +206,22 @@ def __init__(
         # Try to derive a *dataset-specific* RAM estimate by pre-loading the
         # analyzer with no extensions and reading its unit count. This costs
         # one S3 round-trip (~1-3s) but lets us accurately predict heavy
-        # sessions instead of relying on a fixed percent. The pre-loaded
-        # analyzer is stashed on self.analyzer so _initialize_analyzer()
-        # below can skip its own si.load() call.
+        # sessions instead of relying on a fixed percent. We stash the
+        # pre-loaded analyzer in a SEPARATE attribute (NOT self.analyzer) —
+        # _create_main_window() below checks `self.analyzer is not None` to
+        # decide whether to render the real GUI vs the help text, and an
+        # analyzer without extensions would cause run_mainwindow to fail
+        # silently, leaving the loading banner stuck forever.
+        # _initialize_analyzer() transfers _preloaded_analyzer → self.analyzer
+        # later, after the layout is set up correctly.
+        self._preloaded_analyzer = None
         estimate_pct = None
         estimate_units = None
         if self.analyzer_path and self.analyzer_path.endswith((".zarr", ".zarr/")):
             try:
-                self.analyzer = si.load(self.analyzer_path, load_extensions=False)
-                estimate_units = len(self.analyzer.unit_ids)
-                est_bytes = estimate_session_ram_bytes(self.analyzer, fast_mode=self.fast_mode)
+                self._preloaded_analyzer = si.load(self.analyzer_path, load_extensions=False)
+                estimate_units = len(self._preloaded_analyzer.unit_ids)
+                est_bytes = estimate_session_ram_bytes(self._preloaded_analyzer, fast_mode=self.fast_mode)
                 estimate_pct = est_bytes / total_ram_bytes * 100
                 print(
                     f"Dynamic per-session RAM estimate: "
@@ -226,7 +232,7 @@ def __init__(
                 # Pre-load failed (S3 transient, bad path, etc.) — fall back
                 # to the static estimate. Better to occasionally reject a
                 # session we could have admitted than to OOM.
-                self.analyzer = None
+                self._preloaded_analyzer = None
                 print(f"Could not pre-load analyzer for size estimate: {e}. Using static fallback.")
 
         # NB: this is the entry point for THIS session, so it isn't counted in
@@ -239,7 +245,7 @@ def __init__(
             estimate_pct=estimate_pct,
         ):
             # Drop the pre-loaded analyzer so its memory is released
-            self.analyzer = None
+            self._preloaded_analyzer = None
             # Remove this session from the count — it is being rejected
             doc = pn.state.curdoc
             route = getattr(doc, "_log_route", None)
@@ -438,13 +444,19 @@ def _initialize_analyzer(self):
         if not self.analyzer_path.endswith((".zarr", ".zarr/")):
             raise ValueError("Only Zarr files are supported for now.")
         # The admission step in __init__ may have already pre-loaded the
-        # analyzer (load_extensions=False) to compute a dynamic RAM
-        # estimate. Reuse it if present to avoid a second S3 round-trip.
-        if self.analyzer is None:
+        # analyzer (load_extensions=False) into self._preloaded_analyzer to
+        # compute the dynamic RAM estimate. Transfer it now to self.analyzer
+        # (the canonical attribute the rest of the code reads), and clear
+        # the temporary handle. If pre-load wasn't done or failed, fall
+        # back to a fresh si.load() here.
+        preloaded = getattr(self, "_preloaded_analyzer", None)
+        if preloaded is not None:
+            print(f"Reusing pre-loaded analyzer (skipped re-fetching from S3).")
+            self.analyzer = preloaded
+            self._preloaded_analyzer = None
+        else:
             print(f"Loading analyzer...")
             self.analyzer = si.load(self.analyzer_path, load_extensions=False)
-        else:
-            print(f"Reusing pre-loaded analyzer (skipped re-fetching from S3).")
         print(f"Analyzer loaded: {self.analyzer}")
 
     def _set_processed_recording(self):
@@ -526,6 +538,10 @@ def cleanup(self):
         self.curation_listener = None
         self.fullscreen_listener = None
         self.submit_trigger = None
+        # Pre-loaded analyzer should already have been transferred to
+        # self.analyzer by _initialize_analyzer, but null it explicitly
+        # in case the session was rejected or failed before _initialize.
+        self._preloaded_analyzer = None
 
         # 2) Release GUI controller and all its data
         sigui_win = getattr(self, "sigui_win", None)