Error in test Load DialogueGraph

[tomocrea]

I have tried following the instructions in contributing.md but when running all tests I consistently get an error running the test Load DialogueGraph, the error message is:

java.lang.AssertionError: 
Expected: is <3>
     but: was <0>
Expected :is <3>
Actual   :<0>
<Click to see difference>


	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8)
	at com.almasb.fxgl.app.AssetLoaderServiceTest.Load DialogueGraph(AssetLoaderServiceTest.kt:224)

I have found that the test tries to load simple.json which finds a file with the path 'FXGL/fxgl-samples/target/classes/assets/dialogues/simple.json', the subsequent test Load DialogueGraph from URL specifies the file as being under fxglassets which gets the json file under 'FXGL/fxgl/target/test-classes/fxglassets/dialogues/simple.json' which works perfectly. If I rename the simple.json file under fxgl-samples that fixes the problem as the test finds the one under the fxgl module. I am not sure if the assetLoader is supposed to find the file under fxgl-samples or fxgl, if it is the former I don't know why the assertion fails as the json does have 3 nodes and if it is the latter I don't know why the assetLoader prioritises searching under the fxgl-samples module. I was hoping someone might have a suggestion or solution, thank you
Using IntelliJ IDEA 2024.3.2.2 (Community Edition) with jdk 23, have followed development instructions up to running ALL FXGL TESTS

[AlmasB]

Hi, thanks for this. You are right, this is a problem. Given you already have a fix, feel free to submit a PR for it.

When the fxgl-samples json file is renamed, we also need to rename it in whatever sample is accessing that json.