Fix a few minor bugs in backend dynamics (#110)

* Fix logic error

It's the target context, not the context that can't be GroupComponent
for a ["component"] lookups

* OptionId => OptionsId

This error causes errors because of the parse time validation.

Co-authored-by: Ivar <ivar.nesje@finanstilsynet.no>

Author: ivarne

src/Altinn.App.Core/Internal/Expressions/ExpressionEvaluator.cs

@@ -82,13 +82,13 @@ public static bool EvaluateBooleanExpression(LayoutEvaluatorState state, Compone
             throw new ArgumentException("Cannot lookup component null");
         }
 
-        if (context.Component is GroupComponent)
+        var targetContext = state.GetComponentContext(context.Component.PageId, componentId, context.RowIndices);
+
+        if (targetContext.Component is GroupComponent)
         {
             throw new NotImplementedException("Component lookup for components in groups not implemented");
         }
 
-        var targetContext = state.GetComponentContext(context.Component.PageId, componentId, context.RowIndices);
-
         if (!targetContext.Component.DataModelBindings.TryGetValue("simpleBinding", out var binding))
         {
             throw new ArgumentException("component lookup requires the target component to have a simpleBinding");

src/Altinn.App.Core/Models/Layout/PageComponentComverter.cs

@@ -238,7 +238,7 @@ private BaseComponent ReadComponent(ref Utf8JsonReader reader, JsonSerializerOpt
                     pageRef = reader.GetString();
                     break;
                 // option
-                case "optionid":
+                case "optionsid":
                     optionId = reader.GetString();
                     break;
                 case "options":

test/Altinn.App.Core.Tests/LayoutExpressions/CommonTests/shared-tests/functions/component/hide-group-component.json

@@ -0,0 +1,111 @@
+{
+  "name": "Lookup for hidden component inside repeating group",
+  "expression": ["component", "single-top-component"],
+  "expects": "singleTopValue",
+  "layouts": {
+    "Page1": {
+      "$schema": "https://altinncdn.no/schemas/json/layout/layout.schema.v1.json",
+      "data": {
+        "layout": [
+          {
+            "id": "single-top-component",
+            "type": "Input",
+            "dataModelBindings": {
+              "simpleBinding": "Single.Top"
+            }
+          },
+          {
+            "id": "bedrifter",
+            "type": "Group",
+            "maxCount": 99,
+            "dataModelBindings": {
+              "group": "Bedrifter"
+            },
+            "children": ["bedriftsNavn", "ansatte"]
+          },
+          {
+            "id": "bedriftsNavn",
+            "type": "Input",
+            "dataModelBindings": {
+              "simpleBinding": "Bedrifter.Navn"
+            }
+          },
+          {
+            "id": "ansatte",
+            "type": "Group",
+            "maxCount": 99,
+            "dataModelBindings": {
+              "group": "Bedrifter.Ansatte"
+            },
+            "children": ["navn", "alder", "myndig"]
+          },
+          {
+            "id": "navn",
+            "type": "Input",
+            "dataModelBindings": {
+              "simpleBinding": "Bedrifter.Ansatte.Navn"
+            }
+          },
+          {
+            "id": "alder",
+            "type": "Input",
+            "dataModelBindings": {
+              "simpleBinding": "Bedrifter.Ansatte.Alder"
+            },
+            "hidden": [
+              "if",
+              ["dataModel", "Bedrifter.Ansatte.AlderSkjult"],
+              true
+            ]
+          },
+          {
+            "id": "myndig",
+            "type": "Paragraph",
+            "textResourceBindings": {
+              "title": "Hurra, den ansatte er myndig!"
+            }
+          }
+        ]
+      }
+    }
+  },
+  "dataModel": {
+    "Single": {
+      "Top": "singleTopValue"
+    },
+    "Bedrifter": [
+      {
+        "Navn": "Hell og lykke AS",
+        "Ansatte": [
+          {
+            "Navn": "Kaare",
+            "Alder": 24
+          },
+          {
+            "Navn": "Per",
+            "Alder": 24
+          }
+        ]
+      },
+      {
+        "Navn": "Nedtur og motgang AS",
+        "Ansatte": [
+          {
+            "Navn": "Arne",
+            "Alder": 24,
+            "AlderSkjult": true
+          },
+          {
+            "Navn": "Vidar",
+            "Alder": 14
+          }
+        ]
+      }
+    ]
+  },
+  "context": {
+    "component": "ansatte",
+    "currentLayout": "Page1",
+    "rowIndices": [1,0]
+  }
+}