Remove most remaining analyzer and nullable warnings

Author: rhuijben

src/RepoDb.PostgreSql.BulkOperations/Compiler.cs

@@ -159,7 +159,7 @@ private static Action<NpgsqlBinaryImporter, TEntity> GetFunc(string tableName,
 
             // Check
             Action<NpgsqlBinaryImporter, TEntity> func;
-            if (expressions.Any())
+            if (expressions.Count > 0)
             {
                 func = Expression
                     .Lambda<Action<NpgsqlBinaryImporter, TEntity>>(Expression.Block(expressions), importerParameterExpression, entityParameterExpression)
@@ -328,7 +328,7 @@ private static Func<NpgsqlBinaryImporter, TEntity, CancellationToken, Task> GetF
 
             // Check
             Func<NpgsqlBinaryImporter, TEntity, CancellationToken, Task> func;
-            if (expressions.Any())
+            if (expressions.Count > 0)
             {
                 func = Expression
                     .Lambda<Func<NpgsqlBinaryImporter, TEntity, CancellationToken, Task>>(Expression.Block(expressions),
@@ -490,7 +490,7 @@ private static Expression GetEntityPropertyExpressionForEnum(Expression property
     /// <param name="propertyExpression"></param>
     /// <returns></returns>
     /// <exception cref="InvalidOperationException"></exception>
-    private static Expression ConvertEnumExpressionToString(Expression propertyExpression) =>
+    private static MethodCallExpression ConvertEnumExpressionToString(Expression propertyExpression) =>
         Expression.Call(GetConvertToTypeMethod(typeof(string)),
             Expression.Convert(propertyExpression, typeof(object)));
 

src/RepoDb/BaseRepository.cs

@@ -554,7 +554,7 @@ public Task<int> ExecuteNonQueryAsync(string commandText,
     /// <param name="transaction">The transaction to be used.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> object to be used during the asynchronous operation.</param>
     /// <returns>A first occurrence value (first column of first row) of the execution.</returns>
-    public Task<TResult> ExecuteScalarAsync<TResult>(string commandText,
+    public Task<TResult?> ExecuteScalarAsync<TResult>(string commandText,
         object? param = null,
         CommandType commandType = default,
         string? cacheKey = null,

src/RepoDb/Cachers/MemoryCache.cs

@@ -10,7 +10,6 @@ namespace RepoDb;
 /// </summary>
 #pragma warning disable CA1010 // Generic interface should also be implemented
 public class MemoryCache : ICache
-#pragma warning restore CA1010 // Generic interface should also be implemented
 {
     private readonly ConcurrentDictionary<string, IExpirable> _cache = new();
 

src/RepoDb/Contexts/Cachers/MergeAllExecutionContextCache.cs

@@ -30,7 +30,7 @@ internal static void Add(string key,
     /// </summary>
     /// <param name="key"></param>
     /// <returns></returns>
-    internal static MergeAllExecutionContext Get(string key)
+    internal static MergeAllExecutionContext? Get(string key)
     {
         if (cache.TryGetValue(key, out var result))
         {

src/RepoDb/Contexts/Providers/InsertExecutionContextProvider.cs

@@ -201,7 +201,7 @@ private static InsertExecutionContext CreateInternal(Type entityType,
             ParametersSetterFunc = FunctionCache
                 .GetDataEntityDbParameterSetterCompiledFunction(entityType,
                     string.Concat(entityType.FullName, ".", tableName, ".Insert"),
-                    inputFields?.AsList(),
+                    inputFields,
                     null,
                     dbSetting,
                     dbHelper),

src/RepoDb/Contexts/Providers/MergeExecutionContextProvider.cs

@@ -216,7 +216,7 @@ private static MergeExecutionContext CreateInternal(Type entityType,
             ParametersSetterFunc = FunctionCache
                 .GetDataEntityDbParameterSetterCompiledFunction(entityType,
                     string.Concat(entityType.FullName, ".", tableName, ".Merge"),
-                    inputFields?.AsList(),
+                    inputFields,
                     null,
                     dbSetting,
                     dbHelper),

src/RepoDb/Contexts/Providers/UpdateExecutionContextProvider.cs

@@ -200,7 +200,7 @@ private static UpdateExecutionContext CreateInternal(Type entityType,
             InputFields = inputFields,
             ParametersSetterFunc = FunctionCache.GetDataEntityDbParameterSetterCompiledFunction(entityType,
                 string.Concat(entityType.FullName, ".", tableName, ".Update"),
-                inputFields?.AsList(),
+                inputFields,
                 null,
                 dbSetting,
                 dbHelper)

src/RepoDb/DataEntityDataReader.cs

@@ -10,6 +10,7 @@ namespace RepoDb;
 /// A data reader object that is used to manipulate the enumerable list of data entity objects.
 /// </summary>
 /// <typeparam name="TEntity">The type of the data entity</typeparam>
+#pragma warning disable CA1010 // Generic interface should also be implemented
 public class DataEntityDataReader<TEntity> : DbDataReader
     where TEntity : class
 {
@@ -680,7 +681,7 @@ private IEnumerable<ClassProperty> GetClassProperties()
     {
         if (isDictionaryStringObject)
         {
-            return Enumerable.Empty<ClassProperty>();
+            return [];
         }
         return PropertyCache.Get(EntityType);
     }

src/RepoDb/DbRepository.cs

@@ -820,7 +820,7 @@ public async Task<int> ExecuteNonQueryAsync(string commandText,
     /// <param name="transaction">The transaction to be used.</param>
     /// <param name="cancellationToken">The <see cref="CancellationToken"/> object to be used during the asynchronous operation.</param>
     /// <returns>A first occurrence value (first column of first row) of the execution.</returns>
-    public async Task<TResult> ExecuteScalarAsync<TResult>(string commandText,
+    public async Task<TResult?> ExecuteScalarAsync<TResult>(string commandText,
         object? param = null,
         CommandType commandType = default,
         string? cacheKey = null,

src/RepoDb/Extensions/DataEntityExtension.cs

@@ -167,11 +167,8 @@ internal static PropertyInfo GetPropertyOrThrow<TEntity>(string propertyName)
     private static PropertyInfo GetPropertyOrThrow(Type type,
         string propertyName)
     {
-        var property = TypeExtension.GetProperty(type, propertyName);
-        if (property == null)
-        {
-            throw new PropertyNotFoundException(nameof(propertyName), $"The property '{propertyName}' is not found from type '{type.FullName}'.");
-        }
+        var property = TypeExtension.GetProperty(type, propertyName) ?? throw new PropertyNotFoundException(nameof(propertyName), $"The property '{propertyName}' is not found from type '{type.FullName}'.");
+
         return property;
     }
 
@@ -181,7 +178,7 @@ private static PropertyInfo GetPropertyOrThrow(Type type,
     /// <typeparam name="TEntity"></typeparam>
     /// <param name="propertyName"></param>
     /// <returns></returns>
-    internal static ClassProperty GetClassPropertyOrThrow<TEntity>(string propertyName)
+    internal static ClassProperty GetClassPropertyOrThrow<TEntity>(string? propertyName)
         where TEntity : class =>
         GetClassPropertyOrThrow(typeof(TEntity), propertyName);
 
@@ -192,7 +189,7 @@ internal static ClassProperty GetClassPropertyOrThrow<TEntity>(string propertyNa
     /// <param name="propertyName"></param>
     /// <returns></returns>
     private static ClassProperty GetClassPropertyOrThrow(Type type,
-        string propertyName)
+        string? propertyName)
     {
         return PropertyCache
             .Get(type)?