Skip to content

Commit 9638465

Browse files
committed
Remove ForceAutomaticConversions flag. The one use is already default
1 parent 1f7af60 commit 9638465

6 files changed

Lines changed: 2 additions & 14 deletions

File tree

src/RepoDb.MySql/DbHelpers/MySqlDbHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ LEFT JOIN INFORMATION_SCHEMA.KEY_COLUMN_USAGE kcu
8383
"mediumblob",
8484
"tinyblob",
8585
"varbinary"
86-
], StringComparer.OrdinalIgnoreCase));
86+
], StringComparer.OrdinalIgnoreCase);
8787

8888
/// <summary>
8989
///

src/RepoDb.Oracle/DbSettings/OracleDbSetting.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ public OracleDbSetting() : base()
1515
IsPreparable = true;
1616
IsUseUpsert = false;
1717
ParameterPrefix = ":";
18-
ForceAutomaticConversions = false; // Yes — Oracle returns untyped `NUMBER`, `DATE`, etc., requiring conversion
1918
MaxParameterCount = 32766;
2019
MaxQueriesInBatchCount = 1000;
2120
GenerateFinalSemiColon = false;

src/RepoDb.SQLite.System/DbSettings/SQLiteDbSetting.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ public SQLiteDbSetting(bool isExecuteReaderDisposable)
2828
IsUseUpsert = true; // Different than Microsoft.Data.SQLite
2929
OpeningQuote = "[";
3030
ParameterPrefix = "@";
31-
ForceAutomaticConversions = true;
3231
MaxQueriesInBatchCount = 10; // No need to optimize using higher value as there is no network latency in SQLite
3332
}
3433
}

src/RepoDb.Sqlite.Microsoft/DbSettings/SqLiteDbSetting.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ public SqLiteDbSetting(bool isExecuteReaderDisposable)
2828
IsUseUpsert = false; // Different than System.Data.SQLite
2929
OpeningQuote = "[";
3030
ParameterPrefix = "@";
31-
ForceAutomaticConversions = true;
3231
MaxQueriesInBatchCount = 10; // No need to optimize using higher value as there is no network latency in SQLite
3332
}
3433
}

src/RepoDb/DbSettings/BaseDbSetting.cs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,6 @@ public BaseDbSetting()
7171
/// <inheritdoc />
7272
public string ParameterPrefix { get; protected init; }
7373

74-
/// <inheritdoc />
75-
public bool ForceAutomaticConversions { get; protected init; }
76-
7774
/// <inheritdoc />
7875
public int MaxParameterCount { get; protected init; } = 2100 - 2; // SqlServer supports 2100 parameters, but Microsoft.Data.SqlServer and System.Data.SqlClient reserve 2 for internal use
7976

@@ -127,8 +124,7 @@ public override int GetHashCode()
127124
IsExecuteReaderDisposable,
128125
IsMultiStatementExecutable,
129126
IsPreparable,
130-
IsUseUpsert,
131-
ForceAutomaticConversions);
127+
IsUseUpsert);
132128

133129
hashCode = HashCode.Combine(hashCode,
134130
MaxParameterCount,

src/RepoDb/Interfaces/IDbSetting.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,6 @@ public interface IDbSetting
6262
/// </summary>
6363
string ParameterPrefix { get; }
6464

65-
/// <summary>
66-
/// This database provider required automatic conversions, because it uses some form of duck-typing
67-
/// </summary>
68-
bool ForceAutomaticConversions { get; }
69-
7065
/// <summary>
7166
/// This database provider supports a maximum of this number of parameters
7267
/// </summary>

0 commit comments

Comments
 (0)