Modernize code. Mostly analyzer fixes

Author: rhuijben

.editorconfig

@@ -19,6 +19,11 @@ dotnet_sort_system_directives_first = true
 
 csharp_style_namespace_declarations = file_scoped:suggestion
 
-[*.cs]
+# IDE0130: Namespace does not match folder structure
+dotnet_style_namespace_match_folder = false
+
 # CS1574: XML comment has cref attribute that could not be resolved
 dotnet_diagnostic.CS1574.severity = none
+
+# IDE0057: Use range operator
+csharp_style_prefer_range_operator = false

src/RepoDb.Core.UnitTests/Cachers/ClassMappedNameCacheTest.cs

@@ -84,11 +84,11 @@ public void TestWithMapAttributeAndWithClassMapperMapping()
         Assert.AreEqual(expected, actual);
     }
 
-    [TestMethod, ExpectedException(typeof(ArgumentNullException))]
+    [TestMethod]
     public void ThrowExceptionOnClassMappingCacheIfTheTypeIsNull()
     {
         // Setup
-        ClassMappedNameCache.Get(null);
+        Assert.ThrowsExactly<ArgumentNullException>(() => ClassMappedNameCache.Get(null));
     }
 
     #endregion

src/RepoDb.Core.UnitTests/Cachers/MemoryCacheTest.cs

@@ -158,35 +158,35 @@ public void TestMemoryCacheManualExpirationDateViaCacheItem()
         Assert.AreEqual(expirationInMinutes, (actual.Expiration - actual.CreatedDate).TotalMinutes);
     }
 
-    [TestMethod, ExpectedException(typeof(MappingExistsException))]
+    [TestMethod]
     public void ThrowExceptionOnAddingNewItemAtMemoryCacheWithTheSameKey()
     {
         // Prepare
         var cache = new MemoryCache();
         cache.Add("Key", new object(), throwException: true);
 
         // Act/Assert
-        cache.Add("Key", new object(), throwException: true);
+        Assert.ThrowsExactly<MappingExistsException>(() => cache.Add("Key", new object(), throwException: true));
     }
 
-    [TestMethod, ExpectedException(typeof(ArgumentOutOfRangeException))]
+    [TestMethod]
     public void ThrowExceptionAtMemoryCacheOnAddingACacheWithNegativeExpiration()
     {
         // Prepare
-        var cache = new MemoryCache
+        Assert.ThrowsExactly<ArgumentOutOfRangeException>(() => new MemoryCache
         {
             // Act/Assert
             { "Key", "Value", -1 }
-        };
+        });
     }
 
-    [TestMethod, ExpectedException(typeof(ItemNotFoundException))]
+    [TestMethod]
     public void ThrowExceptionAtMemoryCacheOnRemovingAKeyThatIsNotPresent()
     {
         // Prepare
         var cache = new MemoryCache();
 
         // Act/Assert
-        cache.Remove("Key", true);
+        Assert.ThrowsExactly<ItemNotFoundException>(() => cache.Remove("Key", true));
     }
 }

src/RepoDb.Core.UnitTests/Cachers/PropertyMappedNameCacheTest.cs

@@ -54,11 +54,11 @@ public void TestWithMapAttribute()
         Assert.AreEqual(expected, property.GetMappedName());
     }
 
-    [TestMethod, ExpectedException(typeof(ArgumentNullException))]
+    [TestMethod]
     public void ThrowExceptionOnPropertyMappingCacheIfThePropertyIsNull()
     {
         // Setup
-        PropertyMappedNameCache.Get<PropertyMappedNameCacheTestClass>((Field)null);
+        Assert.ThrowsExactly<ArgumentNullException>(() => PropertyMappedNameCache.Get<PropertyMappedNameCacheTestClass>((Field)null));
     }
 
     #endregion

src/RepoDb.Core.UnitTests/Cachers/PropertyValueAttributeCacheTest.cs

@@ -51,8 +51,7 @@ private class PropertyValueAttributeClass
     #region Helpers
 
     private IEnumerable<PropertyValueAttribute> GetPropertyValueAttributes() =>
-        new PropertyValueAttribute[]
-        {
+        [
             // Different Values
             new NameAttribute("ColumnString"),
             new DbTypeAttribute(DbType.StringFixedLength),
@@ -62,7 +61,7 @@ private IEnumerable<PropertyValueAttribute> GetPropertyValueAttributes() =>
             new IsNullableAttribute(true),
             new PrecisionAttribute(100),
             new ScaleAttribute(2)
-        };
+        ];
 
     #endregion
 

src/RepoDb.Core.UnitTests/ClassHandlers/ClassHandlerInvocationTest.cs

@@ -39,10 +39,10 @@ private class ClassHandlerDbCommand : CustomDbCommand
     {
         protected override DbDataReader ExecuteDbDataReader(CommandBehavior behavior)
         {
-            var reader = new DataEntityDataReader<ClassHandlerTestClass>(new[]
-            {
+            var reader = new DataEntityDataReader<ClassHandlerTestClass>(
+            [
                 new ClassHandlerTestClass { Id = 1, Name = "James Doe" }
-            });
+            ]);
             return reader;
         }
     }

src/RepoDb.Core.UnitTests/ClassHandlers/ClassHandlerPrecedenceTest.cs

@@ -53,10 +53,10 @@ private class ClassHandlerDbCommand : CustomDbCommand
     {
         protected override DbDataReader ExecuteDbDataReader(CommandBehavior behavior)
         {
-            var reader = new DataEntityDataReader<ClassHandlerTestClass>(new[]
-            {
+            var reader = new DataEntityDataReader<ClassHandlerTestClass>(
+            [
                 new ClassHandlerTestClass { Id = 1, Name = "James Doe" }
-            });
+            ]);
             return reader;
         }
     }
@@ -73,10 +73,10 @@ private class ClassHandlerForEntityWithAttributeDbCommand : CustomDbCommand
     {
         protected override DbDataReader ExecuteDbDataReader(CommandBehavior behavior)
         {
-            var reader = new DataEntityDataReader<ClassHandlerTestClassWithAttribute>(new[]
-            {
+            var reader = new DataEntityDataReader<ClassHandlerTestClassWithAttribute>(
+            [
                 new ClassHandlerTestClassWithAttribute { Id = 1, Name = "James Doe" }
-            });
+            ]);
             return reader;
         }
     }
@@ -94,10 +94,10 @@ private class ClassHandlerForEntityWithGenericAttributeDbCommand : CustomDbComma
     {
         protected override DbDataReader ExecuteDbDataReader(CommandBehavior behavior)
         {
-            var reader = new DataEntityDataReader<ClassHandlerTestClassWithGenericAttribute>(new[]
-            {
+            var reader = new DataEntityDataReader<ClassHandlerTestClassWithGenericAttribute>(
+            [
                 new ClassHandlerTestClassWithGenericAttribute { Id = 1, Name = "James Doe" }
-            });
+            ]);
             return reader;
         }
     }

src/RepoDb.Core.UnitTests/CustomObjects/CustomDbHelper.cs

@@ -16,11 +16,11 @@ public override DbFieldCollection GetFields(IDbConnection connection,
         string tableName,
         IDbTransaction? transaction = null)
     {
-        return new(new[]
-        {
+        return new(
+        [
             new DbField("Id", true, true, false, typeof(int), null, null, null, null),
             new DbField("Name", false, false, true, typeof(string), null, null, null, null)
-        });
+        ]);
     }
 
     public override IEnumerable<DbSchemaObject> GetSchemaObjects(IDbConnection connection, IDbTransaction? transaction = null)

src/RepoDb.Core.UnitTests/DbHelpers/DbHelperTest.cs

@@ -34,11 +34,11 @@ private class DbHelperDbConnection : CustomDbConnection { }
 
     private DbFieldCollection GetDbFields()
     {
-        return new(new[]
-        {
+        return new(
+        [
             new DbField("Id", true, true, false, typeof(int), null, null, null, null),
             new DbField("Name", false, false, false, typeof(string), null, null, null, null)
-        });
+        ]);
     }
 
     public class MyDbHelper : BaseDbHelper
@@ -140,7 +140,7 @@ public void TestDbHelperForInsertAll()
         DbHelperMapper.Add<DbHelperDbConnection>(dbHelper.Object, true);
 
         // Act
-        connection.InsertAll<DbHelperDataEntity>(new[] { new DbHelperDataEntity { Id = 1, Name = "Name" } });
+        connection.InsertAll<DbHelperDataEntity>([new DbHelperDataEntity { Id = 1, Name = "Name" }]);
 
         // Assert
         dbHelper.Verify(builder =>
@@ -186,7 +186,7 @@ public void TestDbHelperForMergeAll()
         DbHelperMapper.Add<DbHelperDbConnection>(dbHelper.Object, true);
 
         // Act
-        connection.MergeAll<DbHelperDataEntity>(new[] { new DbHelperDataEntity { Id = 1, Name = "Name" } });
+        connection.MergeAll<DbHelperDataEntity>([new DbHelperDataEntity { Id = 1, Name = "Name" }]);
 
         // Assert
         dbHelper.Verify(builder =>
@@ -278,7 +278,7 @@ public void TestDbHelperForUpdateAll()
         DbHelperMapper.Add<DbHelperDbConnection>(dbHelper.Object, true);
 
         // Act
-        connection.UpdateAll<DbHelperDataEntity>(new[] { new DbHelperDataEntity { Id = 1, Name = "Name" } });
+        connection.UpdateAll<DbHelperDataEntity>([new DbHelperDataEntity { Id = 1, Name = "Name" }]);
 
         // Assert
         dbHelper.Verify(builder =>
@@ -357,7 +357,7 @@ public void TestDbHelperForInsertAllViaTableName()
 
         // Act
         connection.InsertAll(ClassMappedNameCache.Get<DbHelperDataEntity>(),
-            new[] { new { Id = 1, Name = "Name" } });
+            [new { Id = 1, Name = "Name" }]);
 
         // Assert
         dbHelper.Verify(builder =>
@@ -405,7 +405,7 @@ public void TestDbHelperForMergeAllViaTableName()
 
         // Act
         connection.MergeAll(ClassMappedNameCache.Get<DbHelperDataEntity>(),
-            new[] { new DbHelperDataEntity { Id = 1, Name = "Name" } });
+            [new DbHelperDataEntity { Id = 1, Name = "Name" }]);
 
         // Assert
         dbHelper.Verify(builder =>
@@ -500,7 +500,7 @@ public void TestDbHelperForUpdateAllViaTableName()
 
         // Act
         connection.UpdateAll(ClassMappedNameCache.Get<DbHelperDataEntity>(),
-            new[] { new DbHelperDataEntity { Id = 1, Name = "Name" } });
+            [new DbHelperDataEntity { Id = 1, Name = "Name" }]);
 
         // Assert
         dbHelper.Verify(builder =>