fix: field-exact network parse (AP-mode + disconnected); drop dead HA guards

Network.qml: parse "TYPE:STATE:CONNECTION" by exact fields instead of substring
includes(). Fixes two issues: (1) the bar showed a wifi-connected icon while the
device was a hotspot AP — now skipped when the connection is "Hotspot"; (2)
includes("connected") also matched "disconnected", so a disconnected ethernet
was mis-flagged as connected. Adds the CONNECTION field to the nmcli query.

HomeAssistantPanel.qml: remove the dead in-function null guards in hasDetail/
iconFor — both are called only from the root?.-guarded sites with a required
string arg, so entityId is never null; the real null risk (root during teardown)
is handled at the call site.

Author: AndrewDemsDS

quickshell/ii/modules/ii/sidebarLeft/homeAssistant/HomeAssistantPanel.qml

@@ -16,8 +16,6 @@ Item {
 
     // Entities that have sub-controls worth an expand affordance.
     function hasDetail(entityId) {
-        if (!entityId)
-            return false; // delegate modelData is transiently null during Repeater construction
         const d = entityId.split(".")[0];
         if (d === "climate" || d === "media_player" || d === "fan" || d === "cover" || d === "vacuum")
             return true;
@@ -27,8 +25,6 @@ Item {
     }
 
     function iconFor(entityId) {
-        if (!entityId)
-            return "help"; // delegate modelData is transiently null during Repeater construction
         const d = entityId.split(".")[0];
         switch (d) {
         case "light":

quickshell/ii/services/Network.qml

@@ -265,7 +265,7 @@ Singleton {
 
     Process {
         id: updateConnectionType
-        command: ["sh", "-c", "nmcli -t -f TYPE,STATE d status && nmcli -t -f CONNECTIVITY g"]
+        command: ["sh", "-c", "nmcli -t -f TYPE,STATE,CONNECTION d status && nmcli -t -f CONNECTIVITY g"]
         running: true
         // Re-trigger only restarts the process; StdioCollector below parses the FULL output
         // atomically on completion, so rapid nmcli-monitor events can't deliver a truncated
@@ -280,27 +280,32 @@ Singleton {
                 let hasEthernet = false;
                 let hasWifi = false;
                 let wifiStatus = "disconnected";
+                // Terse line: "TYPE:STATE:CONNECTION". Match fields EXACTLY — substring checks
+                // mis-fire ("disconnected" contains "connected"; "wifi-p2p" contains "wifi").
                 lines.forEach(line => {
-                    if (line.includes("ethernet") && line.includes("connected"))
+                    const parts = line.split(":");
+                    const type = parts[0];
+                    const state = parts[1] ?? "";
+                    const conn = parts.slice(2).join(":"); // connection name may contain ":"
+                    if (type === "ethernet" && state === "connected") {
                         hasEthernet = true;
-                    else if (line.includes("wifi:")) {
-                        if (line.includes("disconnected")) {
-                            wifiStatus = "disconnected"
-                        }
-                        else if (line.includes("connected")) {
+                    } else if (type === "wifi") {
+                        if (conn === "Hotspot") {
+                            // Our own AP profile — the device is an access point, not a station
+                            // uplink, so don't report it as a Wi-Fi connection.
+                        } else if (state === "connected") {
                             hasWifi = true;
-                            wifiStatus = "connected"
-
+                            wifiStatus = "connected";
                             if (connectivity === "limited") {
                                 hasWifi = false;
-                                wifiStatus = "limited"
+                                wifiStatus = "limited";
                             }
-                        }
-                        else if (line.includes("connecting")) {
-                            wifiStatus = "connecting"
-                        }
-                        else if (line.includes("unavailable")) {
-                            wifiStatus = "disabled"
+                        } else if (state === "connecting") {
+                            wifiStatus = "connecting";
+                        } else if (state === "unavailable") {
+                            wifiStatus = "disabled";
+                        } else {
+                            wifiStatus = "disconnected";
                         }
                     }
                 });