Commit f7b02e8
fix(ci): include update manifests for architecture-specific auto-updates (#611)
* fix(ci): include update manifests in release artifacts
electron-updater requires .yml and .blockmap files to perform
architecture-specific updates on macOS (arm64 vs x64).
Without these files:
- Auto-updater can't detect architecture
- ARM Macs may download Intel builds (run under Rosetta)
- Delta updates don't work
This fix ensures electron-updater can:
- Detect correct architecture (arm64 vs x64)
- Download architecture-specific builds
- Perform efficient delta updates via blockmap files
References:
- electron-userland/electron-builder#5592
- electron-userland/electron-builder#7975
Signed-off-by: Hunter Luisi <hluisi@gmail.com>
* fix(ci): copy yml and blockmap files to release assets
The previous commit added yml/blockmap to artifact uploads, but the
'Flatten and validate artifacts' step wasn't copying them to the
release-assets directory.
Without this fix, the manifest files wouldn't be included in the GitHub
release, making the architecture detection fix ineffective.
Thanks to @coderabbitai for catching this!
Signed-off-by: Hunter Luisi <hluisi@gmail.com>
* fix(ci): add validation for electron-updater manifest files
Adds explicit check that .yml manifest files are present in release
assets. Issues a warning if no manifests found, helping catch cases
where electron-builder fails to generate them.
* fix(ci): separate installer and manifest validation
- Add separate check for installer files (dmg, zip, exe, etc.)
to prevent releases with only manifest files and no installers
- Change missing yml from warning to error since manifests are
required for auto-update architecture detection to work
- Improve output formatting to show installers and manifests separately
Addresses review feedback from Auto Claude PR Review.
---------
Signed-off-by: Hunter Luisi <hluisi@gmail.com>
Co-authored-by: Andy <119136210+AndyMik90@users.noreply.github.com>1 parent 4ec9db8 commit f7b02e8
1 file changed
Lines changed: 28 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| 104 | + | |
| 105 | + | |
104 | 106 | | |
105 | 107 | | |
106 | 108 | | |
| |||
186 | 188 | | |
187 | 189 | | |
188 | 190 | | |
| 191 | + | |
| 192 | + | |
189 | 193 | | |
190 | 194 | | |
191 | 195 | | |
| |||
248 | 252 | | |
249 | 253 | | |
250 | 254 | | |
| 255 | + | |
| 256 | + | |
251 | 257 | | |
252 | 258 | | |
253 | 259 | | |
| |||
317 | 323 | | |
318 | 324 | | |
319 | 325 | | |
| 326 | + | |
| 327 | + | |
320 | 328 | | |
321 | 329 | | |
322 | 330 | | |
| |||
336 | 344 | | |
337 | 345 | | |
338 | 346 | | |
339 | | - | |
| 347 | + | |
340 | 348 | | |
341 | | - | |
342 | | - | |
343 | | - | |
344 | | - | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
345 | 353 | | |
346 | 354 | | |
347 | 355 | | |
348 | | - | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
349 | 371 | | |
350 | 372 | | |
351 | 373 | | |
| |||
0 commit comments