Skip to content

Commit eb2809a

Browse files
author
AnkleBreaker Cowork
committed
fix: CI - out-of-line Client ctor (incomplete Transport in unwind path), widen ISO timestamp buffer, drop nested comment token
1 parent 5eb97f3 commit eb2809a

4 files changed

Lines changed: 8 additions & 3 deletions

File tree

src/client.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ std::string trim_trailing_slash(std::string value) {
6464

6565
} // namespace
6666

67+
Client::Client() = default;
68+
6769
Client::~Client() {
6870
try {
6971
stop_heartbeat();

src/client.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,10 @@ class Transport;
3434
*/
3535
class Client {
3636
public:
37-
Client() = default;
37+
// Both out-of-line (client.cpp): members hold unique_ptr<Transport> with
38+
// Transport forward-declared, so the ctor's unwind path and the dtor must
39+
// be emitted in a TU that sees the complete type.
40+
Client();
3841
~Client();
3942

4043
Client(const Client &) = delete;

src/clock.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ std::string format_iso8601_utc_ms(std::int64_t ms_since_epoch) {
4444
const auto second = static_cast<int>((ms_of_day / 1'000) % 60);
4545
const auto millis = static_cast<int>(ms_of_day % 1'000);
4646

47-
char buffer[32] = {};
47+
char buffer[64] = {};
4848
std::snprintf(buffer, sizeof(buffer), "%04lld-%02u-%02uT%02d:%02d:%02d.%03dZ",
4949
static_cast<long long>(date.year), date.month, date.day, hour, minute, second,
5050
millis);

src/payloads.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ namespace tombstone {
1818
* (`false` means "no log" per the server contract).
1919
*/
2020

21-
/** Schema maxima (src/lib/*-schema.ts in the Tombstone monorepo). */
21+
/** Schema maxima (the per-endpoint schema files under src/lib in the Tombstone monorepo). */
2222
namespace limits {
2323
constexpr std::size_t build_version = 64;
2424
constexpr std::size_t signature = 128;

0 commit comments

Comments
 (0)