refactor(Account): better error display when version not detected

Author: fubuloubu

ape_safe/accounts.py

@@ -28,6 +28,7 @@
     NoLocalSigners,
     NotASigner,
     NotEnoughSignatures,
+    NoVersionDetected,
     SafeClientException,
     handle_safe_logic_error,
 )
@@ -344,12 +345,8 @@ def version(self) -> Version:
         if isinstance(version := ContractCall(VERSION_ABI, address=self.address)(), str):
             return Version(version)
 
-        # NOTE: If `eth_call` returns nothing, it will be rendered as randomly
-        raise ContractNotFoundError(
-            self.address,
-            bool(self.provider.network.explorer),
-            self.provider.network_choice,
-        )
+        # NOTE: If `eth_call` returns nothing, the safe is likely not on the correct network
+        raise NoVersionDetected(self.address)
 
     @property
     def signers(self) -> list[AddressType]:

ape_safe/exceptions.py

@@ -1,7 +1,13 @@
 from contextlib import ContextDecorator
 from typing import TYPE_CHECKING, Optional
 
-from ape.exceptions import AccountsError, ApeException, ContractLogicError, SignatureError
+from ape.exceptions import (
+    AccountsError,
+    ApeException,
+    ContractLogicError,
+    DecodingError,
+    SignatureError,
+)
 
 if TYPE_CHECKING:
     from ape.types import AddressType
@@ -18,6 +24,14 @@ class ApeSafeError(ApeSafeException, AccountsError):
     """
 
 
+class NoVersionDetected(ApeSafeException, DecodingError):
+    def __init__(self, safe: "AddressType"):
+        super().__init__(
+            f"Could not detect `VERSION()` for {safe}.\n\n"
+            "**Are you sure you are on the right network?**"
+        )
+
+
 class NotASigner(ApeSafeException):
     def __init__(self, signer: "AddressType"):
         super().__init__(f"{signer} is not a valid signer.")