Merge pull request #345 from Appsilon/michal.fixes

dokato · web-flow · commit 6ef98f859831 · 2021-01-14T09:41:57.000Z
Remove inline-styled min-height from &lt;body&gt;
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: shiny.semantic
 Type: Package
 Title: Semantic UI Support for Shiny
-Version: 0.4.2
+Version: 0.4.3
 Authors@R: c(person("Filip", "Stachura", email = "filip@appsilon.com", role = "aut"),
   person("Dominik", "Krzeminski", email = "dominik@appsilon.com", role = "cre"),
   person("Krystian", "Igras", email = "krystian@appsilon.com", role = "aut"),
diff --git a/R/semanticPage.R b/R/semanticPage.R
@@ -173,7 +173,7 @@ semanticPage <- function(..., title = "", theme = NULL, suppress_bootstrap = TRU
       shiny::tags$script(src = "shiny.semantic/shiny-semantic-progress.js"),
       shiny::tags$script(src = "shiny.semantic/shiny-semantic-toast.js")
     ),
-    shiny::tags$body(style = glue::glue("margin:{margin}; min-height: 611px;"),
+    shiny::tags$body(style = glue::glue("margin:{margin};"),
                      suppress_bootstrap,
                      ...)
   )

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ semanticPage <- function(..., title = "", theme = NULL, suppress_bootstrap = TRU`
`173`	`173`	`shiny::tags$script(src = "shiny.semantic/shiny-semantic-progress.js"),`
`174`	`174`	`shiny::tags$script(src = "shiny.semantic/shiny-semantic-toast.js")`
`175`	`175`	`),`
`176`		`- shiny::tags$body(style = glue::glue("margin:{margin}; min-height: 611px;"),`
	`176`	`+ shiny::tags$body(style = glue::glue("margin:{margin};"),`
`177`	`177`	`suppress_bootstrap,`
`178`	`178`	`...)`
`179`	`179`	`)`