feat(compare and upload): After upload, refresh FC parameter values in parameter tables

Author: amilcarlucas

ARCHITECTURE_parameter_upload.md

@@ -56,6 +56,12 @@ configuration step, write to the selected file, or ask whether temporary edits s
    Upload checkbox is not selected. Close the modal after a successful upload without advancing the
    AMC configuration step.
 
+7. **Post-upload synchronization**:
+   - After a successful upload and verification download, update the FC-value snapshot in each
+     external `ArduPilotParameter` object from the refreshed `fc_parameters` cache.
+   - Refresh the underlying parameter table whenever the compare-and-upload window closes so it
+     reflects the latest FC parameter values.
+
 ### Non-Functional Requirements
 
 - Avoid duplicating parameter table rendering and upload orchestration.
@@ -120,6 +126,8 @@ filesystem state.
   - Apply the changed-only filter.
   - Obtain the checked upload payload from the table.
   - Run upload precondition checks and delegate to the parent upload workflow.
+  - Synchronize external FC-value snapshots after successful upload verification.
+  - Refresh the parent parameter table when the modal closes.
   - Close without invoking project navigation or save operations.
 
 The modal upload button does not duplicate the entry-point connection-state gate. The upload
@@ -218,8 +226,9 @@ Each external parameter has four relevant pieces of state:
 | Manual selection | `ParameterTableOptions.manually_editable_parameters` | Modal lifetime | No |
 
 The FC value and parameter metadata in each external parameter object are snapshots supplied when
-the object is created. The shared upload workflow refreshes its FC parameter cache for verification;
-it does not convert the modal's original comparison values into project state.
+the object is created. After a successful external upload and verification download, the modal
+updates those FC-value snapshots from the refreshed cache before closing. Closing the modal also
+repopulates the underlying parameter table so it displays the latest FC values.
 
 ## Detailed Workflows
 
@@ -269,8 +278,10 @@ forced and derived parameters in AMC-managed configuration steps.
 6. Reset-required parameters, reconnection, remaining uploads, re-download, and validation follow
    the normal parameter editor rules.
 7. The user reviews the differences and may edit values temporarily before pressing `Upload selected params to the FC`.
-8. On success the modal closes.
-9. The current AMC configuration step is not saved, skipped, or advanced; no tuning report or
+8. On success the modal updates the external parameters' FC-value snapshots from the verified
+   download and closes.
+9. Closing the modal repopulates the underlying AMC parameter table with the latest FC values.
+10. The current AMC configuration step is not saved, skipped, or advanced; no tuning report or
    FC-difference export is written.
 
 ## Data Integrity Invariants
@@ -326,6 +337,8 @@ The following invariants define the boundary between external upload and project
 - Verify external-only names do not access `current_step_parameters`.
 - Verify only Upload-checked parameters enter the payload.
 - Verify the modal delegates to the shared upload workflow and never advances the project.
+- Verify successful uploads update external FC-value snapshots from the verified download.
+- Verify closing the modal refreshes the underlying parameter table.
 - Verify a failed model upload leaves the modal open.
 - Verify Manual toggles update only the affected row rather than rebuilding the static table.
 - Verify file-selection and parse-error orchestration.

ardupilot_methodic_configurator/frontend_tkinter_parameter_compare_and_upload.py

@@ -143,8 +143,16 @@ def upload_parameters(self) -> None:
         if not self.parent.parameter_editor.ensure_upload_preconditions(dict(selected_params), self.parent.ui.show_warning):
             return
         if self.parent.upload_external_params(selected_params):
+            self._update_fc_values_from_parent()
             self.close()
 
+    def _update_fc_values_from_parent(self) -> None:
+        """Update the external parameter snapshot after a verified FC upload."""
+        fc_parameters = self.parent.parameter_editor.fc_parameters
+        for param_name, parameter in self.parameters.items():
+            if param_name in fc_parameters:
+                parameter.set_fc_value(fc_parameters[param_name])
+
     def reset_all_parameters_to_default(self) -> None:
         """Confirm and reset all flight-controller parameters to their factory defaults."""
         if (
@@ -160,7 +168,8 @@ def reset_all_parameters_to_default(self) -> None:
             self.close()
 
     def close(self) -> None:
-        """Close the modal window."""
+        """Close the modal window and refresh the underlying parameter table."""
         if sys_platform != "darwin":
             self.root.grab_release()
         self.root.destroy()
+        self.parent.repopulate_parameter_table()

tests/test_frontend_tkinter_parameter_compare_and_upload.py

@@ -14,6 +14,7 @@
 
 from unittest.mock import MagicMock, call, patch
 
+from ardupilot_methodic_configurator.data_model_ardupilot_parameter import ArduPilotParameter
 from ardupilot_methodic_configurator.data_model_par_dict import Par, ParDict
 from ardupilot_methodic_configurator.frontend_tkinter_parameter_compare_and_upload import ParameterFileUploadWindow
 from ardupilot_methodic_configurator.frontend_tkinter_parameter_editor import ParameterEditorWindow
@@ -384,6 +385,36 @@ def test_upload_uses_external_parameters_without_advancing_project() -> None:
     window.parent.on_skip_click.assert_not_called()
 
 
+def test_successful_external_upload_updates_fc_values_before_closing() -> None:
+    """Refresh a real external parameter's FC-value snapshot after upload verification."""
+    window = _window_without_tk()
+    parameter = ArduPilotParameter("ROLL_P", Par(0.2), fc_value=0.1)
+    window.parameters = {"ROLL_P": parameter}
+    window.parent.parameter_editor.fc_parameters = {"ROLL_P": 0.2}
+    selected_params = ParDict({"ROLL_P": Par(0.2)})
+    window.table.get_upload_selected_params.return_value = selected_params
+    window.parent.parameter_editor.ensure_upload_preconditions.return_value = True
+    window.parent.upload_external_params.return_value = True
+    window.close = MagicMock()
+
+    window.upload_parameters()
+
+    assert parameter.fc_value_as_string == "0.2"
+    assert not parameter.is_different_from_fc
+    window.close.assert_called_once_with()
+
+
+def test_closing_external_upload_window_refreshes_parent_table() -> None:
+    """Refresh the normal parameter table after the modal is closed."""
+    window = _window_without_tk()
+    window.root = MagicMock()
+
+    window.close()
+
+    window.root.destroy.assert_called_once_with()
+    window.parent.repopulate_parameter_table.assert_called_once_with()
+
+
 def test_failed_external_upload_keeps_modal_open() -> None:
     """
     Keep the external modal open after a failed upload.