fix(pylint): fix pylint issues

Author: amilcarlucas

tests/acceptance_only_changed_get_uploaded_usage.py

@@ -60,8 +60,8 @@ def _build_parameter_editor_window(root: object) -> tuple[ParameterEditorWindow,
     cast("Any", window).ui = ui
     cast("Any", window).upload_selected_params = upload_params
     cast("Any", window).on_skip_click = on_skip
-    cast("Any", window)._log_availability_report_window = None
-    cast("Any", window)._log_report_return_pending = False
+    cast("Any", window)._log_availability_report_window = None  # pylint: disable=protected-access
+    cast("Any", window)._log_report_return_pending = False  # pylint: disable=protected-access
 
     mocks = {
         "write_changes": write_changes,

tests/test_data_model_availability_models.py

@@ -195,7 +195,7 @@ def test_esc_analysis_does_not_report_zero_error_rates_as_findings() -> None:
 
     outcomes = EscLogAnalysis(log_data, _context({})).check_per_instance_errors()
 
-    assert outcomes == []
+    assert not outcomes
 
 
 def test_esc_analysis_ignores_a_single_zero_rpm_sample() -> None:
@@ -212,7 +212,7 @@ def test_esc_analysis_ignores_a_single_zero_rpm_sample() -> None:
 
     outcomes = EscLogAnalysis(log_data, _context({})).check_rpm_while_armed()
 
-    assert outcomes == []
+    assert not outcomes
 
 
 def test_esc_analysis_skips_dshot_rate_for_pwm_output() -> None:
@@ -228,4 +228,4 @@ def test_esc_analysis_skips_dshot_rate_for_pwm_output() -> None:
         ),
     )
 
-    assert model.check_dshot_output_rate() == []
+    assert not model.check_dshot_output_rate()

tests/test_extract_missing_translations.py

@@ -22,7 +22,7 @@
 # Add the parent directory to the path to import the script
 sys.path.append(os.path.abspath(os.path.join(os.path.dirname(__file__), "../.github/skills/update-gui-translations/scripts")))
 
-# pylint: disable=wrong-import-position
+# pylint: disable=wrong-import-position,import-error
 import extract_missing_translations  # type: ignore[import-not-found]  # ty: ignore[unresolved-import]
 
 # pylint: enable=wrong-import-position

tests/test_frontend_tkinter_log_analysis.py

@@ -50,7 +50,7 @@ def _make_availability_issue(message: str = "issue", config_step: str | None = N
     return issue
 
 
-def _make_availability_result(
+def _make_availability_result(  # pylint: disable=too-many-arguments
     *,
     name: str = "Battery",
     available: bool = True,
@@ -266,7 +266,7 @@ def test_ignores_step_info_with_no_urls_at_all(self) -> None:
 
         links = _collect_links(availability_dict, None)
 
-        assert links == []
+        assert not links
 
     def test_returns_empty_list_when_no_availability_or_analysis_dicts_given(self) -> None:
         """
@@ -278,7 +278,7 @@ def test_returns_empty_list_when_no_availability_or_analysis_dicts_given(self) -
         """
         links = _collect_links(None, None)
 
-        assert links == []
+        assert not links
 
     def test_ignores_issues_or_outcomes_missing_step_info_key(self) -> None:
         """
@@ -292,7 +292,7 @@ def test_ignores_issues_or_outcomes_missing_step_info_key(self) -> None:
 
         links = _collect_links(availability_dict, None)
 
-        assert links == []
+        assert not links
 
 
 class TestFormatComponent:
@@ -324,7 +324,7 @@ def test_skips_empty_manufacturer_and_model(self) -> None:
 
         lines = _format_component(component)
 
-        assert lines == []
+        assert not lines
 
     def test_formats_firmware_type_and_version(self) -> None:
         """
@@ -377,7 +377,7 @@ def test_returns_empty_list_for_completely_empty_component(self) -> None:
         WHEN: The component is formatted
         THEN: The result is an empty list
         """
-        assert _format_component({}) == []
+        assert not _format_component({})
 
     def test_ignores_non_dict_connection_like_values(self) -> None:
         """
@@ -391,7 +391,7 @@ def test_ignores_non_dict_connection_like_values(self) -> None:
 
         lines = _format_component(component)
 
-        assert lines == []
+        assert not lines
 
 
 @pytest.fixture
@@ -424,7 +424,7 @@ def bare_window() -> LogAnalysisReportWindow:
 class TestWindowConstruction:
     """Cover LogAnalysisReportWindow's full __init__ flow with widgets mocked."""
 
-    def _build_window(
+    def _build_window(  # pylint: disable=too-many-arguments
         self,
         mocker: MockerFixture,
         patched_widgets: dict[str, MagicMock],
@@ -434,6 +434,7 @@ def _build_window(
         report: dict | None = None,
         vehicle_dir: str = "/vehicle",
     ) -> LogAnalysisReportWindow:
+        _ = patched_widgets  # Keep the widget patches active while constructing the window.
         mocker.patch.object(LogAnalysisReportWindow, "calculate_scaled_geometry", return_value="1050x800")
         mocker.patch.object(LogAnalysisReportWindow, "center_window")
         summary = _make_summary(availability_results, analysis_results)
@@ -464,7 +465,7 @@ def test_selector_defaults_to_first_subsystem(self, mocker: MockerFixture, patch
             mocker, patched_widgets, [availability_battery, availability_imu], [analysis_battery, analysis_imu]
         )
 
-        window.selector.set.assert_called_once_with("Battery")
+        cast("MagicMock", window.selector.set).assert_called_once_with("Battery")
 
     def test_no_selector_default_when_no_subsystems_present(
         self, mocker: MockerFixture, patched_widgets: dict[str, MagicMock]
@@ -478,15 +479,13 @@ def test_no_selector_default_when_no_subsystems_present(
         """
         window = self._build_window(mocker, patched_widgets, [], [])
 
-        window.selector.set.assert_not_called()
+        cast("MagicMock", window.selector.set).assert_not_called()
 
 
 class TestTuningGraphButton:
     """Cover the footer's Tuning Parameter Graph button state and click handler."""
 
-    def test_button_enabled_when_tuning_report_exists(
-        self, mocker: MockerFixture, patched_widgets: dict[str, MagicMock], tmp_path: Path
-    ) -> None:
+    def test_button_enabled_when_tuning_report_exists(self, patched_widgets: dict[str, MagicMock], tmp_path: Path) -> None:
         """
         The tuning graph button is enabled when tuning_report.csv exists in the vehicle directory.
 
@@ -505,9 +504,7 @@ def test_button_enabled_when_tuning_report_exists(
         button_mock = patched_widgets["button"].return_value
         button_mock.configure.assert_any_call(state="normal")
 
-    def test_button_disabled_when_tuning_report_missing(
-        self, mocker: MockerFixture, patched_widgets: dict[str, MagicMock], tmp_path: Path
-    ) -> None:
+    def test_button_disabled_when_tuning_report_missing(self, patched_widgets: dict[str, MagicMock], tmp_path: Path) -> None:
         """
         The tuning graph button is disabled when tuning_report.csv is absent.
 

tests/test_frontend_tkinter_log_quality.py

@@ -62,7 +62,7 @@ def test_availability_fix_accepts_non_false_upload_result(upload_result: bool |
     fixes = [("MOT_SPIN_MIN", 0.1, 0.15, ["finding"])]
 
     # Act: apply the proposed change.
-    window._apply_param_fixes(fixes, dialog)
+    window._apply_param_fixes(fixes, dialog)  # pylint: disable=protected-access
 
     # Assert: None is not mistaken for an upload failure.
     assert window.summary.related_parameter_values == {"MOT_SPIN_MIN": 0.15}

tests/unit_backend_log_extraction.py

@@ -325,7 +325,7 @@ def test_second_pass_reports_progress_against_known_message_count(self) -> None:
         assert progress_calls == [(1, 3), (2, 3), (3, 3)]
 
 
-class TestExtractSchemas:  # pylint: disable=too-few-public-methods
+class TestExtractSchemas:
     """Tests for extract_schemas()."""
 
     def test_extract_schemas_populates_message_schema(self, empty_log_data: LogData) -> None:  # pylint: disable=redefined-outer-name