feat(config): fold [skip_paths] into ASIMOV_SKIP_PATHS and teach doctor about it

Follow-up to the [skip_paths] work: append the configured paths to
ASIMOV_SKIP_PATHS at definition time instead of merging them into a local
array in each consumer, so the find expression and the Spotlight pass stay
in step, add the section to the doctor config validator (it reported
[skip_paths] as an unknown section), and cover both in tests.

The behaviour test passed an absolute path to create_project, which prefixes
$HOME - so the project was built outside the skipped directory and the test
passed for the wrong reason. Fixed, plus a control case that fails without
the config, a multi-entry case, and one proving [fixed_dirs] still wins
inside a skipped path.

Author: django23

CHANGELOG.md

@@ -7,7 +7,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 ## [Unreleased]
 
 ### Added
-- `[skip_paths]` configuration option to skip sub directories in search.
+- `[skip_paths]` config section: name directories that Asimov should never search, alongside the built-in `~/.Trash` and `~/Library`. Thanks [@lunaluxie](https://github.com/lunaluxie)!
 
 ### Changed
 

README.md

@@ -274,19 +274,19 @@ extra   = ~/my-build-cache       # plus any paths you name (always excluded when
 extra   = ~/golang/pkg/mod       # e.g. a Go module cache under a custom GOPATH
 ```
 
-### Exclude paths from search
-Sometimes you may want to exclude directories from the search. By default, Asimov excludes `~/.Trash`
-and `~/Library` to avoid modifying Time Machine exclusions for these paths. You can add additional paths to the search exclusion list:
+### Skip parts of your home directory
+
+Asimov never descends into `~/.Trash` or `~/Library`. Add directories of your own under `[skip_paths]` and they're left alone too - not searched, never excluded:
 
 ```ini
 [skip_paths]
-extra = ~/Music
+extra = ~/Music                  # one "extra =" line per directory
 extra = ~/Pictures
 ```
 
-`skip_paths` does not exclude global caches defined in `fixed_dirs`.
+This only narrows the *search*. Global caches you opted into under `[fixed_dirs]` are still excluded, even inside a skipped path.
 
-If your code is contained to a single subfolder, you may want to only search that subfolder instead by specifying the directory argument in the CLI ([see usage](#usage)).
+If all your code lives in one folder, scanning just that folder (`asimov ~/Code`, see [usage](#usage)) is usually simpler than skipping everything else.
 
 ## Other install methods
 

asimov

@@ -626,7 +626,7 @@ doctor_check_config() {
         if [[ "$line" =~ ^\[([a-z_]+)\]$ ]]; then
             section="${BASH_REMATCH[1]}"
             case "$section" in
-                fixed_dirs|scan|sentinels) ;;
+                fixed_dirs|scan|sentinels|skip_paths) ;;
                 *)
                     unknown=$((unknown + 1))
                     doctor_problem "unknown section [${section}] in ${config_file}"
@@ -639,11 +639,11 @@ doctor_check_config() {
             key="${BASH_REMATCH[1]}"
             case "${section}:${key}" in
                 fixed_dirs:enabled|fixed_dirs:extra|scan:extra|\
-                sentinels:extra|sentinels:disabled) ;;
+                sentinels:extra|sentinels:disabled|skip_paths:extra) ;;
                 *)
                     # A key under an already-reported section is the same fault.
                     case "$section" in
-                        fixed_dirs|scan|sentinels)
+                        fixed_dirs|scan|sentinels|skip_paths)
                             unknown=$((unknown + 1))
                             doctor_problem "unknown key '${key}' under [${section}] in ${config_file}"
                             ;;
@@ -1102,11 +1102,7 @@ discover_new_paths_via_mdfind() {
         # Skip paths under ASIMOV_SKIP_PATHS
         local skip=false
         local skip_dir
-        local all_skip_paths=("${ASIMOV_SKIP_PATHS[@]}")
-        if [[ ${#ASIMOV_CONFIG_EXTRA_SKIP_PATHS[@]} -gt 0 ]]; then
-            all_skip_paths+=("${ASIMOV_CONFIG_EXTRA_SKIP_PATHS[@]}")
-        fi
-        for skip_dir in "${all_skip_paths[@]}"; do
+        for skip_dir in "${ASIMOV_SKIP_PATHS[@]}"; do
             if [[ "$candidate" == "${skip_dir}"/* || "$candidate" == "${skip_dir}" ]]; then
                 skip=true
                 break
@@ -1164,9 +1160,13 @@ discover_new_paths_via_mdfind() {
 # Paths to unconditionally skip over. This prevents Asimov from modifying the
 # Time Machine exclusions for these paths (and descendants). It has an important
 # side-effect of speeding up the search.
+#
+# Anything listed under [skip_paths] in the config file is appended here, so the
+# find expression and the Spotlight pass both honour it.
 readonly ASIMOV_SKIP_PATHS=(
     "${ASIMOV_ROOT}/.Trash"
     "${ASIMOV_ROOT}/Library"
+    ${ASIMOV_CONFIG_EXTRA_SKIP_PATHS[@]+"${ASIMOV_CONFIG_EXTRA_SKIP_PATHS[@]}"}
 )
 
 # A list of "directory"/"sentinel" pairs.
@@ -1409,18 +1409,14 @@ exclude_paths_from_stdin() {
     fi
 }
 
-# Build find parameters to skip ASIMOV_SKIP_PATHS (hardcoded directories like .Trash, Library).
+# Build find parameters to skip ASIMOV_SKIP_PATHS (.Trash, Library, plus [skip_paths] extras).
 # Already-excluded paths are NOT pruned here — they are filtered cheaply via grep in
 # exclude_paths_from_stdin instead, avoiding the O(dirs × prune_count) performance trap.
 # Result is stored in global find_parameters_skip.
 build_find_skip_params() {
     find_parameters_skip=()
     local skip_dir
-    local all_skip_paths=("${ASIMOV_SKIP_PATHS[@]}")
-    if [[ ${#ASIMOV_CONFIG_EXTRA_SKIP_PATHS[@]} -gt 0 ]]; then
-        all_skip_paths+=("${ASIMOV_CONFIG_EXTRA_SKIP_PATHS[@]}")
-    fi
-    for skip_dir in "${all_skip_paths[@]}"; do
+    for skip_dir in "${ASIMOV_SKIP_PATHS[@]}"; do
         find_parameters_skip+=( -not \( -path "${skip_dir}" -prune \) )
     done
 }

tests/behavior.bats

@@ -121,13 +121,43 @@ load test_helper
 }
 
 @test "skips directories given in [skip_paths] config" {
-  mkdir -p "${HOME}/.skipme"
   write_config "[skip_paths]
-extra = ~/.skipme"
-  create_project ""${HOME}/.skipme"/Code/First-Project" "composer.json" "vendor"
+extra = ~/Music"
+  create_project "Music/Code/First-Project" "composer.json" "vendor"
   run_asimov
+  refute_excluded "${HOME}/Music/Code/First-Project/vendor"
   [[ "$(count_exclusions)" -eq 0 ]]
-  refute_excluded "${HOME}/.skipme/Code/First-Project/vendor"
+}
+
+@test "excludes the same project when [skip_paths] is absent" {
+  create_project "Music/Code/First-Project" "composer.json" "vendor"
+  run_asimov
+  assert_excluded "${HOME}/Music/Code/First-Project/vendor"
+}
+
+@test "[skip_paths] accepts several entries" {
+  write_config "[skip_paths]
+extra = ~/Music
+extra = ~/Pictures"
+  create_project "Music/First-Project" "composer.json" "vendor"
+  create_project "Pictures/Second-Project" "package.json" "node_modules"
+  create_project "Code/Third-Project" "package.json" "node_modules"
+  run_asimov
+  refute_excluded "${HOME}/Music/First-Project/vendor"
+  refute_excluded "${HOME}/Pictures/Second-Project/node_modules"
+  assert_excluded "${HOME}/Code/Third-Project/node_modules"
+}
+
+@test "[skip_paths] does not suppress fixed directories inside it" {
+  write_config "[fixed_dirs]
+enabled = true
+extra = ~/Music/build-cache
+
+[skip_paths]
+extra = ~/Music"
+  mkdir -p "${HOME}/Music/build-cache"
+  run_asimov
+  assert_excluded "${HOME}/Music/build-cache"
 }
 
 # =============================================================================

tests/doctor.bats

@@ -260,6 +260,26 @@ enabled = true"
   [[ "$output" == *".config/asimov/config"* ]]
 }
 
+@test "doctor accepts a [skip_paths] section" {
+  write_config "[skip_paths]
+extra = ~/Music"
+
+  run_asimov doctor
+
+  [[ "$status" -eq 0 ]]
+  [[ "$output" == *"looks valid"* ]]
+}
+
+@test "doctor flags an unknown key under [skip_paths]" {
+  write_config "[skip_paths]
+exrta = ~/Music"
+
+  run_asimov doctor
+
+  [[ "$status" -eq 1 ]]
+  [[ "$output" == *"exrta"* ]]
+}
+
 @test "doctor flags an unknown config key" {
   write_config "[fixed_dirs]
 enbaled = true"