Skip to content

Commit 45f1054

Browse files
AlexD717PepperLola
andauthored
fix(camera): use empty string instead of undefined (#1501)
Co-authored-by: Julian Wright <PepperLola@users.noreply.github.com>
1 parent 625c3d5 commit 45f1054

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

fission/src/ui/panels/configuring/CameraSelectionPanel.tsx

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -174,17 +174,18 @@ const FieldViewSettings: React.FC = () => {
174174
<div className="flex flex-col gap-1 w-full">
175175
<span className="text-xs opacity-70 select-none">Focus Robot</span>
176176
<Select
177-
value={focusedRobotId}
177+
value={focusedRobotId ?? ""}
178178
onChange={e => {
179-
const id = e.target.value as SceneObjectId
179+
const id = (e.target.value || null) as SceneObjectId | null
180180
const robot = id == null ? undefined : robots.find(r => r.id === id)
181181
setFocusedRobotId(id)
182182
getFieldViewControls()?.focusRobot(robot)
183183
}}
184184
size="small"
185185
fullWidth
186+
displayEmpty
186187
>
187-
<MenuItem value={undefined}>None</MenuItem>
188+
<MenuItem value="">None</MenuItem>
188189
{robots.map(r => (
189190
<MenuItem key={r.id} value={r.id}>
190191
{r.descriptiveName}
@@ -273,12 +274,13 @@ const CameraSelectionPanel: React.FC<PanelImplProps<void, void>> = ({ panel }) =
273274
<div className="flex flex-col gap-1 w-full">
274275
<span className="text-xs opacity-70 select-none">Focus Target</span>
275276
<Select
276-
value={focusedId}
277-
onChange={e => onFocusChange((e.target.value ?? null) as SceneObjectId | null)}
277+
value={focusedId ?? ""}
278+
onChange={e => onFocusChange((e.target.value || null) as SceneObjectId | null)}
278279
size="small"
279280
fullWidth
281+
displayEmpty
280282
>
281-
<MenuItem value={undefined}>None</MenuItem>
283+
<MenuItem value="">None</MenuItem>
282284
{sceneObjects.map(t => (
283285
<MenuItem key={t.id} value={t.id}>
284286
{t.miraType === MiraType.ROBOT ? t.descriptiveName : t.assemblyName}

0 commit comments

Comments
 (0)