add negative path test coverage (#490)

Co-authored-by: macbook <lawaltoheeb36@gmail.com>

Author: codefather2026

__tests__/review-transaction.negative.test.tsx

@@ -0,0 +1,151 @@
+import React from 'react';
+import { render, fireEvent, waitFor } from '@testing-library/react-native';
+
+jest.mock('expo-router');
+jest.mock('../src/services/stellar', () => ({
+  server: {
+    fetchBaseFee: jest.fn(async () => 100),
+  },
+  sendXlmTransaction: jest.fn(),
+}));
+jest.mock('../src/store/walletStore');
+jest.mock('../src/store/appStore', () => ({
+  useAppStore: jest.fn((selector) => {
+    const state = { contacts: [] };
+    return selector ? selector(state) : state;
+  }),
+}));
+jest.mock('../src/hooks/useTheme', () => ({
+  useTheme: () => ({
+    colors: {
+      background: '#000000',
+      surface: '#111111',
+      textPrimary: '#ffffff',
+      textSecondary: '#bbbbbb',
+      textMuted: '#999999',
+      primary: '#00E5FF',
+      success: '#00C853',
+      warning: '#FFB300',
+      error: '#FF5252',
+      border: '#333333',
+    },
+  }),
+}));
+jest.mock('lucide-react-native', () => ({
+  ArrowRight: () => null,
+  Smartphone: () => null,
+  AlertTriangle: () => null,
+  CheckCircle: () => null,
+  XCircle: () => null,
+}));
+jest.mock('@/components', () => {
+  const React = require('react');
+  const { Text, TouchableOpacity, View } = require('react-native');
+
+  return {
+    Button: ({ title, onPress }: any) => (
+      <TouchableOpacity onPress={onPress}>
+        <Text>{title}</Text>
+      </TouchableOpacity>
+    ),
+    LoadingState: ({ accessibilityLabel }: any) => <Text>{accessibilityLabel}</Text>,
+    ReviewConfirm: ({ items, confirmLabel, onConfirm, cancelLabel, onCancel }: any) => (
+      <View>
+        {items.map((item: any) => (
+          <Text key={item.label}>{item.value}</Text>
+        ))}
+        {confirmLabel ? (
+          <TouchableOpacity onPress={onConfirm}>
+            <Text>{confirmLabel}</Text>
+          </TouchableOpacity>
+        ) : null}
+        {cancelLabel ? (
+          <TouchableOpacity onPress={onCancel}>
+            <Text>{cancelLabel}</Text>
+          </TouchableOpacity>
+        ) : null}
+      </View>
+    ),
+    ReviewItem: () => null,
+    ScreenHeader: ({ title, subtitle }: any) => (
+      <View>
+        <Text>{title}</Text>
+        {subtitle ? <Text>{subtitle}</Text> : null}
+      </View>
+    ),
+    StatusBadge: ({ text }: any) => <Text>{text}</Text>,
+  };
+});
+
+import { useRouter, useLocalSearchParams } from 'expo-router';
+import { sendXlmTransaction } from '../src/services/stellar';
+import { useWalletStore } from '../src/store/walletStore';
+import { useSignerStore } from '../src/store/signerStore';
+import ReviewTransactionScreen from '../app/review-transaction';
+import { UNCONFIRMED_SUBMISSION_MESSAGE } from '../src/utils/paymentErrors';
+
+const mockUseRouter = useRouter as jest.MockedFunction<typeof useRouter>;
+const mockUseLocalSearchParams = useLocalSearchParams as jest.MockedFunction<typeof useLocalSearchParams>;
+const mockUseWalletStore = useWalletStore as jest.MockedFunction<typeof useWalletStore>;
+const mockSendXlmTransaction = sendXlmTransaction as jest.MockedFunction<typeof sendXlmTransaction>;
+
+const mockBack = jest.fn();
+const mockReplace = jest.fn();
+
+describe('ReviewTransactionScreen negative paths', () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+    useSignerStore.getState().reset();
+    mockUseRouter.mockReturnValue({
+      back: mockBack,
+      replace: mockReplace,
+      push: jest.fn(),
+    } as any);
+    mockUseLocalSearchParams.mockReturnValue({
+      destination: 'GDEST123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890ABCD',
+      amount: '10',
+      memo: 'invoice-42',
+    } as any);
+    mockUseWalletStore.mockReturnValue({
+      publicKey: 'GSOURCE123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890ABC',
+      getSecretKey: jest.fn(async () => 'SSECRET123'),
+      refreshWalletData: jest.fn(),
+      addPendingTransaction: jest.fn(),
+    } as any);
+  });
+
+  it('shows a safe unconfirmed-submission message when the network request fails', async () => {
+    mockSendXlmTransaction.mockRejectedValueOnce(new Error('fetch failed'));
+
+    const { getByText } = render(<ReviewTransactionScreen />);
+    fireEvent.press(getByText('Sign & Send'));
+
+    await waitFor(() => {
+      expect(getByText('Transaction Failed')).toBeTruthy();
+      expect(getByText(UNCONFIRMED_SUBMISSION_MESSAGE)).toBeTruthy();
+      expect(getByText('Go Back')).toBeTruthy();
+    });
+  });
+
+  it('surfaces a clear insufficient-balance failure from submission', async () => {
+    mockSendXlmTransaction.mockRejectedValueOnce(new Error('op_underfunded'));
+
+    const { getByText } = render(<ReviewTransactionScreen />);
+    fireEvent.press(getByText('Sign & Send'));
+
+    await waitFor(() => {
+      expect(getByText('Transaction Failed')).toBeTruthy();
+      expect(getByText(UNCONFIRMED_SUBMISSION_MESSAGE)).toBeTruthy();
+    });
+  });
+
+  it('shows the cancelled state clearly when signing is aborted before submission', () => {
+    useSignerStore.getState().cancelSigning();
+
+    const { getByText } = render(<ReviewTransactionScreen />);
+
+    expect(getByText('Cancelled')).toBeTruthy();
+    expect(getByText('Signing was cancelled. No transaction was submitted.')).toBeTruthy();
+    expect(getByText('Go Back')).toBeTruthy();
+  });
+});

__tests__/send.test.tsx

@@ -5,8 +5,8 @@
  *  AC1 – Invalid address error is tested (empty destination blocks submit)
  *  AC2 – Invalid amount error is tested (zero / negative amount blocks submit)
  *  AC3 – Submit is blocked when the form is invalid
- *  AC4 – Valid form calls sendXlmTransaction
- *  AC5 – Failure in sendXlmTransaction displays an error alert
+ *  AC4 – Valid form routes into sign confirmation
+ *  AC5 – Validation includes missing balance / reserve protection states
  *  AC6 – Scan option exists on the destination field
  *  AC7 – Camera permission is handled (denied state shown, grant flow works)
  *  AC8 – A valid scanned address fills the destination field and closes the scanner
@@ -72,11 +72,9 @@ jest.mock('expo-camera', () => ({
 
 // ─── Typed mock imports ──────────────────────────────────────────────────
 
-import { sendXlmTransaction } from '../src/services/stellar';
 import { useWalletStore } from '../src/store/walletStore';
 import { useRouter } from 'expo-router';
 
-const mockSendXlmTransaction = sendXlmTransaction as jest.MockedFunction<typeof sendXlmTransaction>;
 const mockUseWalletStore    = useWalletStore as jest.MockedFunction<typeof useWalletStore>;
 const mockUseRouter         = useRouter     as jest.MockedFunction<typeof useRouter>;
 
@@ -120,7 +118,6 @@ beforeEach(() => {
   alertSpy.mockImplementation(() => undefined);
   mockUseRouter.mockReturnValue({ back: mockBack, push: mockPush, replace: mockReplace } as any);
   setupWalletStore();
-  mockSendXlmTransaction.mockResolvedValue({ hash: 'abc123' } as any);
   mockPermissionGranted = true;
   mockPermissionCanAskAgain = true;
 });
@@ -175,6 +172,19 @@ describe('AC2 – invalid amount error', () => {
 
     expect(getByText("You don't have enough XLM for this payment.")).toBeTruthy();
   });
+
+  it('shows a reserve-protection error when the payment would leave too little XLM behind', async () => {
+    setupWalletStore({ balance: '5.0000000' });
+    const { getByPlaceholderText, getByText } = render(<SendScreen />);
+
+    fireEvent.changeText(getByPlaceholderText('G...'), VALID_DESTINATION);
+    fireEvent.changeText(getByPlaceholderText('0.00'), '4.5');
+    fireEvent.press(getByText('Send Payment'));
+
+    expect(
+      getByText('You need to keep at least 1 XLM in your wallet, so this amount is too high.'),
+    ).toBeTruthy();
+  });
 });
 
 // ────────────────────────────────────────────────────────────────────────
@@ -200,16 +210,28 @@ describe('AC3 – submit is blocked when the form is invalid', () => {
     fireEvent.press(getByText('Send Payment'));
 
     expect(getByText('Amount must be more than 0.')).toBeTruthy();
-    expect(mockSendXlmTransaction).not.toHaveBeenCalled();
+    expect(mockPush).not.toHaveBeenCalled();
+  });
+
+  it('does not continue when the recipient is the current wallet', async () => {
+    setupWalletStore({ publicKey: VALID_DESTINATION });
+    const { getByPlaceholderText, getByText } = render(<SendScreen />);
+
+    fireEvent.changeText(getByPlaceholderText('G...'), VALID_DESTINATION);
+    fireEvent.changeText(getByPlaceholderText('0.00'), VALID_AMOUNT);
+    fireEvent.press(getByText('Send Payment'));
+
+    expect(getByText("You can't send a payment to your own wallet.")).toBeTruthy();
+    expect(mockPush).not.toHaveBeenCalled();
   });
 });
 
 // ────────────────────────────────────────────────────────────────────────
-// AC4 – Valid form calls sendXlmTransaction
+// AC4 – Valid form routes into sign confirmation
 // ────────────────────────────────────────────────────────────────────────
 
-describe('AC4 – valid form calls router.push to review-transaction', () => {
-  it('navigates to review-transaction with correct arguments on a valid submission', async () => {
+describe('AC4 – valid form routes into sign confirmation', () => {
+  it('navigates to sign-confirmation with correct arguments on a valid submission', async () => {
     const { getByPlaceholderText, getByText } = render(<SendScreen />);
 
     fireEvent.changeText(getByPlaceholderText('G...'), VALID_DESTINATION);
@@ -218,17 +240,21 @@ describe('AC4 – valid form calls router.push to review-transaction', () => {
 
     await waitFor(() => {
       expect(mockPush).toHaveBeenCalledWith({
-        pathname: '/review-transaction',
+        pathname: '/sign-confirmation',
         params: {
+          source: 'GPUBLIC123',
           destination: VALID_DESTINATION,
           amount: VALID_AMOUNT,
+          assetCode: 'XLM',
           memo: '',
+          fee: '100',
+          network: 'Testnet',
         },
       });
     });
   });
 
-  it('passes memo text to review-transaction params when provided', async () => {
+  it('passes memo text to sign-confirmation params when provided', async () => {
     const { getByPlaceholderText, getByText } = render(<SendScreen />);
 
     fireEvent.changeText(getByPlaceholderText('G...'), VALID_DESTINATION);
@@ -238,11 +264,15 @@ describe('AC4 – valid form calls router.push to review-transaction', () => {
 
     await waitFor(() => {
       expect(mockPush).toHaveBeenCalledWith({
-        pathname: '/review-transaction',
+        pathname: '/sign-confirmation',
         params: {
+          source: 'GPUBLIC123',
           destination: VALID_DESTINATION,
           amount: VALID_AMOUNT,
+          assetCode: 'XLM',
           memo: 'invoice-42',
+          fee: '100',
+          network: 'Testnet',
         },
       });
     });
@@ -322,7 +352,7 @@ describe('AC7 – camera permission handling', () => {
 // ────────────────────────────────────────────────────────────────────────
 
 describe('AC8 – valid scan fills destination field', () => {
-  it('closes the scanner and calls sendXlmTransaction with the scanned address on submit', async () => {
+  it('closes the scanner and routes into sign confirmation with the scanned address on submit', async () => {
     const { getByLabelText, getByPlaceholderText, getByText, queryByText } = render(<SendScreen />);
 
     // We drive this through the same handler the QrScanner would call: onScan.
@@ -339,11 +369,15 @@ describe('AC8 – valid scan fills destination field', () => {
 
     await waitFor(() => {
       expect(mockPush).toHaveBeenCalledWith({
-        pathname: '/review-transaction',
+        pathname: '/sign-confirmation',
         params: {
+          source: 'GPUBLIC123',
           destination: SCANNED_ADDRESS,
           amount: VALID_AMOUNT,
+          assetCode: 'XLM',
           memo: '',
+          fee: '100',
+          network: 'Testnet',
         },
       });
     });

docs/user-flows.md

@@ -101,12 +101,21 @@ New keypairs do not exist on the Stellar ledger until they receive their first T
 3. Tapping **Send Payment** validates locally before navigating:
    - destination and amount are required;
    - amount must be greater than zero; and
-   - amount must not exceed the displayed balance.
-4. If validation passes, navigate to `/review-transaction` with the payment details.
+   - amount must not exceed the displayed balance or violate the XLM reserve floor.
+4. Validation failures stay inline on the form so the user can correct the destination, amount, or memo safely.
+5. If validation passes, navigate to `/sign-confirmation` with the payment details.
+
+### Sign Confirmation
+
+**Entry:** Send → **Send Payment** (after validation) → `/sign-confirmation`.
+
+1. The Sign Confirmation screen shows the final source, destination, amount, memo, fee, and network details before any signing happens.
+2. Tapping **Cancel** keeps signing separate from editing and lets the user abort before any transaction is signed or submitted.
+3. Tapping **Sign Transaction** continues to `/review-transaction`.
 
 ### Transaction Review
 
-**Entry:** Send → **Send Payment** (after validation) → `/review-transaction`.
+**Entry:** Sign Confirmation → **Sign Transaction** → `/review-transaction`.
 
 1. The Review screen displays the full transaction details: source, destination (with contact label if known), amount, memo, and network.
 2. A signer info card shows which signer will be used (currently "This Device") and its security model.
@@ -115,7 +124,7 @@ New keypairs do not exist on the Stellar ledger until they receive their first T
    - Phase transitions: `review` → `handoff` → `signing` → `submitting` → `completed`
    - A loading indicator shows the current phase.
 5. On success, a success card appears with the transaction hash, then the user is navigated to the payment success screen.
-6. On failure, a red error card appears with the error message and a **Dismiss** button that returns to the Send screen.
+6. On failure, a red error card appears with safe, actionable copy and a **Go Back** path so the user can leave the failed state without risking a duplicate submission.
 7. At any point before submission, the user can tap **Cancel** to abort and return to Send.
 
 **Expected states**