Added test for cronjob and scaledjob image substitution

Author: benjaminbob21

.github/workflows/integration-test.yml

@@ -81,7 +81,7 @@ jobs:
                 
                 # Verify the image in the actual cluster resource
                 ACTUAL_IMAGE=$(kubectl get cronjob integration-test-cronjob -n default -o jsonpath='{.spec.jobTemplate.spec.template.spec.containers[0].image}')
-                EXPECTED_IMAGE="${{ env.REGISTRY }}/${{ env.PROJECT_ID }}/${{ env.REPOSITORY }}/image:${{ github.sha }}"
+                EXPECTED_IMAGE="asia-south1-docker.pkg.dev/project/repo/image:${{ github.sha }}"
                 
                 echo "Expected image: ${EXPECTED_IMAGE}"
                 echo "Actual image in cluster: ${ACTUAL_IMAGE}"
@@ -207,11 +207,10 @@ jobs:
               images: |
                  asia-south1-docker.pkg.dev/project/repo/image:${{ github.sha }}
 
-         - name: Verify old version results
+         - name: Verify old version CronJob results
            run: |
-              echo "=== Old Version Test Results ==="
+              echo "=== Old Version CronJob Test Results ==="
               echo "CronJob outcome: ${{ steps.cronjob-old.outcome }}"
-              echo "ScaledJob outcome: ${{ steps.scaledjob-old.outcome }}"
 
               # CronJob should work with old version
               if [[ "${{ steps.cronjob-old.outcome }}" == "success" ]]; then
@@ -220,27 +219,58 @@ jobs:
                 # Verify CronJob was actually created
                 if kubectl get cronjob integration-test-cronjob -n default; then
                   echo "✅ CronJob created by old version"
+                  
+                  # Verify the image in the actual cluster resource
+                  ACTUAL_IMAGE=$(kubectl get cronjob integration-test-cronjob -n default -o jsonpath='{.spec.jobTemplate.spec.template.spec.containers[0].image}')
+                  EXPECTED_IMAGE="asia-south1-docker.pkg.dev/project/repo/image:${{ github.sha }}"
+                  
+                  echo "Expected image: ${EXPECTED_IMAGE}"
+                  echo "Actual image in cluster: ${ACTUAL_IMAGE}"
+                  
+                  if [[ "${ACTUAL_IMAGE}" == "${EXPECTED_IMAGE}" ]]; then
+                    echo "✅ Old version CronJob image substitution SUCCESSFUL"
+                  else
+                    echo "❌ Old version CronJob image substitution FAILED"
+                    exit 1
+                  fi
                 else
                   echo "❌ CronJob not found despite success outcome"
+                  exit 1
                 fi
               else
                 echo "❌ Old version failed on CronJob (unexpected)"
+                exit 1
               fi
 
+         - name: Verify old version ScaledJob results
+           run: |
+              echo "=== Old Version ScaledJob Test Results ==="
+              echo "ScaledJob outcome: ${{ steps.scaledjob-old.outcome }}"
+
               # ScaledJob should fail with old version (unsupported workload type)
               if [[ "${{ steps.scaledjob-old.outcome }}" == "failure" ]]; then
                 echo "✅ Old version failed on ScaledJob as expected (unsupported workload type)"
                 
-                # Verify ScaledJob was NOT created
+                # Verify ScaledJob was NOT created (because old version doesn't support it)
                 if ! kubectl get scaledjob integration-test-scaledjob -n default 2>/dev/null; then
-                  echo "✅ ScaledJob correctly not created by old version"
+                  echo "✅ ScaledJob correctly NOT created by old version"
+                  echo "This proves old version doesn't recognize ScaledJob as a workload type"
                 else
-                  echo "❌ ScaledJob was unexpectedly created"
+                  echo "❌ ScaledJob was unexpectedly created by old version"
+                  exit 1
                 fi
               else
                 echo "❌ Old version should have failed on ScaledJob but didn't"
+                echo "Expected: ScaledJob not supported in v5.0.3"
                 exit 1
               fi
 
+         - name: Summary of version comparison
+           run: |
               echo "🎉 Version comparison test completed successfully!"
-              echo "This proves that the old version doesn't support ScaledJob workloads"
+              echo ""
+              echo "Results summary:"
+              echo "✅ Current version: Both CronJob and ScaledJob work with image substitution"
+              echo "✅ Old version (v5.0.3): CronJob works, ScaledJob fails (unsupported)"
+              echo ""
+              echo "This definitively proves the ScaledJob support enhancement!"