Skip to content

Commit e2d59e2

Browse files
authored
Merge pull request #7164 from BOINC/dpa_buda29
web: fix bug in BUDA app deletion
2 parents ce4a5b3 + f1fa950 commit e2d59e2

1 file changed

Lines changed: 14 additions & 3 deletions

File tree

html/user/buda.php

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,13 @@ function variant_delete() {
462462
unlink($phys_path);
463463
unlink("$phys_path.md5");
464464
}
465-
system("rm -r $buda_root/$app/$variant", $ret);
465+
system(
466+
sprintf(
467+
'rm -r %s',
468+
escapeshellarg("$buda_root/$app/$variant")
469+
),
470+
$ret
471+
);
466472
if ($ret) {
467473
error_page("delete failed");
468474
}
@@ -491,8 +497,13 @@ function app_delete() {
491497
if ($vars) {
492498
error_page("You must delete all variants first.");
493499
}
494-
system("rm $buda_root/$app/desc.json", $ret);
495-
system("rmdir $buda_root/$app", $ret);
500+
system(
501+
sprintf(
502+
'rm -r %s',
503+
escapeshellarg("$buda_root/$app")
504+
),
505+
$ret
506+
);
496507
if ($ret) {
497508
error_page('delete failed');
498509
}

0 commit comments

Comments
 (0)