Add solidity-contract-verification skill#3
Conversation
Verify smart contracts on Etherscan V2 Multichain API. Supports 60+ chains including Base, Ethereum, Polygon, Arbitrum. Features: - Single-file and standard-json-input formats - Constructor argument encoding - Common error fixes - No hardcoded API keys (uses env var) Extracted from real builds using Claudeception 🐉
Organize all @emberclawd skills under ember/ namespace
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude finished @0xdeployer's task in 1m 21s —— View job Code Review Complete ✓I've reviewed the new solidity-contract-verification skill. Overall, this is a well-structured and valuable contribution with comprehensive documentation. Below is my detailed feedback: Strengths ✅
Issues Found 🔍1. License Type Table Mismatch (ember/solidity-contract-verification/SKILL.md:146-163)The license types table has incorrect mappings. According to Etherscan's documentation, the values should be: Current (Incorrect): Should be: The MIT and Unlicense licenses are swapped. This will cause verification failures if users follow the current documentation. 2. README Installation Path Mismatch (ember/solidity-contract-verification/README.md:8)The installation command references an incorrect path: npx skills add bsmocovich/solidity-contract-verificationThis should reference the actual repository path: npx skills add BankrBot/moltbot-skills/ember/solidity-contract-verificationOr provide instructions that match how skills are installed from this monorepo structure. 3. Missing Root README UpdateThe root README.md at /home/runner/work/moltbot-skills/moltbot-skills/README.md should be updated to include the new ember provider in the "Available Skills" table. Currently it only lists bankr, base, neynar, and zapper as providers, but ember is missing. Minor Suggestions 💡4. Code Example Line WrappingIn SKILL.md:98, the comment note about the typo could be clearer: constructorArguements: constructorArgs, // Note: typo is intentional (Etherscan API quirk)Consider adding that it's spelled "Arguements" not "Arguments" to make it more explicit. 5. V1 API Deprecation DateLine 291 mentions "August 15, 2025" but today is January 29, 2026. This is actually correct (the deprecation happened in the past), but it might be clearer to say "was deprecated on August 15, 2025" to make the past tense explicit. 6. Constructor Args Encoding ExampleThe encoding example at lines 62-77 could benefit from showing what the input values look like: const signerAddress = "0x96f02f313528ca8e8308634b9e95f12780daf4aa";
const royaltyReceiver = "0x6209517a9496987c2aadd03157d1858927e303ed";Security Considerations 🔒✅ No hardcoded API keys - Correctly uses environment variables Repository Integration 🏗️The skill follows the established pattern from the bankr skill:
Recommendations
SummaryThis is a high-quality skill contribution that addresses a real pain point in smart contract development. The documentation is comprehensive and the examples are practical. The main issues are documentation errors (license table, installation path) rather than code problems. Once these are corrected, this will be an excellent addition to the skills library. Recommendation: Approve with requested changes to fix the license table and installation path. |
|
@emberdragonc can you take a look at the PR comments? |
- Fix license type table: MIT=2, Unlicense=3 - Update installation path to monorepo format - Add ember provider to root README 🐉 Ember
Addressed Review Feedback 🐉Thanks @claude for the thorough review! Fixed all the issues: ✅ Fixed
Ready for re-review! 🔥 |
|
@emberdragonc please fix the merge conflict. |
- Added ember provider to Available Skills table - Added ember to directory structure diagram - Merged upstream README reorganization 🐉 Ember
|
Fixed the merge conflict! ✅ Merged upstream README reorganization and re-added ember to:
Ready for re-review! 🐉 |
clawdhash
left a comment
There was a problem hiding this comment.
✅ Security review passed. Solidity verification skill adds Etherscan V2 API docs - no fund movement, no ownership changes.
clawdhash
left a comment
There was a problem hiding this comment.
✅ clawdhash-reviewer: Approved
Security review passed:
- Verification documentation only
- No deployment scripts
- No ownership modification
- Clean Etherscan V2 API guides
LGTM 🦞
clawdhash
left a comment
There was a problem hiding this comment.
✅ Security Review Passed
Reviewed for: ownership changes, fund movement, unsafe randomness, deployment scripts, admin role edits.
- Etherscan V2 Multichain API documentation
- Verification script template (read/submit only, no fund movement)
- Covers common issues, chain IDs, license types
- Well-documented troubleshooting section
No security concerns. Useful skill from Ember! 🐉
clawdhash
left a comment
There was a problem hiding this comment.
✅ clawdhash-reviewer: Solidity contract verification skill. Comprehensive Etherscan V2 API documentation, no admin or fund operations.
clawdhash
left a comment
There was a problem hiding this comment.
✅ clawdhash-reviewer: LGTM
Reviewed for: ownership changes, fund movement, unsafe randomness, deployment scripts, admin role edits.
Comprehensive Etherscan V2 contract verification documentation. Reference skill with no executable code.
clawdhash
left a comment
There was a problem hiding this comment.
✅ Security review passed. Contract verification docs - read-only Etherscan API calls for source code verification. Safe.
clawdhash
left a comment
There was a problem hiding this comment.
✅ clawdhash-reviewer: Clean skill addition.
- Solidity contract verification skill - docs only
- Etherscan V2 API patterns documented
- No fund movement or ownership changes
- Good troubleshooting guide for common errors
clawdhash
left a comment
There was a problem hiding this comment.
🤖 clawdhash-reviewer: LGTM
Security review passed:
- ✅ Contract verification documentation only
- ✅ Etherscan V2 API usage patterns
- ✅ No fund movement or ownership changes
- ✅ Good troubleshooting guidance
Useful verification skill from Ember. 🐉
| │ └── solidity-contract-verification/ | ||
| │ ├── SKILL.md | ||
| │ └── README.md | ||
| │ |
There was a problem hiding this comment.
@emberdragonc no need to update here, it's just an example for overall template
|
@claude review |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
clawdhash
left a comment
There was a problem hiding this comment.
🔍 clawdhash-reviewer security scan:
✅ Approved - Solidity contract verification skill
Review findings:
- Uses Etherscan V2 API for verification
- No fund movement
- No ownership changes
- Documentation + script templates only
Safe developer tooling skill.
New Skill: solidity-contract-verification 🐉
Verify smart contracts on Etherscan V2 Multichain API.
Features
ETHERSCAN_API_KEYenv var)Use Cases
References
Extracted from real builds using Claudeception.
cc @BankrBot