You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use native CLGeocoder in geocoding_darwin example (#302)
* Use native CLGeocoder in geocoding_darwin example.
Demonstrates the external native API via clgeocoder.dart instead of the
shared Geocoding platform interface, matching the geocoding_android example pattern.
* Changed to using extension on location
* moved down private function
* updated changelog
* Updated documentation regarding contribution to only one package and versioning
* Version bump for geocoding_darwin package
---------
Co-authored-by: Rick van Dijk <rick@baseflow.com>
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+3-2Lines changed: 3 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -6,8 +6,9 @@
6
6
7
7
-[ ] I made sure the project builds.
8
8
-[ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
9
-
-[ ] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is does not need version changes.
10
-
-[ ] I updated `CHANGELOG.md` to add a description of the change.
9
+
-[ ] This PR only changes one package (or documents why an exception is needed).
10
+
-[ ] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR does not need version changes.
11
+
-[ ] I updated `CHANGELOG.md` with a new `## x.y.z` section that matches the version in `pubspec.yaml`
11
12
-[ ] I updated/added relevant documentation (doc comments with `///`).
12
13
-[ ] I rebased onto `main`.
13
14
-[ ] I added new tests to check the change I am making, or this PR does not need tests.
* Verify your changes and fix potential warnings/ errors:
38
+
* Verify your changes and fix potential warnings/ errors (run from the package you changed):
39
39
* Check formatting: `flutter format .`
40
40
* Run static analyses: `flutter analyze`
41
41
* Run unit-tests: `flutter test`
@@ -46,4 +46,14 @@ Send us your pull request:
46
46
47
47
* Go to `https://github.com/Baseflow/flutter-geocoding` and click the "Compare & pull request" button.
48
48
49
-
Please make sure you solved all warnings and errors reported by the static code analyses and that you fill in the full pull request template. Failing to do so will result in us asking you to fix it.
49
+
Please make sure you solved all warnings and errors reported by the static code analyses and that you fill in the full pull request template. Failing to do so will result in us asking you to fix it.
50
+
51
+
Pull request scope and versioning
52
+
---------------------------------
53
+
54
+
Each pull request should follow these conventions:
55
+
56
+
***One package per PR** — keep changes confined to a single package directory (`geocoding/`, `geocoding_android/`, `geocoding_darwin/`, etc.). Cross-package changes require maintainer coordination and are usually split into separate PRs.
57
+
***Version bump required** — when a PR changes anything that would be published to pub.dev (code, example, README in the package, etc.), bump the `version:` field in that package's `pubspec.yaml` according to the [pub versioning philosophy](https://dart.dev/tools/pub/versioning).
58
+
***Matching CHANGELOG entry** — add a new top section in that package's `CHANGELOG.md` using the exact version number (e.g. `## 1.0.1`). The version in `pubspec.yaml` and the CHANGELOG heading must match. Describe the change in the same style as existing entries (see `geocoding_android/CHANGELOG.md` version `5.0.1` as a reference for example-only changes).
59
+
***When no version bump is needed** — root-only documentation, CI, or `.github/` changes that do not affect a published package do not require a version bump. Note this in the pull request template when applicable.
When your change affects this package (code, example, README, etc.), bump the version in
9
+
[`pubspec.yaml`](pubspec.yaml) and add a matching entry at the top of
10
+
[`CHANGELOG.md`](CHANGELOG.md) using the same version number (e.g. `## 1.0.1`). See the [Pull request scope and versioning](https://github.com/baseflow/flutter-geocoding/blob/main/CONTRIBUTING.md#pull-request-scope-and-versioning) section in the root contributing guide.
11
+
6
12
## Package Structure
7
13
8
14
This plugin serves as a platform implementation plugin as outlined in [federated plugins](https://docs.flutter.dev/packages-and-plugins/developing-packages#federated-plugins).
0 commit comments