only redirecting if jwt is missing for the index action for fees

Author: davezuckerman

app/controllers/fees_controller.rb

@@ -2,18 +2,18 @@
 
 class FeesController < ApplicationController
 
-  rescue_from ActionController::ParameterMissing, with: :missing_params
-
   # This will be needed for transaction_complete since Paypal will hit that
   protect_from_forgery with: :null_session
 
   def index
-    @jwt = params.require(:jwt)
-    decoded_token = JWT.decode @jwt, nil, false
-    @alma_id = decoded_token.first['userName']
-    @fees = FeesPayment.new(alma_id: @alma_id)
-  rescue JWT::DecodeError
-    redirect_to(action: :transaction_error)
+      @jwt = params.require(:jwt)
+      decoded_token = JWT.decode @jwt, nil, false
+      @alma_id = decoded_token.first['userName']
+      @fees = FeesPayment.new(alma_id: @alma_id)
+    rescue ActionController::ParameterMissing
+      redirect_to 'https://www.lib.berkeley.edu/find/borrow-renew?section=pay-fees', allow_other_host: true
+    rescue JWT::DecodeError
+      redirect_to(action: :transaction_error)
   end
 
   def efee
@@ -78,10 +78,6 @@ def transaction_complete
 
   private
 
-  def missing_params(_error)
-    redirect_to 'https://lib.berkeley.edu/find/borrow-renew?section=pay-fees', allow_other_host: true
-  end
-
   def authorize!
     return if Rails.env.development?
 

spec/request/fees_request_spec.rb

@@ -14,7 +14,7 @@ def base_url_for(user_id = nil)
 
   it 'redirects to the fallback URL if there is no jwt' do
     get fees_path
-    expect(response).to redirect_to('https://lib.berkeley.edu/find/borrow-renew?section=pay-fees')
+    expect(response).to redirect_to('https://www.lib.berkeley.edu/find/borrow-renew?section=pay-fees')
   end
 
   it 'redirects to error page if request has a non-existant alma id' do