Skip to content

Commit e8d81ed

Browse files
committed
Use p/do in e2e test orchestrators
Replace p/let with _ bindings with p/do for cleaner sequential dispatch of test helper functions.
1 parent 66dae73 commit e8d81ed

3 files changed

Lines changed: 17 additions & 17 deletions

File tree

e2e-test-ws/.joyride/src/tests/mcp/balance_brackets_test.cljs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@
4747
(:isError result)))))))
4848

4949
(deftest-async balance-brackets-tests
50-
(-> (p/let [{:keys [socket]} (mcp/start-mcp-session!)
51-
_ (test-balanced-input+ socket)
52-
_ (test-unbalanced-input+ socket)
53-
_ (test-broken-brackets+ socket)
54-
_ (test-missing-text-param+ socket)
55-
_ (mcp/stop-mcp-session! socket)])
50+
(-> (p/let [{:keys [socket]} (mcp/start-mcp-session!)]
51+
(p/do (test-balanced-input+ socket)
52+
(test-unbalanced-input+ socket)
53+
(test-broken-brackets+ socket)
54+
(test-missing-text-param+ socket)
55+
(mcp/stop-mcp-session! socket)))
5656
(p/catch (fn [e]
5757
(js/console.error "[balance-brackets] Test error:" (.-message e) e)
5858
(vscode/commands.executeCommand "calva-backseat-driver.stopMcpServer")

e2e-test-ws/.joyride/src/tests/mcp/clojuredocs_info_test.cljs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,11 @@
4949
(deftest-async clojuredocs-info-tests
5050
(let [backup-path (mcp/backup-settings! "clojuredocs-info-test-backup.json")]
5151
(-> (p/let [_ (mcp/ensure-repl-and-eval-enabled!)
52-
{:keys [socket]} (mcp/start-mcp-session!)
53-
_ (test-well-known-symbol+ socket)
54-
_ (test-nonexistent-symbol+ socket)
55-
_ (test-missing-symbol-param+ socket)
56-
_ (mcp/stop-mcp-session! socket)])
52+
{:keys [socket]} (mcp/start-mcp-session!)]
53+
(p/do (test-well-known-symbol+ socket)
54+
(test-nonexistent-symbol+ socket)
55+
(test-missing-symbol-param+ socket)
56+
(mcp/stop-mcp-session! socket)))
5757
(p/catch (fn [e]
5858
(js/console.error "[clojuredocs-info] Test error:" (.-message e) e)
5959
(vscode/commands.executeCommand "calva-backseat-driver.stopMcpServer")

e2e-test-ws/.joyride/src/tests/mcp/symbol_info_test.cljs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,12 @@
7373
(let [backup-path (mcp/backup-settings! "symbol-info-test-backup.json")]
7474
(-> (p/let [_ (mcp/ensure-repl-and-eval-enabled!)
7575
{:keys [socket]} (mcp/start-mcp-session!)
76-
session-key (get-active-session-key+ socket)
77-
_ (test-known-symbol+ socket session-key)
78-
_ (test-unknown-symbol+ socket session-key)
79-
_ (test-missing-session-key+ socket)
80-
_ (test-invalid-session-key+ socket)
81-
_ (mcp/stop-mcp-session! socket)])
76+
session-key (get-active-session-key+ socket)]
77+
(p/do (test-known-symbol+ socket session-key)
78+
(test-unknown-symbol+ socket session-key)
79+
(test-missing-session-key+ socket)
80+
(test-invalid-session-key+ socket)
81+
(mcp/stop-mcp-session! socket)))
8282
(p/catch (fn [e]
8383
(js/console.error "[symbol-info] Test error:" (.-message e) e)
8484
(vscode/commands.executeCommand "calva-backseat-driver.stopMcpServer")

0 commit comments

Comments
 (0)